database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
sql/ha_sequence.h
View File

@ -67,44 +67,44 @@ public:
~ha_sequence();
/* virtual function that are re-implemented for sequence */
int open(const char *name, int mode, uint test_if_locked);
int open(const char *name, int mode, uint test_if_locked) override;
int create(const char *name, TABLE *form,
HA_CREATE_INFO *create_info);
handler *clone(const char *name, MEM_ROOT *mem_root);
int write_row(const uchar *buf);
Table_flags table_flags() const;
HA_CREATE_INFO *create_info) override;
handler *clone(const char *name, MEM_ROOT *mem_root) override;
int write_row(const uchar *buf) override;
Table_flags table_flags() const override;
/* One can't update or delete from sequence engine */
int update_row(const uchar *old_data, const uchar *new_data)
int update_row(const uchar *old_data, const uchar *new_data) override
{ return HA_ERR_WRONG_COMMAND; }
int delete_row(const uchar *buf)
int delete_row(const uchar *buf) override
{ return HA_ERR_WRONG_COMMAND; }
/* One can't delete from sequence engine */
int truncate()
int truncate() override
{ return HA_ERR_WRONG_COMMAND; }
/* Can't use query cache */
uint8 table_cache_type()
uint8 table_cache_type() override
{ return HA_CACHE_TBL_NOCACHE; }
void print_error(int error, myf errflag);
int info(uint);
LEX_CSTRING *engine_name() { return hton_name(file->ht); }
int external_lock(THD *thd, int lock_type);
int extra(enum ha_extra_function operation);
void print_error(int error, myf errflag) override;
int info(uint) override;
LEX_CSTRING *engine_name() override { return hton_name(file->ht); }
int external_lock(THD *thd, int lock_type) override;
int extra(enum ha_extra_function operation) override;
/* For ALTER ONLINE TABLE */
bool check_if_incompatible_data(HA_CREATE_INFO *create_info,
uint table_changes);
uint table_changes) override;
void write_lock() { write_locked= 1;}
void unlock() { write_locked= 0; }
bool is_locked() { return write_locked; }
/* Functions that are directly mapped to the underlying handler */
int rnd_init(bool scan)
int rnd_init(bool scan) override
{ return file->rnd_init(scan); }
/*
We need to have a lock here to protect engines like MyISAM from
simultaneous read and write. For sequence's this is not critical
as this function is used extremely seldom.
*/
int rnd_next(uchar *buf)
int rnd_next(uchar *buf) override
{
int error;
table->s->sequence->read_lock(table);
@ -112,9 +112,9 @@ public:
table->s->sequence->read_unlock(table);
return error;
}
int rnd_end()
int rnd_end() override
{ return file->rnd_end(); }
int rnd_pos(uchar *buf, uchar *pos)
int rnd_pos(uchar *buf, uchar *pos) override
{
int error;
table->s->sequence->read_lock(table);
@ -122,37 +122,37 @@ public:
table->s->sequence->read_unlock(table);
return error;
}
void position(const uchar *record)
void position(const uchar *record) override
{ return file->position(record); }
const char *table_type() const
{ return file->table_type(); }
ulong index_flags(uint inx, uint part, bool all_parts) const
ulong index_flags(uint inx, uint part, bool all_parts) const override
{ return file->index_flags(inx, part, all_parts); }
THR_LOCK_DATA **store_lock(THD *thd, THR_LOCK_DATA **to,
enum thr_lock_type lock_type)
enum thr_lock_type lock_type) override
{ return file->store_lock(thd, to, lock_type); }
int close(void)
int close(void) override
{ return file->close(); }
const char **bas_ext() const
{ return file->bas_ext(); }
int delete_table(const char*name)
int delete_table(const char*name) override
{ return file->delete_table(name); }
int rename_table(const char *from, const char *to)
int rename_table(const char *from, const char *to) override
{ return file->rename_table(from, to); }
void unbind_psi()
void unbind_psi() override
{ file->unbind_psi(); }
void rebind_psi()
void rebind_psi() override
{ file->rebind_psi(); }
bool auto_repair(int error) const
bool auto_repair(int error) const override
{ return file->auto_repair(error); }
int repair(THD* thd, HA_CHECK_OPT* check_opt)
int repair(THD* thd, HA_CHECK_OPT* check_opt) override
{ return file->repair(thd, check_opt); }
bool check_and_repair(THD *thd)
bool check_and_repair(THD *thd) override
{ return file->check_and_repair(thd); }
bool is_crashed() const
bool is_crashed() const override
{ return file->is_crashed(); }
void column_bitmaps_signal()
void column_bitmaps_signal() override
{ return file->column_bitmaps_signal(); }
/* New methods */