database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
plugin/handler_socket/handlersocket/database.cpp
View File

@@ -84,10 +84,10 @@ prep_stmt::operator =(const prep_stmt& x)
struct database : public database_i, private noncopyable {
database(const config& c);
virtual ~database();
virtual dbcontext_ptr create_context(bool for_write) volatile;
virtual void stop() volatile;
virtual const config& get_conf() const volatile;
~database() override;
dbcontext_ptr create_context(bool for_write) volatile override;
void stop() volatile override;
const config& get_conf() const volatile override;
public:
int child_running;
private:
@@ -128,21 +128,21 @@ struct expr_user_lock : private noncopyable {
struct dbcontext : public dbcontext_i, private noncopyable {
dbcontext(volatile database *d, bool for_write);
virtual ~dbcontext();
virtual void init_thread(const void *stack_botton,
volatile int& shutdown_flag);
virtual void term_thread();
virtual bool check_alive();
virtual void lock_tables_if();
virtual void unlock_tables_if();
virtual bool get_commit_error();
virtual void clear_error();
virtual void close_tables_if();
virtual void table_addref(size_t tbl_id);
virtual void table_release(size_t tbl_id);
virtual void cmd_open(dbcallback_i& cb, const cmd_open_args& args);
virtual void cmd_exec(dbcallback_i& cb, const cmd_exec_args& args);
virtual void set_statistics(size_t num_conns, size_t num_active);
~dbcontext() override;
void init_thread(const void *stack_botton,
volatile int& shutdown_flag) override;
void term_thread() override;
bool check_alive() override;
void lock_tables_if() override;
void unlock_tables_if() override;
bool get_commit_error() override;
void clear_error() override;
void close_tables_if() override;
void table_addref(size_t tbl_id) override;
void table_release(size_t tbl_id) override;
void cmd_open(dbcallback_i& cb, const cmd_open_args& args) override;
void cmd_exec(dbcallback_i& cb, const cmd_exec_args& args) override;
void set_statistics(size_t num_conns, size_t num_active) override;
private:
int set_thread_message(const char *fmt, ...)
__attribute__((format (printf, 2, 3)));

4
plugin/handler_socket/handlersocket/hstcpsvr.cpp
View File

@@ -34,8 +34,8 @@ struct worker_throbj {
struct hstcpsvr : public hstcpsvr_i, private noncopyable {
hstcpsvr(const config& c);
~hstcpsvr();
virtual std::string start_listen();
~hstcpsvr() override;
std::string start_listen() override;
private:
hstcpsvr_shared_c cshared;
volatile hstcpsvr_shared_v vshared;

20
plugin/handler_socket/handlersocket/hstcpsvr_worker.cpp
View File

@@ -77,15 +77,15 @@ struct hstcpsvr_conn : public dbcallback_i {
bool write_more(bool *more_r = 0);
bool read_more(bool *more_r = 0);
public:
virtual void dbcb_set_prep_stmt(size_t pst_id, const prep_stmt& v);
virtual const prep_stmt *dbcb_get_prep_stmt(size_t pst_id) const;
virtual void dbcb_resp_short(uint32_t code, const char *msg);
virtual void dbcb_resp_short_num(uint32_t code, uint32_t value);
virtual void dbcb_resp_short_num64(uint32_t code, uint64_t value);
virtual void dbcb_resp_begin(size_t num_flds);
virtual void dbcb_resp_entry(const char *fld, size_t fldlen);
virtual void dbcb_resp_end();
virtual void dbcb_resp_cancel();
void dbcb_set_prep_stmt(size_t pst_id, const prep_stmt& v) override;
const prep_stmt *dbcb_get_prep_stmt(size_t pst_id) const override;
void dbcb_resp_short(uint32_t code, const char *msg) override;
void dbcb_resp_short_num(uint32_t code, uint32_t value) override;
void dbcb_resp_short_num64(uint32_t code, uint64_t value) override;
void dbcb_resp_begin(size_t num_flds) override;
void dbcb_resp_entry(const char *fld, size_t fldlen) override;
void dbcb_resp_end() override;
void dbcb_resp_cancel() override;
public:
hstcpsvr_conn() : addr_len(sizeof(addr)), readsize(4096),
nonblocking(false), read_finished(false), write_finished(false),
@@ -254,7 +254,7 @@ hstcpsvr_conn::dbcb_resp_cancel()
struct hstcpsvr_worker : public hstcpsvr_worker_i, private noncopyable {
hstcpsvr_worker(const hstcpsvr_worker_arg& arg);
virtual void run();
void run() override;
private:
const hstcpsvr_shared_c& cshared;
volatile hstcpsvr_shared_v& vshared;