database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-13375 back_log ignored

Browse Source 
doing SYSVAR_AUTOSIZE() because of back_log > max_connections
enabled "autosized" flag, and that made IS_SYSVAR_AUTOSIZE()
true, which triggered the second SYSVAR_AUTOSIZE.

Remove back_log <= max_connections limit, back_log
doesn't *always* have to be smaller than max_connections.
This commit is contained in:
Sergei Golubchik
2017-08-12 19:09:03 +02:00
parent d07daa3125
commit d924e0b993
4 changed files with 2 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
mysql-test/suite/sys_vars/r/back_log_basic.result
View File

@@ -1,21 +1,3 @@
select @@global.back_log; select @@global.back_log;
@@global.back_log @@global.back_log
80 1000
select @@session.back_log;
ERROR HY000: Variable 'back_log' is a GLOBAL variable
show global variables like 'back_log';
Variable_name Value
back_log 80
show session variables like 'back_log';
Variable_name Value
back_log 80
select * from information_schema.global_variables where variable_name='back_log';
VARIABLE_NAME VARIABLE_VALUE
BACK_LOG 80
select * from information_schema.session_variables where variable_name='back_log';
VARIABLE_NAME VARIABLE_VALUE
BACK_LOG 80
set global back_log=1;
ERROR HY000: Variable 'back_log' is a read only variable
set session back_log=1;
ERROR HY000: Variable 'back_log' is a read only variable

1
mysql-test/suite/sys_vars/t/back_log_basic.opt Normal file
View File

@@ -0,0 +1 @@
--back-log=1000 --max-connections=300

15
mysql-test/suite/sys_vars/t/back_log_basic.test
View File

@@ -2,18 +2,3 @@
# show the global and session values; # show the global and session values;
# #
select @@global.back_log; select @@global.back_log;
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
select @@session.back_log;
show global variables like 'back_log';
show session variables like 'back_log';
select * from information_schema.global_variables where variable_name='back_log';
select * from information_schema.session_variables where variable_name='back_log';
#
# show that it's read-only
#
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
set global back_log=1;
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
set session back_log=1;

2
sql/mysqld.cc
View File

@@ -9674,8 +9674,6 @@ static int get_options(int *argc_ptr, char ***argv_ptr)
#endif #endif
/* Ensure that some variables are not set higher than needed */ /* Ensure that some variables are not set higher than needed */
if (back_log > max_connections)
SYSVAR_AUTOSIZE(back_log, max_connections);
if (thread_cache_size > max_connections) if (thread_cache_size > max_connections)
SYSVAR_AUTOSIZE(thread_cache_size, max_connections); SYSVAR_AUTOSIZE(thread_cache_size, max_connections);