database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-37031 Fix broken server_audit.test on Windows

Browse Source 
- The test was inadvertently skipped on Windows CI, due to the
  unjustified addition of include/have_tlsv13.inc in MDEV-33834 (log TLS
  version). That include didn't make sense here and just reduced
  coverage.

- Once skipped, the test got broken later by MDEV-12182 changes.
  Originally it expected only one localhost:PORT line in the audit log,
  assuming Unix socket connections. But on Windows, MTR uses TCP by
  default, so all entries had :PORT, and the diff failed.

Fix:
- Forced tcp connection for server_audit.test, via .cnf file
  Re-recorded result
  unix_socket + server_audit is still covered by other tests.
- Dropped the have_tlsv13.inc include to restore coverage—it wasn't
  testing TLS versions or ciphers anyway
This commit is contained in:
Vladislav Vaintroub
2025-06-27 16:27:28 +02:00
parent 6efa06805d
commit d4d0dd00b7
3 changed files with 255 additions and 252 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mysql-test/suite/plugins/t/server_audit.test
View File

@@ -1,7 +1,6 @@
--source include/have_plugin_auth.inc
--source include/not_embedded.inc
--source include/have_ssl_communication.inc
--source include/have_tlsv13.inc
if (!$SERVER_AUDIT_SO) {
skip No SERVER_AUDIT plugin;