database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

MDEV-21259 Assertion failed in mtr_t::write()

Browse Source 
btr_free_externally_stored_field(): Pass w=mtr_t::OPT to
note that the BTR_EXTERN_LEN is not necessarily changing
when a multi-page ROW_FORMAT=COMPRESSED off-page column
is being freed, and to allow redundant writes to the redo
log to be optimized away.

Ever since commit 56f6dab1d0
the refactored function mtr_t::write() asserts by default
that the page contents is being changed.
This commit is contained in:
Marko Mäkelä
2019-12-09 21:11:08 +02:00
parent d30dbaa20d
commit d3b2625ba0
3 changed files with 53 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
mysql-test/suite/innodb_zip/r/blob.result Normal file
View File

@@ -0,0 +1,21 @@
#
# MDEV-21259 Assertion 'w != NORMAL || mach_read_from_4(ptr) != val'
# failed in mtr_t::write(), btr_free_externally_stored_field()
#
SET @saved_frequency = @@GLOBAL.innodb_purge_rseg_truncate_frequency;
SET GLOBAL innodb_purge_rseg_truncate_frequency = 1;
CREATE TABLE t1 (c TEXT, f2 INT PRIMARY KEY, f3 INT UNIQUE)
ENGINE=InnoDB ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=4;
SET @level= @@GLOBAL.innodb_compression_level;
SET GLOBAL innodb_compression_level=0;
connect prevent_purge,localhost,root;
START TRANSACTION WITH CONSISTENT SNAPSHOT;
connection default;
INSERT INTO t1 VALUES('a',1,0);
UPDATE t1 SET c= REPEAT('a b ',4096);
REPLACE INTO t1 SELECT * FROM t1;
disconnect prevent_purge;
InnoDB 0 transactions not purged
DROP TABLE t1;
SET GLOBAL innodb_compression_level = @level;
SET GLOBAL innodb_purge_rseg_truncate_frequency = @saved_frequency;

29
mysql-test/suite/innodb_zip/t/blob.test Normal file
View File

@@ -0,0 +1,29 @@
--source include/innodb_page_size_small.inc
--echo #
--echo # MDEV-21259 Assertion 'w != NORMAL || mach_read_from_4(ptr) != val'
--echo # failed in mtr_t::write(), btr_free_externally_stored_field()
--echo #
SET @saved_frequency = @@GLOBAL.innodb_purge_rseg_truncate_frequency;
SET GLOBAL innodb_purge_rseg_truncate_frequency = 1;
CREATE TABLE t1 (c TEXT, f2 INT PRIMARY KEY, f3 INT UNIQUE)
ENGINE=InnoDB ROW_FORMAT=COMPRESSED KEY_BLOCK_SIZE=4;
SET @level= @@GLOBAL.innodb_compression_level;
SET GLOBAL innodb_compression_level=0;
--connect (prevent_purge,localhost,root)
START TRANSACTION WITH CONSISTENT SNAPSHOT;
--connection default
INSERT INTO t1 VALUES('a',1,0);
UPDATE t1 SET c= REPEAT('a b ',4096);
REPLACE INTO t1 SELECT * FROM t1;
--disconnect prevent_purge
--source ../../innodb/include/wait_all_purged.inc
DROP TABLE t1;
SET GLOBAL innodb_compression_level = @level;
SET GLOBAL innodb_purge_rseg_truncate_frequency = @saved_frequency;

6
storage/innobase/btr/btr0cur.cc
View File

@@ -8110,9 +8110,9 @@ btr_free_externally_stored_field(
mtr.write<4>(*block, mtr.write<4>(*block,
BTR_EXTERN_PAGE_NO + field_ref, BTR_EXTERN_PAGE_NO + field_ref,
next_page_no); next_page_no);
mtr.write<4>(*block, mtr.write<4,mtr_t::OPT>(*block,
BTR_EXTERN_LEN + 4 + field_ref, BTR_EXTERN_LEN + 4
0U); + field_ref, 0U);
} }
} else { } else {
ut_ad(!block->page.zip.data); ut_ad(!block->page.zip.data);