database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-22660 SIGSEGV on adding system versioning and modifying system column

Browse Source 
Second alter subcommand correctly removed VERS_ROW_END flag. We throw
ER_VERS_PERIOD_COLUMNS in such case.
This commit is contained in:
Aleksey Midenkov
2021-10-11 13:36:07 +03:00
parent 911c803db1
commit d31f953789
3 changed files with 47 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
mysql-test/suite/versioning/r/alter.result
View File

@ -759,3 +759,22 @@ delete from t1;
set system_versioning_alter_history= keep; set system_versioning_alter_history= keep;
alter ignore table t1 drop pk; alter ignore table t1 drop pk;
drop table t1; drop table t1;
#
# MDEV-22660 SIGSEGV on adding system versioning and modifying system column
#
create or replace table t1 (a int);
alter table t1
add row_start timestamp(6) as row start,
add row_end timestamp(6) as row end,
add period for system_time(row_start, row_end),
with system versioning,
modify row_end varchar(8);
ERROR HY000: PERIOD FOR SYSTEM_TIME must use columns `row_start` and `row_end`
alter table t1
add row_start timestamp(6) as row start,
add row_end timestamp(6) as row end,
add period for system_time(row_start, row_end),
with system versioning,
modify row_start varchar(8);
ERROR HY000: PERIOD FOR SYSTEM_TIME must use columns `row_start` and `row_end`
drop table t1;

22
mysql-test/suite/versioning/t/alter.test
View File

@ -652,3 +652,25 @@ set system_versioning_alter_history= keep;
alter ignore table t1 drop pk; alter ignore table t1 drop pk;
# cleanup # cleanup
drop table t1; drop table t1;
--echo #
--echo # MDEV-22660 SIGSEGV on adding system versioning and modifying system column
--echo #
create or replace table t1 (a int);
--error ER_VERS_PERIOD_COLUMNS
alter table t1
add row_start timestamp(6) as row start,
add row_end timestamp(6) as row end,
add period for system_time(row_start, row_end),
with system versioning,
modify row_end varchar(8);
--error ER_VERS_PERIOD_COLUMNS
alter table t1
add row_start timestamp(6) as row start,
add row_end timestamp(6) as row end,
add period for system_time(row_start, row_end),
with system versioning,
modify row_start varchar(8);
# cleanup
drop table t1;

6
sql/handler.cc
View File

@ -7564,6 +7564,12 @@ bool Vers_parse_info::check_sys_fields(const Lex_table_name &table_name,
row_end= f; row_end= f;
} }
if (!row_start || !row_end)
{
my_error(ER_VERS_PERIOD_COLUMNS, MYF(0), as_row.start.str, as_row.end.str);
return true;
}
if (!can_native || if (!can_native ||
!row_start->is_some_bigint() || !row_start->is_some_bigint() ||
!row_end->is_some_bigint()) !row_end->is_some_bigint())