database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-21921 Make transaction_isolation and transaction_read_only into system variables

Browse Source 
In MariaDB, we have a confusing problem where:
* The transaction_isolation option can be set in a configuration file, but it cannot be set dynamically.
* The tx_isolation system variable can be set dynamically, but it cannot be set in a configuration file.

Therefore, we have two different names for the same thing in different contexts. This is needlessly confusing, and it complicates the documentation. The same thing applys for transaction_read_only.

MySQL 5.7 solved this problem by making them into system variables. https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-20.html

This commit takes a similar approach by adding new system variables and marking the original ones as deprecated. This commit also resolves some legacy problems related to SET STATEMENT and transaction_isolation.
This commit is contained in:
Junqi Xie
2023-03-12 13:55:30 +08:00
committed by Daniel Black
parent 4472a7b4ff
commit d20a96f9c1
100 changed files with 1232 additions and 962 deletions
Download Patch File Download Diff File Expand all files Collapse all files

141
mysql-test/suite/sys_vars/r/transaction_isolation_basic.result Normal file
View File

@@ -0,0 +1,141 @@
SET @global_start_value = @@global.transaction_isolation;
SELECT @global_start_value;
@global_start_value
REPEATABLE-READ
SET @session_start_value = @@session.transaction_isolation;
SELECT @session_start_value;
@session_start_value
REPEATABLE-READ
'#--------------------FN_DYNVARS_183_01------------------------#'
SET @@global.transaction_isolation = 'READ-UNCOMMITTED';
SET @@global.transaction_isolation = DEFAULT;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
REPEATABLE-READ
SET @@session.transaction_isolation = DEFAULT;
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
REPEATABLE-READ
'#---------------------FN_DYNVARS_183_02-------------------------#'
SET @@global.transaction_isolation = NULL;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'NULL'
SET @@global.transaction_isolation = '';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of ''
SET @@session.transaction_isolation = NULL;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'NULL'
SET @@session.transaction_isolation = '';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of ''
'#--------------------FN_DYNVARS_183_03------------------------#'
SET @@global.transaction_isolation = 'READ-UNCOMMITTED';
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-UNCOMMITTED
SET @@global.transaction_isolation = 'read-COMMITTED';
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-COMMITTED
SET @@global.transaction_isolation = 'REPEATABLE-READ';
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
REPEATABLE-READ
SET @@global.transaction_isolation = 'SERIALIZable';
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
SERIALIZABLE
SET @@session.transaction_isolation = 'READ-UNCOMMITTED';
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
READ-UNCOMMITTED
SET @@session.transaction_isolation = 'READ-COMMITTED';
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
READ-COMMITTED
SET @@session.transaction_isolation = 'REPEATABLE-READ';
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
REPEATABLE-READ
SET @@session.transaction_isolation = 'serializable';
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
SERIALIZABLE
'#--------------------FN_DYNVARS_183_04-------------------------#'
SET @@global.transaction_isolation = -1;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of '-1'
SET @@global.transaction_isolation = READUNCOMMITTED;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'READUNCOMMITTED'
SET @@global.transaction_isolation = 'REPEATABLE';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'REPEATABLE'
SET @@global.transaction_isolation = OFF;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'OFF'
SET @@global.transaction_isolation = ON;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'ON'
SET @@global.transaction_isolation = 'NON-SERIALIZABLE';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'NON-SERIALIZABLE'
SET @@transaction_isolation = -1;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of '-1'
SET @@transaction_isolation = READUNCOMMITTED;
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'READUNCOMMITTED'
SET @@transaction_isolation = 'REPEATABLE';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'REPEATABLE'
SET @@transaction_isolation = 'NONE';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'NONE'
SET @@transaction_isolation = 'ALL';
ERROR 42000: Variable 'transaction_isolation' can't be set to the value of 'ALL'
'#-------------------FN_DYNVARS_183_05----------------------------#'
SELECT @@session.transaction_isolation = VARIABLE_VALUE
FROM INFORMATION_SCHEMA.SESSION_VARIABLES
WHERE VARIABLE_NAME='transaction_isolation';
@@session.transaction_isolation = VARIABLE_VALUE
1
'#----------------------FN_DYNVARS_183_06------------------------#'
SELECT @@global.transaction_isolation = VARIABLE_VALUE
FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
WHERE VARIABLE_NAME='transaction_isolation';
@@global.transaction_isolation = VARIABLE_VALUE
1
'#---------------------FN_DYNVARS_183_07-------------------------#'
SET @@global.transaction_isolation = 0;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-UNCOMMITTED
SET @@global.transaction_isolation = 1;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-COMMITTED
SET @@global.transaction_isolation = 2;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
REPEATABLE-READ
SET @@global.transaction_isolation = 3;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
SERIALIZABLE
SET @@global.transaction_isolation = 0.4;
ERROR 42000: Incorrect argument type to variable 'transaction_isolation'
'#---------------------FN_DYNVARS_183_08----------------------#'
SET @@global.transaction_isolation = TRUE;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-COMMITTED
SET @@global.transaction_isolation = FALSE;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
READ-UNCOMMITTED
'#---------------------FN_DYNVARS_183_09----------------------#'
SET transaction_isolation = 'REPEATABLE-READ';
SET session transaction_isolation = 'REPEATABLE-READ';
SELECT @@transaction_isolation;
@@transaction_isolation
REPEATABLE-READ
SET global transaction_isolation = 'REPEATABLE-READ';
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
REPEATABLE-READ
SET @@global.transaction_isolation = @global_start_value;
SELECT @@global.transaction_isolation;
@@global.transaction_isolation
REPEATABLE-READ
SET @@session.transaction_isolation = @session_start_value;
SELECT @@session.transaction_isolation;
@@session.transaction_isolation
REPEATABLE-READ