database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-7001 Bad result for NOT NOT STRCMP('a','b') and NOT NOT NULLIF(2,3)

Browse Source 
The bug is not very important per se, but it was helpful to move
Item_func_strcmp out of Item_bool_func2 (to Item_int_func),
for the purposes of "MDEV-4912 Add a plugin to field types (column types)".
This commit is contained in:
Alexander Barkov
2014-11-02 01:08:09 +04:00
parent 4dec4e1175
commit d1ca1c1fae
7 changed files with 72 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sql/item_cmpfunc.h
View File

@@ -695,21 +695,18 @@ public:
};
class Item_func_strcmp :public Item_bool_func2
class Item_func_strcmp :public Item_int_func
{
String value1, value2;
DTCollation cmp_collation;
public:
Item_func_strcmp(Item *a,Item *b) :Item_bool_func2(a,b) {}
Item_func_strcmp(Item *a,Item *b) :Item_int_func(a,b) {}
longlong val_int();
optimize_type select_optimize() const { return OPTIMIZE_NONE; }
uint decimal_precision() const { return 1; }
const char *func_name() const { return "strcmp"; }
virtual inline void print(String *str, enum_query_type query_type)
{
Item_func::print(str, query_type);
}
void fix_length_and_dec()
{
Item_bool_func2::fix_length_and_dec();
agg_arg_charsets_for_comparison(cmp_collation, args, 2);
fix_char_length(2); // returns "1" or "0" or "-1"
}
};
@@ -803,6 +800,7 @@ public:
Item_func_nullif(Item *a,Item *b)
:Item_bool_func2(a,b), cached_result_type(INT_RESULT)
{}
bool is_bool_func() { return false; }
double val_real();
longlong val_int();
String *val_str(String *str);