database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Fix and test case for BUG#3649.

Browse Source 
mysql-test/r/handler.result:
  Test case for BUG#3649
mysql-test/t/handler.test:
  Test case for BUG#3649
sql/sql_handler.cc:
  Fix for BUG#3649: when doing an index scan for an equality condition, use index_next_same to retrieve subsequent rows.
This commit is contained in:
unknown
2004-05-18 22:59:43 +04:00
parent d4f6c7a4c7
commit cdf7471c2c
3 changed files with 63 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mysql-test/r/handler.result
View File

@ -191,3 +191,15 @@ Ok
handler t close; handler t close;
use test; use test;
drop table t1; drop table t1;
create table t1 ( a int, b int, INDEX a (a) );
insert into t1 values (1,2), (2,1);
handler t1 open;
handler t1 read a=(1) where b=2;
a b
1 2
handler t1 read a=(1) where b=3;
a b
handler t1 read a=(1) where b=1;
a b
handler t1 close;
drop table t1;

12
mysql-test/t/handler.test
View File

@ -123,3 +123,15 @@ handler t close;
use test; use test;
drop table t1; drop table t1;
#
# BUG#3649
#
create table t1 ( a int, b int, INDEX a (a) );
insert into t1 values (1,2), (2,1);
handler t1 open;
handler t1 read a=(1) where b=2;
handler t1 read a=(1) where b=3;
handler t1 read a=(1) where b=1;
handler t1 close;
drop table t1;

68
sql/sql_handler.cc
View File

@ -103,7 +103,7 @@ int mysql_ha_closeall(THD *thd, TABLE_LIST *tables)
} }
static enum enum_ha_read_modes rkey_to_rnext[]= static enum enum_ha_read_modes rkey_to_rnext[]=
{ RNEXT, RNEXT, RPREV, RNEXT, RPREV, RNEXT, RPREV }; { RKEY, RNEXT, RPREV, RNEXT, RPREV, RNEXT, RPREV };
int mysql_ha_read(THD *thd, TABLE_LIST *tables, int mysql_ha_read(THD *thd, TABLE_LIST *tables,
@ -151,6 +151,10 @@ int mysql_ha_read(THD *thd, TABLE_LIST *tables,
HANDLER_TABLES_HACK(thd); HANDLER_TABLES_HACK(thd);
MYSQL_LOCK *lock=mysql_lock_tables(thd,&tables->table,1); MYSQL_LOCK *lock=mysql_lock_tables(thd,&tables->table,1);
HANDLER_TABLES_HACK(thd); HANDLER_TABLES_HACK(thd);
byte *key= NULL;
uint key_len;
LINT_INIT(key_len); /* protected by key key variable */
if (!lock) if (!lock)
goto err0; // mysql_lock_tables() printed error message already goto err0; // mysql_lock_tables() printed error message already
@ -185,40 +189,46 @@ int mysql_ha_read(THD *thd, TABLE_LIST *tables,
break; break;
case RKEY: case RKEY:
{ {
DBUG_ASSERT(keyname != 0); if (key)
KEY *keyinfo=table->key_info+keyno;
KEY_PART_INFO *key_part=keyinfo->key_part;
uint key_len;
byte *key;
if (key_expr->elements > keyinfo->key_parts)
{ {
my_printf_error(ER_TOO_MANY_KEY_PARTS,ER(ER_TOO_MANY_KEY_PARTS), /* Continue scan on "(keypart1,keypart2,...)=(c1, c2, ...) */
MYF(0),keyinfo->key_parts); err= table->file->index_next_same(table->record[0], key, key_len);
goto err;
} }
List_iterator_fast<Item> it_ke(*key_expr); else
Item *item;
for (key_len=0 ; (item=it_ke++) ; key_part++)
{ {
if (item->fix_fields(thd, tables)) DBUG_ASSERT(keyname != 0);
goto err; KEY *keyinfo=table->key_info+keyno;
if (item->used_tables() & ~RAND_TABLE_BIT) KEY_PART_INFO *key_part=keyinfo->key_part;
if (key_expr->elements > keyinfo->key_parts)
{ {
my_error(ER_WRONG_ARGUMENTS,MYF(0),"HANDLER ... READ"); my_printf_error(ER_TOO_MANY_KEY_PARTS,ER(ER_TOO_MANY_KEY_PARTS),
goto err; MYF(0),keyinfo->key_parts);
goto err;
} }
item->save_in_field(key_part->field, 1); List_iterator_fast<Item> it_ke(*key_expr);
key_len+=key_part->store_length; Item *item;
for (key_len=0 ; (item=it_ke++) ; key_part++)
{
if (item->fix_fields(thd, tables))
goto err;
if (item->used_tables() & ~RAND_TABLE_BIT)
{
my_error(ER_WRONG_ARGUMENTS,MYF(0),"HANDLER ... READ");
goto err;
}
item->save_in_field(key_part->field, 1);
key_len+=key_part->store_length;
}
if (!(key= (byte*) thd->calloc(ALIGN_SIZE(key_len))))
{
send_error(&thd->net,ER_OUTOFMEMORY);
goto err;
}
key_copy(key, table, keyno, key_len);
err=table->file->index_read(table->record[0],
key,key_len,ha_rkey_mode);
mode=rkey_to_rnext[(int)ha_rkey_mode];
} }
if (!(key= (byte*) thd->calloc(ALIGN_SIZE(key_len))))
{
send_error(&thd->net,ER_OUTOFMEMORY);
goto err;
}
key_copy(key, table, keyno, key_len);
err=table->file->index_read(table->record[0],
key,key_len,ha_rkey_mode);
mode=rkey_to_rnext[(int)ha_rkey_mode];
break; break;
} }
default: default: