database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-15149 Assert upon concurrent creating / querying sequences

Browse Source 
Problem was that sequence_insert closed and reopened the like table
without proper locking.  Fixed by ensuring that the like table is
not reopened in sequence_insert
This commit is contained in:
Monty
2018-03-29 12:25:17 +03:00
parent e2664ee836
commit cd93eeeb1d
4 changed files with 69 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sql/sql_sequence.cc
View File

@ -283,6 +283,7 @@ bool sequence_insert(THD *thd, LEX *lex, TABLE_LIST *table_list)
Reprepare_observer *save_reprepare_observer;
sequence_definition *seq= lex->create_info.seq_create_info;
bool temporary_table= table_list->table != 0;
TABLE_LIST *org_next_global= table_list->next_global;
DBUG_ENTER("sequence_insert");
/* If not temporary table */
@ -290,6 +291,7 @@ bool sequence_insert(THD *thd, LEX *lex, TABLE_LIST *table_list)
{
/* Table was locked as part of create table. Free it but keep MDL locks */
close_thread_tables(thd);
table_list->next_global= 0; // Close LIKE TABLE
table_list->lock_type= TL_WRITE_DEFAULT;
table_list->updating= 1;
/*
@ -312,6 +314,7 @@ bool sequence_insert(THD *thd, LEX *lex, TABLE_LIST *table_list)
table_list->open_strategy= save_open_strategy;
thd->open_options&= ~HA_OPEN_FOR_CREATE;
thd->m_reprepare_observer= save_reprepare_observer;
table_list->next_global= org_next_global;
if (error)
DBUG_RETURN(TRUE); /* purify inspected */
}