database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

MDEV-15167 Server crashes in in bitmap_bits_set upon REPAIR PARTITION...

Browse Source 
after rebuilding under test_pseudo_invisible

If we are doing alter related to partitioning then simple alter stmt
like adding column(or any alter stmt) can't be combined with partition
alter, this will generate a syntax error.

But IF we add
SET debug_dbug="+d,test_pseudo_invisible";
or test_completely_invisible
this will add a column to table  with have an already partitioning related
alter. This execution of wrong stmt will crash the server on later stages.
(like on repair partition).

So we will simply return 1 (and ER_INTERNAL_ERROR) if we any of these
debug_dbug flags turned on.
This commit is contained in:
Sachin Setiya
2018-04-19 22:11:41 +05:30
parent d71a8855ee
commit cd8b8169b6
3 changed files with 52 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
mysql-test/main/invisible_partition.result Normal file
View File

@ -0,0 +1,18 @@
CREATE TABLE t1 (a INT NOT NULL, KEY (a)) ENGINE=MEMORY PARTITION BY KEY(a) PARTITIONS 4;
INSERT INTO t1 VALUES (1),(2);
SET debug_dbug="+d,test_pseudo_invisible";
ALTER TABLE t1 REBUILD PARTITION p2;
ERROR HY000: Internal error: Don't to it with test_pseudo_invisible
SET debug_dbug='';
ALTER TABLE t1 REPAIR PARTITION p1,p2,p3;
Table Op Msg_type Msg_text
test.t1 repair status OK
Drop table t1;
CREATE TABLE t1 (i INT) PARTITION BY HASH (i) PARTITIONS 3;
SET debug_dbug= "+d,test_pseudo_invisible";
ALTER TABLE t1 COALESCE PARTITION 1;
ERROR HY000: Internal error: Don't to it with test_pseudo_invisible
SET debug_dbug= "";
SELECT * FROM t1;
i
DROP TABLE t1;

23
mysql-test/main/invisible_partition.test Normal file
View File

@ -0,0 +1,23 @@
--source include/have_partition.inc
--source include/have_binlog_format_row.inc
CREATE TABLE t1 (a INT NOT NULL, KEY (a)) ENGINE=MEMORY PARTITION BY KEY(a) PARTITIONS 4;
INSERT INTO t1 VALUES (1),(2);
SET debug_dbug="+d,test_pseudo_invisible";
--error ER_INTERNAL_ERROR
ALTER TABLE t1 REBUILD PARTITION p2;
SET debug_dbug='';
ALTER TABLE t1 REPAIR PARTITION p1,p2,p3;
# Cleanup
Drop table t1;
#Mdev-14850
CREATE TABLE t1 (i INT) PARTITION BY HASH (i) PARTITIONS 3;
SET debug_dbug= "+d,test_pseudo_invisible";
--error ER_INTERNAL_ERROR
ALTER TABLE t1 COALESCE PARTITION 1;
SET debug_dbug= "";
SELECT * FROM t1;
# Cleanup
DROP TABLE t1;

11
sql/sql_partition.cc
View File

@ -4872,6 +4872,17 @@ uint prep_alter_part_table(THD *thd, TABLE *table, Alter_info *alter_info,
ALTER_PARTITION_TABLE_REORG |
ALTER_PARTITION_REBUILD))
{
/*
You can't add column when we are doing alter related to partition
*/
DBUG_EXECUTE_IF("test_pseudo_invisible", {
my_error(ER_INTERNAL_ERROR, MYF(0), "Don't to it with test_pseudo_invisible");
DBUG_RETURN(1);
});
DBUG_EXECUTE_IF("test_completely_invisible", {
my_error(ER_INTERNAL_ERROR, MYF(0), "Don't to it with test_completely_invisible");
DBUG_RETURN(1);
});
partition_info *tab_part_info;
ulonglong flags= 0;
bool is_last_partition_reorged= FALSE;