database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

ER_VARIABLE_DELETED fix typos, adjust wording, fix plugins.

Browse Source 
plugins can have unused variables too. If they use a literal "Unused"
string a compiler might or might not merge two identical strings into
one (-fmerge-constants) and depending on that the server will or will
not issue a "variable is ignored" warning.
This commit is contained in:
Sergei Golubchik
2024-03-14 20:46:41 +01:00
parent ae9a4799d7
commit cc758332ba
8 changed files with 39 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sql/set_var.cc
View File

@@ -430,8 +430,9 @@ void sys_var::do_deprecated_warning(THD *thd)
char buf1[NAME_CHAR_LEN + 3];
strxnmov(buf1, sizeof(buf1)-1, "@@", name.str, 0);
if (option.comment == UNUSED_HELP)
my_error(ER_VARIABLE_DELETED, MYF(ME_WARNING), buf1);
if (option.comment == UNUSED_HELP ||
strcmp(option.comment, UNUSED_HELP) == 0)
my_error(ER_VARIABLE_IGNORED, MYF(ME_WARNING), buf1);
else
{
char buf2[NAME_CHAR_LEN + 3];