database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Fix false Valgrind warning.

Browse Source 
On some compiler/platform combination, an assignment of form *p= *p
would map to a memcpy() call, and Valgrind flags this as an overlapped
memcpy() error.

Fix by prefixing *p= *q with if(p!=q) when building for Valgrind
(HAVE_purify).
This commit is contained in:
knielsen@ymer.(none)
2007-02-05 10:50:08 +01:00
parent 771c979514
commit cb9e8bcad8
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sql/sql_select.cc
View File

@ -3520,7 +3520,11 @@ update_ref_and_keys(THD *thd, DYNAMIC_ARRAY *keyuse,JOIN_TAB *join_tab,
continue; continue;
} }
*save_pos= *use; #ifdef HAVE_purify
/* Valgrind complains about overlapped memcpy when save_pos==use. */
if (save_pos != use)
#endif
*save_pos= *use;
prev=use; prev=use;
found_eq_constant= !use->used_tables; found_eq_constant= !use->used_tables;
/* Save ptr to first use */ /* Save ptr to first use */