database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Fix bug lp:1008487

Browse Source 
Analysis:
The crash is a result of Item_cache_temporal::example not being set
(it is NULL). It turns out that the value of Item_cache_temporal
may be set directly by calling Item_cache_temporal::store_packed
without ever setting the "example" of this Item_cache. Therefore
the failing assertion is too narrow.

Solution:
Remove the assert.
In principle we could overwrite this method for Item_cache_temporal,
but it doesn't make sense just for this assert.
This commit is contained in:
unknown
2012-06-04 18:06:00 +03:00
parent afedd72e22
commit ca5473f1db
3 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mysql-test/r/type_date.result
View File

@ -339,3 +339,17 @@ select @a;
@a @a
0111-01-01 0111-01-01
# #
#
# BUG LP:1008487 virtual bool Item_cache::is_expensive(): Assertion `example' failed
#
create table t1(a date,key(a));
insert into t1 values ('2012-01-01'),('2012-02-02');
explain
select 1 from t1 as t1_0 inner join t1 as t2 on (t1_0.a <=> now()) join t1 on 1;
id select_type table type possible_keys key key_len ref rows Extra
1 SIMPLE t1_0 ref a a 4 const 0 Using where; Using index
1 SIMPLE t2 index NULL a 4 NULL 2 Using index; Using join buffer (flat, BNL join)
1 SIMPLE t1 index NULL a 4 NULL 2 Using index; Using join buffer (incremental, BNL join)
select 1 from t1 as t1_0 inner join t1 as t2 on (t1_0.a <=> now()) join t1 on 1;
1
drop table t1;

10
mysql-test/t/type_date.test
View File

@ -317,3 +317,13 @@ set @a=(select min(makedate('111','1'))) ;
select @a; select @a;
--echo # --echo #
--echo #
--echo # BUG LP:1008487 virtual bool Item_cache::is_expensive(): Assertion `example' failed
--echo #
create table t1(a date,key(a));
insert into t1 values ('2012-01-01'),('2012-02-02');
explain
select 1 from t1 as t1_0 inner join t1 as t2 on (t1_0.a <=> now()) join t1 on 1;
select 1 from t1 as t1_0 inner join t1 as t2 on (t1_0.a <=> now()) join t1 on 1;
drop table t1;

1
sql/item.h
View File

@ -3889,7 +3889,6 @@ public:
bool is_null() { return null_value; } bool is_null() { return null_value; }
virtual bool is_expensive() virtual bool is_expensive()
{ {
DBUG_ASSERT(example);
if (value_cached) if (value_cached)
return false; return false;
return example->is_expensive(); return example->is_expensive();