From ca503e830b68941113c75f781bee365a35d268d3 Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Thu, 9 Feb 2017 12:04:09 +0100 Subject: [PATCH] mtr: make sphinx skipping a bit less verbose --- storage/sphinx/mysql-test/sphinx/suite.pm | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/storage/sphinx/mysql-test/sphinx/suite.pm b/storage/sphinx/mysql-test/sphinx/suite.pm index 9b17a5f78b8..24c377d7665 100644 --- a/storage/sphinx/mysql-test/sphinx/suite.pm +++ b/storage/sphinx/mysql-test/sphinx/suite.pm @@ -18,24 +18,14 @@ sub locate_sphinx_binary { # Look for Sphinx binaries my $exe_sphinx_indexer = &locate_sphinx_binary('indexer'); +return "'indexer' binary not found" unless $exe_sphinx_indexer; -unless ($exe_sphinx_indexer) { - mtr_report("Sphinx 'indexer' binary not found, sphinx suite will be skipped"); - return "No Sphinx"; -} my $exe_sphinx_searchd = &locate_sphinx_binary('searchd'); - -unless ($exe_sphinx_searchd) { - mtr_report("Sphinx 'searchd' binary not found, sphinx suite will be skipped"); - return "No Sphinx"; -} +return "'searchd' binary not found" unless $exe_sphinx_searchd; # Check for Sphinx engine -unless ($ENV{HA_SPHINX_SO} or $::mysqld_variables{'sphinx'} eq "ON") { - mtr_report("Sphinx engine not found, sphinx suite will be skipped"); - return "No SphinxSE"; -} +return "SphinxSE not found" unless $ENV{HA_SPHINX_SO} or $::mysqld_variables{'sphinx'} eq "ON"; { local $_ = `"$exe_sphinx_searchd" --help`;