1
0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00

Ensure that one can drop a trigger with an orphan .TRN file

Before this fix, one would get a 'Trigger ... already exists' when trying
to create a trigger matching the original name and 'Trigger ... does not
exists" when trying to drop it.

Fixes a reported bug in MDEV-25180 Atomic ALTER TABLE

MDEV-25517 Atomic DDL: Assertion `query_arg' in THD::binlog_query
upon DROP TRIGGER

The bug was that the stmt_query variable was not populated
with the query in case of DROP TRIGGER of an orphan trigger
(.TRN file exists & table exists, but the trigger was not in
table->triggers).
This commit is contained in:
Monty
2021-03-21 17:47:56 +02:00
committed by Sergei Golubchik
parent ffe7f19fa6
commit c844a76b0a
6 changed files with 195 additions and 16 deletions

View File

@@ -21,3 +21,31 @@ DROP TABLE t1;
--let $binlog_file = LAST
source include/show_binlog_events.inc;
--echo #
--echo # MDEV-25517 Atomic DDL: Assertion `query_arg' in THD::binlog_query
--echo # upon DROP TRIGGER
--echo #
# This test case is 'random' by design. For most cases the second DROP TRIGGER
# will generate a warning "Dropped orphan trigger...", but if there is a timing
# issue, we may get another error or warning later. This is ok as it enables
# us to have more code paths tested over time.
CREATE TABLE t1 (a INT);
CREATE TRIGGER trg AFTER INSERT ON t1 FOR EACH ROW SET @x = 1;
--disable_warnings
--connect (con1,localhost,root,,test)
--send
DROP TRIGGER trg;
--connection default
--error 0,ER_TRG_DOES_NOT_EXIST
DROP TRIGGER trg;
# Cleanup
--connection con1
--error 0,ER_TRG_DOES_NOT_EXIST
--reap
--disconnect con1
--connection default
--enable_warnings
DROP TABLE t1;