mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
Cleanups during review
BitKeeper/etc/ignore: added libmysqld/examples/mysqltest_embedded client/mysqlbinlog.cc: Call mysql_close() before die() innobase/include/eval0eval.ic: Remove assert that fails on 64 bit machines (Tested with BUILD/compile-pentium64-valgrind-max on 64 bit Intel CPU) sql/mysqld.cc: Force lower_case_table_names to 0 if set to 2 on case insensitive file name sql/sql_select.cc: Remove #if 0
This commit is contained in:
@@ -687,7 +687,7 @@ static int parse_args(int *argc, char*** argv)
|
||||
|
||||
static MYSQL* safe_connect()
|
||||
{
|
||||
MYSQL *local_mysql = mysql_init(NULL);
|
||||
MYSQL *local_mysql= mysql_init(NULL);
|
||||
|
||||
if (!local_mysql)
|
||||
die("Failed on mysql_init");
|
||||
@@ -695,8 +695,12 @@ static MYSQL* safe_connect()
|
||||
if (opt_protocol)
|
||||
mysql_options(local_mysql, MYSQL_OPT_PROTOCOL, (char*) &opt_protocol);
|
||||
if (!mysql_real_connect(local_mysql, host, user, pass, 0, port, sock, 0))
|
||||
die("failed on connect: %s", mysql_error(local_mysql));
|
||||
|
||||
{
|
||||
char errmsg[256];
|
||||
strmake(errmsg, mysql_error(local_mysql), sizeof(errmsg)-1);
|
||||
mysql_close(local_mysql);
|
||||
die("failed on connect: %s", errmsg);
|
||||
}
|
||||
return local_mysql;
|
||||
}
|
||||
|
||||
@@ -717,7 +721,12 @@ static int check_master_version(MYSQL* mysql)
|
||||
|
||||
if (mysql_query(mysql, "SELECT VERSION()") ||
|
||||
!(res = mysql_store_result(mysql)))
|
||||
die("Error checking master version: %s", mysql_error(mysql));
|
||||
{
|
||||
char errmsg[256];
|
||||
strmake(errmsg, mysql_error(mysql), sizeof(errmsg)-1);
|
||||
mysql_close(mysql);
|
||||
die("Error checking master version: %s", errmsg);
|
||||
}
|
||||
if (!(row = mysql_fetch_row(res)))
|
||||
{
|
||||
mysql_free_result(res);
|
||||
|
Reference in New Issue
Block a user