diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl index 6cd878fce70..5b743e22519 100755 --- a/mysql-test/mysql-test-run.pl +++ b/mysql-test/mysql-test-run.pl @@ -1208,6 +1208,7 @@ sub kill_running_server () { mkpath("$opt_vardir/log"); # Needed for mysqladmin log mtr_kill_leftovers(); + $using_ndbcluster_master= $opt_with_ndbcluster; ndbcluster_stop(); $master->[0]->{'ndbcluster'}= 1; ndbcluster_stop_slave(); @@ -1447,6 +1448,7 @@ sub ndbcluster_start ($) { } if ( $using_ndbcluster_master ) { + # Master already started return 0; } # FIXME, we want to _append_ output to file $file_ndb_testrun_log instead of /dev/null @@ -1956,7 +1958,8 @@ sub run_testcase ($) { { if ( $tinfo->{'master_restart'} or $master->[0]->{'running_master_is_special'} or - ( $tinfo->{'ndb_test'} != $using_ndbcluster_master ) ) + # Stop if cluster is started but test cases does not need cluster + ( $tinfo->{'ndb_test'} != $using_ndbcluster_master ) ) { stop_masters(); $master->[0]->{'running_master_is_special'}= 0; # Forget why we stopped @@ -2011,12 +2014,16 @@ sub run_testcase ($) { { if ( $master->[0]->{'ndbcluster'} ) { + # Cluster is not started + + # Call ndbcluster_start to check if test case needs cluster + # Start it if not already started $master->[0]->{'ndbcluster'}= ndbcluster_start($tinfo->{'ndb_test'}); - if ( $master->[0]->{'ndbcluster'} ) - { - report_failure_and_restart($tinfo); - return; - } + if ( $master->[0]->{'ndbcluster'} ) + { + report_failure_and_restart($tinfo); + return; + } } if ( ! $master->[0]->{'pid'} ) { @@ -2033,6 +2040,7 @@ sub run_testcase ($) { } if ( $using_ndbcluster_master and ! $master->[1]->{'pid'} ) { + # Test needs cluster, start an extra mysqld connected to cluster mtr_tofile($master->[1]->{'path_myerr'},"CURRENT_TEST: $tname\n"); $master->[1]->{'pid'}= mysqld_start('master',1,$tinfo->{'master_opt'},[], @@ -2355,15 +2363,15 @@ sub mysqld_arguments ($$$$$$) { mtr_add_arg($args, "%s--skip-innodb", $prefix); } - if ( $opt_skip_ndbcluster ) + if ( $opt_skip_ndbcluster || !$using_ndbcluster) { mtr_add_arg($args, "%s--skip-ndbcluster", $prefix); } - if ( $using_ndbcluster ) + else { mtr_add_arg($args, "%s--ndbcluster", $prefix); mtr_add_arg($args, "%s--ndb-connectstring=%s", $prefix, - $opt_ndbconnectstring); + $opt_ndbconnectstring); mtr_add_arg($args, "%s--ndb-extra-logging", $prefix); } } @@ -2549,6 +2557,7 @@ sub mysqld_start ($$$$$) { my $slave_master_info= shift; my $using_ndbcluster= shift; + my $args; # Arg vector my $exe; my $pid;