database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-02 14:22:51 +03:00
Code Activity

Don't report errors from open_table() twice

Browse Source
This commit is contained in:
Michael Widenius
2018-05-11 17:33:40 +03:00
parent d853042b5f
commit be6ae0bb6b
5 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mysql-test/main/delayed.result
View File

@ -500,7 +500,6 @@ call mtr.add_suppression("Checking table");
insert delayed into t1 values (2,2); insert delayed into t1 values (2,2);
Warnings: Warnings:
Error 145 Table './test/t1' is marked as crashed and should be repaired Error 145 Table './test/t1' is marked as crashed and should be repaired
Error 1194 Table 't1' is marked as crashed and should be repaired
Error 1034 1 client is using or hasn't closed the table properly Error 1034 1 client is using or hasn't closed the table properly
insert delayed into t1 values (3,3); insert delayed into t1 values (3,3);
flush tables t1; flush tables t1;

2
mysql-test/main/myisam_recover.result
View File

@ -87,7 +87,6 @@ a
6 6
Warnings: Warnings:
Error 145 Table 't1' is marked as crashed and should be repaired Error 145 Table 't1' is marked as crashed and should be repaired
Error 1194 Table 't1' is marked as crashed and should be repaired
Error 1034 Number of rows changed from 3 to 6 Error 1034 Number of rows changed from 3 to 6
# #
# Cleanup # Cleanup
@ -140,7 +139,6 @@ a
4 4
Warnings: Warnings:
Error 145 Table 't1' is marked as crashed and should be repaired Error 145 Table 't1' is marked as crashed and should be repaired
Error 1194 Table 't1' is marked as crashed and should be repaired
Error 1034 Number of rows changed from 1 to 2 Error 1034 Number of rows changed from 1 to 2
connect con2, localhost, root; connect con2, localhost, root;
ALTER TABLE t2 ADD val INT; ALTER TABLE t2 ADD val INT;

1
mysql-test/suite/maria/maria-recover.result
View File

@ -27,7 +27,6 @@ ThursdayMorningsMarket
ThursdayMorningsMarketb ThursdayMorningsMarketb
Warnings: Warnings:
Error 145 t_corrupted2' is marked as crashed and should be repaired Error 145 t_corrupted2' is marked as crashed and should be repaired
Error 1194 t_corrupted2' is marked as crashed and should be repaired
Error 1034 1 client is using or hasn't closed the table properly Error 1034 1 client is using or hasn't closed the table properly
Error 1034 Wrong base information on indexpage at page: 1 Error 1034 Wrong base information on indexpage at page: 1
select * from t_corrupted2; select * from t_corrupted2;

2
mysql-test/suite/parts/r/partition_recover_myisam.result
View File

@ -18,7 +18,6 @@ a
11 11
Warnings: Warnings:
Error 145 Table 't1_will_crash' is marked as crashed and should be repaired Error 145 Table 't1_will_crash' is marked as crashed and should be repaired
Error 1194 Table 't1_will_crash' is marked as crashed and should be repaired
Error 1034 1 client is using or hasn't closed the table properly Error 1034 1 client is using or hasn't closed the table properly
Error 1034 Size of indexfile is: 1024 Should be: 2048 Error 1034 Size of indexfile is: 1024 Should be: 2048
Error 1034 Size of datafile is: 77 Should be: 7 Error 1034 Size of datafile is: 77 Should be: 7
@ -48,7 +47,6 @@ a
11 11
Warnings: Warnings:
Error 145 Table 't1_will_crash#P#p1' is marked as crashed and should be repaired Error 145 Table 't1_will_crash#P#p1' is marked as crashed and should be repaired
Error 1194 Table 't1_will_crash' is marked as crashed and should be repaired
Error 1034 1 client is using or hasn't closed the table properly Error 1034 1 client is using or hasn't closed the table properly
Error 1034 Size of indexfile is: 1024 Should be: 2048 Error 1034 Size of indexfile is: 1024 Should be: 2048
Error 1034 Size of datafile is: 28 Should be: 7 Error 1034 Size of datafile is: 28 Should be: 7

1
sql/table.cc
View File

@ -3468,6 +3468,7 @@ partititon_err:
/* Set a flag if the table is crashed and it can be auto. repaired */ /* Set a flag if the table is crashed and it can be auto. repaired */
share->crashed= (outparam->file->auto_repair(ha_err) && share->crashed= (outparam->file->auto_repair(ha_err) &&
!(ha_open_flags & HA_OPEN_FOR_REPAIR)); !(ha_open_flags & HA_OPEN_FOR_REPAIR));
if (!thd->is_error())
outparam->file->print_error(ha_err, MYF(0)); outparam->file->print_error(ha_err, MYF(0));
error_reported= TRUE; error_reported= TRUE;