mirror of
https://github.com/MariaDB/server.git
synced 2025-12-24 11:21:21 +03:00
Bug#36788 Multiple funcs_1 'trig' tests are failing on vanilla builds
Fix for this bug and additional improvements/fixes
In detail:
- Remove unicode attribute from several columns
(unicode properties were nowhere needed/tested)
of the table tb3
-> The runnability of these tests depends no more on
the availibility of some optional collations.
- Use a table tb3 with the same layout for all
engines to be tested and unify the engine name
within the protocols.
-> <engine>_trig_<abc>.result have the same content
- Do not load data into tb3 if these rows have no
impact on result sets
- Add tests for NDB (they exist already in 5.1)
- "--replace_result" at various places because
NDB variants of tests failed with "random" row
order in results
This fixes a till now unknown weakness within the
funcs_1 NDB tests existing in 5.1 and 6.0
- Fix the expected result of ndb_trig_1011ext
which suffered from Bug 32656
+ disable this test
- funcs_1 could be executed with the mysql-test-run.pl
option "--reorder", which saves some runtime by
optimizing server restarts.
Runtimes on tmpfs (one attempt only):
with reorder 132 seconds
without reorder 183 seconds
- Adjust two "check" statements within func_misc.test
which were incorrect (We had one run with result set
difference though the server worked good.)
- minor fixes in comments
This commit is contained in:
@@ -1,9 +1,13 @@
|
||||
#### suite/funcs_1/triggers/triggers_03.inc
|
||||
#======================================================================
|
||||
#
|
||||
# Trigger Tests
|
||||
# (test case numbering refer to requirement document TP v1.1)
|
||||
#======================================================================
|
||||
|
||||
USE test;
|
||||
--source suite/funcs_1/include/tb3.inc
|
||||
|
||||
--disable_abort_on_error
|
||||
|
||||
###########################################
|
||||
@@ -20,6 +24,7 @@ let $message= Testcase 3.5.3:;
|
||||
--enable_warnings
|
||||
create database priv_db;
|
||||
use priv_db;
|
||||
--replace_result $engine_type <engine_to_be_used>
|
||||
eval create table t1 (f1 char(20)) engine= $engine_type;
|
||||
|
||||
create User test_noprivs@localhost;
|
||||
@@ -569,7 +574,9 @@ let $message=Testcase: 3.5.3.x:;
|
||||
drop table if exists t2;
|
||||
--enable_warnings
|
||||
|
||||
--replace_result $engine_type <engine_to_be_used>
|
||||
eval create table t1 (f1 int) engine= $engine_type;
|
||||
--replace_result $engine_type <engine_to_be_used>
|
||||
eval create table t2 (f2 int) engine= $engine_type;
|
||||
|
||||
revoke ALL PRIVILEGES, GRANT OPTION FROM test_yesprivs@localhost;
|
||||
@@ -656,3 +663,5 @@ let $message=Testcase: 3.5.3.x:;
|
||||
drop user test_noprivs;
|
||||
--enable_warnings
|
||||
|
||||
use test;
|
||||
drop table tb3;
|
||||
|
||||
Reference in New Issue
Block a user