From cbaa5aaf47736f582faf8a9ed32eae285608c9fa Mon Sep 17 00:00:00 2001
From: Peter Lieverdink <me@cafuego.net>
Date: Thu, 1 Oct 2009 09:40:51 +1000
Subject: [PATCH 1/2] Typo fixes for "usefull" -> "useful".

---
 Docs/myisam.txt                 | 2 +-
 configure.in                    | 2 +-
 mysql-test/mysql-stress-test.pl | 4 ++--
 mysys/safemalloc.c              | 2 +-
 sql/mysqld.cc                   | 2 +-
 sql/sql_select.cc               | 2 +-
 sql/udf_example.c               | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Docs/myisam.txt b/Docs/myisam.txt
index e0b56e79548..ceb4ae7dc0b 100644
--- a/Docs/myisam.txt
+++ b/Docs/myisam.txt
@@ -868,7 +868,7 @@ Space compression makes the index file smaller if the string column has a lot of
 Prefix compression helps if there are many strings with an identical prefix.
 
 In memory table characteristics 
-HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are usefull as anyway. 
+HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are useful as anyway. 
 
 The *MySQL* internal HEAP tables uses 100% dynamic hashing without overflow areas and don't have problems with delete. 
 
diff --git a/configure.in b/configure.in
index 8c13896e431..2bf0e9d065b 100644
--- a/configure.in
+++ b/configure.in
@@ -2845,7 +2845,7 @@ do
 done
 AC_SUBST(sql_union_dirs)
 
-# Some usefull subst
+# Some useful subst
 AC_SUBST(CC)
 AC_SUBST(GXX)
 
diff --git a/mysql-test/mysql-stress-test.pl b/mysql-test/mysql-stress-test.pl
index 3061506da51..ff2566b1476 100755
--- a/mysql-test/mysql-stress-test.pl
+++ b/mysql-test/mysql-stress-test.pl
@@ -1100,7 +1100,7 @@ mysql-stress-test.pl --stress-basedir=<dir> --stress-suite-basedir=<dir> --serve
       they specified in the list file. 
       
 --sleep-time=<time in seconds>
-  Delay between test execution. Could be usefull in continued testsing 
+  Delay between test execution. Could be useful in continued testsing 
   when one of instance of stress script perform periodical cleanup or
   recreating of some database objects
 
@@ -1109,7 +1109,7 @@ mysql-stress-test.pl --stress-basedir=<dir> --stress-suite-basedir=<dir> --serve
 
 --check-tests-file
   Check file with list of tests. If file was modified it will force to
-  reread list of tests. Could be usefull in continued testing for
+  reread list of tests. Could be useful in continued testing for
   adding/removing tests without script interruption 
 
 --mysqltest=/path/to/mysqltest binary
diff --git a/mysys/safemalloc.c b/mysys/safemalloc.c
index a69051e6674..9b91f15c4aa 100644
--- a/mysys/safemalloc.c
+++ b/mysys/safemalloc.c
@@ -436,7 +436,7 @@ void TERMINATE(FILE *file, uint flag)
 /*
   Report where a piece of memory was allocated
 
-  This is usefull to call from withing a debugger
+  This is useful to call from withing a debugger
 */
 
 void sf_malloc_report_allocated(void *memory)
diff --git a/sql/mysqld.cc b/sql/mysqld.cc
index dc3cf8d158a..60fbbbc5013 100644
--- a/sql/mysqld.cc
+++ b/sql/mysqld.cc
@@ -6631,7 +6631,7 @@ log and this option does nothing anymore.",
    0, 0, 0, 0, 0},
 
   {"test-ignore-wrong-options", OPT_TEST_IGNORE_WRONG_OPTIONS,
-   "Ignore wrong enums values in command line arguments. Usefull only for test scripts",
+   "Ignore wrong enums values in command line arguments. Useful only for test scripts",
    (uchar**) &opt_ignore_wrong_options, (uchar**) &opt_ignore_wrong_options,
    0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"timed_mutexes", OPT_TIMED_MUTEXES,
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index 014b63c057c..27c08847d1f 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_select.cc
@@ -11812,7 +11812,7 @@ join_read_const_table(JOIN_TAB *tab, POSITION *pos)
   {
 #if !defined(DBUG_OFF) && defined(NOT_USING_ITEM_EQUAL)
     /*
-      This test could be very usefull to find bugs in the optimizer
+      This test could be very useful to find bugs in the optimizer
       where we would call this function with an expression that can't be
       evaluated yet. We can't have this enabled by default as long as
       have items like Item_equal, that doesn't report they are const but
diff --git a/sql/udf_example.c b/sql/udf_example.c
index 30d85d95034..0c7a140579b 100644
--- a/sql/udf_example.c
+++ b/sql/udf_example.c
@@ -205,7 +205,7 @@ char *is_const(UDF_INIT *initid, UDF_ARGS *args, char *result, unsigned long
 **		try to keep the error message less than 80 bytes long!
 **
 ** This function should return 1 if something goes wrong. In this case
-** message should contain something usefull!
+** message should contain something useful!
 **************************************************************************/
 
 #define MAXMETAPH 8

From 31ffbadb75e2408f18f4d5f4b8339e85ff0336c8 Mon Sep 17 00:00:00 2001
From: Peter Lieverdink <me@cafuego.net>
Date: Fri, 16 Oct 2009 17:15:30 +1100
Subject: [PATCH 2/2] Add `configtest' option to the init script to check for a
 valid my.cnf file.

---
 support-files/mysql.server.sh | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/support-files/mysql.server.sh b/support-files/mysql.server.sh
index 87198fc9cf5..fe885122e8c 100644
--- a/support-files/mysql.server.sh
+++ b/support-files/mysql.server.sh
@@ -434,9 +434,36 @@ case "$mode" in
       fi
     fi
     ;;
-    *)
+  'configtest')
+    # Safeguard (relative paths, core dumps..)
+    cd $basedir
+    echo $echo_n "Testing MySQL configuration syntax"
+    daemon=$bindir/mysqld
+    if test -x $libexecdir/mysqld
+    then
+      daemon=$libexecdir/mysqld
+    elif test -x $sbindir/mysqld
+    then
+      daemon=$sbindir/mysqld
+    elif test -x `which mysqld`
+    then
+      daemon=`which mysqld`
+    else
+      log_failure_msg "Unable to locate the mysqld binary!"
+      exit 1
+    fi
+    help_out=`$daemon --help 2>&1`; r=$?
+    if test "$r" != 0 ; then
+      log_failure_msg "$help_out"
+      log_failure_msg "There are syntax errors in the server configuration. Please fix them!"
+    else
+      log_success_msg "Syntax OK"
+    fi
+    exit $r
+    ;;
+  *)
       # usage
-      echo "Usage: $0  {start|stop|restart|reload|force-reload|status}  [ MySQL server options ]"
+      echo "Usage: $0  {start|stop|restart|reload|force-reload|status|configtest}  [ MySQL server options ]"
       exit 1
     ;;
 esac