database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-26345 SELECT MIN on Spider table returns more rows than expected

Browse Source 
The Spider storage engine ignored the implicit grouping when
aggregation was converted to constant by the query optimizer.
As a result, the Spider SE returned rows more than expected.

To fix the problem, we notify the Spider SE of the existence of
the implicit grouping via Query::distinct.
This commit is contained in:
Nayuta Yanagisawa
2021-08-22 19:52:10 +00:00
parent 5a6de6f40c
commit b9730226dc
5 changed files with 102 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
storage/spider/mysql-test/spider/bugfix/r/mdev_26345.result Normal file
View File

@@ -0,0 +1,42 @@
for master_1
for child2
child2_1
child2_2
child2_3
for child3
MDEV-26345 SELECT MIN on Spider table returns more rows than expected
connection child2_1;
CREATE DATABASE auto_test_remote;
USE auto_test_remote;
CREATE TABLE tbl_a (
`a`int,
`b`int,
PRIMARY KEY (`a`, `b`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
insert into `tbl_a` VALUES (1,1), (1,2), (2,11);
connection master_1;
CREATE DATABASE auto_test_remote;
USE auto_test_remote;
CREATE TABLE tbl_a (
`a`int,
`b`int,
PRIMARY KEY (`a`, `b`)
) ENGINE=Spider DEFAULT CHARSET=utf8 COMMENT='table "tbl_a"' PARTITION BY LIST COLUMNS(`b`) (
PARTITION `pt1` DEFAULT COMMENT = 'srv "s_2_1"'
);
connection master_1;
SELECT MIN(b), a FROM tbl_a WHERE a=1;
MIN(b) a
1 1
connection master_1;
DROP DATABASE IF EXISTS auto_test_remote;
connection child2_1;
DROP DATABASE IF EXISTS auto_test_remote;
for master_1
for child2
child2_1
child2_2
child2_3
for child3

3
storage/spider/mysql-test/spider/bugfix/t/mdev_26345.cnf Normal file
View File

@@ -0,0 +1,3 @@
!include include/default_mysqld.cnf
!include ../my_1_1.cnf
!include ../my_2_1.cnf

51
storage/spider/mysql-test/spider/bugfix/t/mdev_26345.test Normal file
View File

@@ -0,0 +1,51 @@
--disable_warnings
--disable_query_log
--disable_result_log
--source ../../t/test_init.inc
--enable_result_log
--enable_query_log
--enable_warnings
--echo
--echo MDEV-26345 SELECT MIN on Spider table returns more rows than expected
--echo
--connection child2_1
CREATE DATABASE auto_test_remote;
USE auto_test_remote;
eval CREATE TABLE tbl_a (
`a`int,
`b`int,
PRIMARY KEY (`a`, `b`)
) $CHILD2_1_ENGINE $CHILD2_1_CHARSET;
insert into `tbl_a` VALUES (1,1), (1,2), (2,11);
--connection master_1
CREATE DATABASE auto_test_remote;
USE auto_test_remote;
eval CREATE TABLE tbl_a (
`a`int,
`b`int,
PRIMARY KEY (`a`, `b`)
) $MASTER_1_ENGINE $MASTER_1_CHARSET COMMENT='table "tbl_a"' PARTITION BY LIST COLUMNS(`b`) (
PARTITION `pt1` DEFAULT COMMENT = 'srv "s_2_1"'
);
--connection master_1
SELECT MIN(b), a FROM tbl_a WHERE a=1;
--connection master_1
DROP DATABASE IF EXISTS auto_test_remote;
--connection child2_1
DROP DATABASE IF EXISTS auto_test_remote;
--disable_warnings
--disable_query_log
--disable_result_log
--source ../../t/test_deinit.inc
--enable_result_log
--enable_query_log
--enable_warnings

2
storage/spider/mysql-test/spider/r/direct_join.result
View File

@@ -167,7 +167,7 @@ connection child2_1;
SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %';
argument
select `id`,`hr_status`,`region_code`,`region` from `auto_test_remote`.`tbl_person` where `id` = '24FC3F0A5119432BAE13DD65AABAA39C' and `region` = 510411
select count(0) `count(0)` from `auto_test_remote`.`tbl_ncd_cm_person` t0 where ((t0.`person_id` = '24FC3F0A5119432BAE13DD65AABAA39C') and (t0.`diseaseKind_id` = '52A0328740914BCE86ED10A4D2521816'))
select distinct count(0) `count(0)` from `auto_test_remote`.`tbl_ncd_cm_person` t0 where ((t0.`person_id` = '24FC3F0A5119432BAE13DD65AABAA39C') and (t0.`diseaseKind_id` = '52A0328740914BCE86ED10A4D2521816'))
SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %'
SELECT * FROM tbl_person;
id hr_status region_code region