database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-31948 Add class DBNameBuffer, split check_db_name() into stages

Browse Source 
- Adding a class Lex_ident_fs, to store identifiers for on-disk
  database objects, such as databases, tables, triggers.

- Moving the validation code from check_db_name()
  to non-modifying methods in Lex_ident_fs:

    Lex_ident_fs::check_body()
    Lex_ident_fs::check_db_name()

  Adding a new method Lex_ident_fs::check_db_name_with_error(),
  which performs validation and raises an error on validation failure.

  Unlike the old function check_db_name(), the new class Lex_ident_fs
  does not lower-case the identifier during the validation.
  Lower-casing must be done before calling Lex_ident_fs validation methods.

- Adding a low level helper template class CharBuffer which can:
  * store exact or lower-cased strings with a short fixed maximum length
  * return the value as a LEX_CSTRING efficiently

- Adding a helper template class DBNameBuffer (deriving from CharBuffer), to
  allocate optionally lower-cased database identifiers on stack when relevant.
  Useful for temporary values which don't need to be allocated on MEM_ROOT.

- Using DBNameBuffer in mysql_change_db()

- Using DBNameBuffer in show_create_db()
This commit is contained in:
Alexander Barkov
2023-08-17 13:49:46 +04:00
parent 8528eaccb2
commit b956a6a259
8 changed files with 281 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
mysql-test/main/lowercase_table.test
View File

@ -142,3 +142,43 @@ delete from mysql.proc where name = '';
--echo #
--echo # End of 10.3 tests
--echo #
--echo #
--echo # Start of 11.3 tests
--echo #
--echo #
--echo # MDEV-31948 Add class DBNameBuffer, split check_db_name() into stages
--echo #
SET NAMES utf8;
# U+FFED HALFWIDTH BLACK SQUARE
SET @mb3char= _utf8 0xEFBFAD;
# Database names fitting into the NAME_CHAR_LEN characters limit
--error ER_BAD_DB_ERROR
EXECUTE IMMEDIATE CONCAT('use `', REPEAT(@mb3char, 64), '`');
--error ER_BAD_DB_ERROR
EXECUTE IMMEDIATE CONCAT('use `#mysql50#', REPEAT(@mb3char, 64), '`');
--error ER_BAD_DB_ERROR
EXECUTE IMMEDIATE CONCAT('SHOW CREATE DATABASE `', REPEAT(@mb3char, 64), '`');
--error ER_BAD_DB_ERROR
EXECUTE IMMEDIATE CONCAT('SHOW CREATE DATABASE `#mysql50#', REPEAT(@mb3char, 64), '`');
# Database names longer than NAME_CHAR_LEN characters
--error ER_WRONG_DB_NAME
EXECUTE IMMEDIATE CONCAT('use `', REPEAT(@mb3char, 65), '`');
--error ER_WRONG_DB_NAME
EXECUTE IMMEDIATE CONCAT('use `#mysql50#', REPEAT(@mb3char, 65), '`');
--error ER_WRONG_DB_NAME
EXECUTE IMMEDIATE CONCAT('SHOW CREATE DATABASE `', REPEAT(@mb3char, 65), '`');
--error ER_WRONG_DB_NAME
EXECUTE IMMEDIATE CONCAT('SHOW CREATE DATABASE `#mysql50#', REPEAT(@mb3char, 65), '`');
--echo #
--echo # End of 11.3 tests
--echo #