database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

MDEV-28696 View created as "select b''; " references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them

Browse Source
This commit is contained in:
Alexander Barkov
2022-12-01 15:04:59 +04:00
parent cc86360f4a
commit b91b4e0b97
5 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/main/varbinary.test
View File

@ -149,12 +149,9 @@ select N'', length(N'');
select '', length('');
--enable_view_protocol
#enable after fix MDEV-28696
--disable_view_protocol
select b'', 0+b'';
select x'', 0+x'';
--enable_view_protocol
--error ER_BAD_FIELD_ERROR
select 0x;

8
mysql-test/main/view.result
View File

@ -6905,5 +6905,13 @@ deallocate prepare stmt;
drop view v1;
drop table t1;
#
# MDEV-28696 View created as "select b''; " references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
#
CREATE VIEW v1 as select b'';
SELECT * FROM v1;
b''
DROP VIEW v1;
#
# End of 10.3 tests
#

9
mysql-test/main/view.test
View File

@ -6644,6 +6644,15 @@ deallocate prepare stmt;
drop view v1;
drop table t1;
--echo #
--echo # MDEV-28696 View created as "select b''; " references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
--echo #
CREATE VIEW v1 as select b'';
SELECT * FROM v1;
DROP VIEW v1;
--echo #
--echo # End of 10.3 tests
--echo #

19
sql/item.cc
View File

@ -7409,6 +7409,25 @@ Item_bin_string::Item_bin_string(THD *thd, const char *str, size_t str_length):
}
void Item_bin_string::print(String *str, enum_query_type query_type)
{
if (!str_value.length())
{
/*
Historically a bit string such as b'01100001'
prints itself in the hex hybrid notation: 0x61
In case of an empty bit string b'', the hex hybrid
notation would result in a bad syntax: 0x
So let's print empty bit strings using bit string notation: b''
*/
static const LEX_CSTRING empty_bit_string= {STRING_WITH_LEN("b''")};
str->append(empty_bit_string);
}
else
Item_hex_hybrid::print(str, query_type);
}
bool Item_temporal_literal::eq(const Item *item, bool binary_cmp) const
{
return

1
sql/item.h
View File

@ -4490,6 +4490,7 @@ class Item_bin_string: public Item_hex_hybrid
{
public:
Item_bin_string(THD *thd, const char *str, size_t str_length);
void print(String *str, enum_query_type query_type);
};