database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

Simple optimization: Remove JOIN::set_group_rpa as it is not needed

Browse Source
This commit is contained in:
Monty
2022-05-09 11:36:44 +03:00
committed by Sergei Petrunia
parent 5e5a8eda16
commit b44e28af6f
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sql/sql_select.cc
View File

@@ -532,7 +532,6 @@ void JOIN::init(THD *thd_arg, List<Item> &fields_arg,
no_const_tables= FALSE; no_const_tables= FALSE;
first_select= sub_select; first_select= sub_select;
set_group_rpa= false;
group_sent= 0; group_sent= 0;
outer_ref_cond= pseudo_bits_cond= NULL; outer_ref_cond= pseudo_bits_cond= NULL;
@@ -4467,7 +4466,6 @@ JOIN::reinit()
if (current_ref_ptrs != items0) if (current_ref_ptrs != items0)
{ {
set_items_ref_array(items0); set_items_ref_array(items0);
set_group_rpa= false;
} }
/* need to reset ref access state (see join_read_key) */ /* need to reset ref access state (see join_read_key) */
@@ -15383,7 +15381,6 @@ void JOIN::cleanup(bool full)
if (current_ref_ptrs != items0) if (current_ref_ptrs != items0)
{ {
set_items_ref_array(items0); set_items_ref_array(items0);
set_group_rpa= false;
} }
DBUG_VOID_RETURN; DBUG_VOID_RETURN;
} }
@@ -23647,11 +23644,8 @@ end_send_group(JOIN *join, JOIN_TAB *join_tab, bool end_of_records)
List<Item> *fields= join_tab ? (join_tab-1)->fields : join->fields; List<Item> *fields= join_tab ? (join_tab-1)->fields : join->fields;
DBUG_ENTER("end_send_group"); DBUG_ENTER("end_send_group");
if (!join->items3.is_null() && !join->set_group_rpa) if (!join->items3.is_null() && join->current_ref_ptrs != join->items3)
{
join->set_group_rpa= true;
join->set_items_ref_array(join->items3); join->set_items_ref_array(join->items3);
}
if (!join->first_record || end_of_records || if (!join->first_record || end_of_records ||
(idx=test_if_group_changed(join->group_fields)) >= 0) (idx=test_if_group_changed(join->group_fields)) >= 0)

2
sql/sql_select.h
View File

@@ -1574,8 +1574,6 @@ public:
/* SJM nests that are executed with SJ-Materialization strategy */ /* SJM nests that are executed with SJ-Materialization strategy */
List<SJ_MATERIALIZATION_INFO> sjm_info_list; List<SJ_MATERIALIZATION_INFO> sjm_info_list;
/** TRUE <=> ref_pointer_array is set to items3. */
bool set_group_rpa;
/** Exec time only: TRUE <=> current group has been sent */ /** Exec time only: TRUE <=> current group has been sent */
bool group_sent; bool group_sent;
/** /**