From b08c4201facca0501a6f6978068aaee9f9638b16 Mon Sep 17 00:00:00 2001 From: Alexander Barkov Date: Tue, 7 Jul 2015 15:59:21 +0400 Subject: [PATCH] Removing unused String declaration in Create_field::Create_field --- sql/field.cc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sql/field.cc b/sql/field.cc index 3fcae19237b..25506d6776c 100644 --- a/sql/field.cc +++ b/sql/field.cc @@ -10076,18 +10076,14 @@ Create_field::Create_field(Field *old_field,Field *orig_field) } if (!default_now) // Give a constant default { - char buff[MAX_FIELD_WIDTH]; - String tmp(buff,sizeof(buff), charset); - /* Get the value from default_values */ my_ptrdiff_t diff= orig_field->table->default_values_offset(); orig_field->move_field_offset(diff); // Points now at default_values if (!orig_field->is_real_null()) { - char buff[MAX_FIELD_WIDTH], *pos; - String tmp(buff, sizeof(buff), charset), *res; - res= orig_field->val_str(&tmp); - pos= (char*) sql_strmake(res->ptr(), res->length()); + StringBuffer tmp(charset); + String *res= orig_field->val_str(&tmp); + char *pos= (char*) sql_strmake(res->ptr(), res->length()); def= new Item_string(pos, res->length(), charset); } orig_field->move_field_offset(-diff); // Back to record[0]