From ae7e1b9b13ddc23167bd058ff4718ac116d17126 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Lindstr=C3=B6m?= <jan.lindstrom@mariadb.com>
Date: Mon, 8 Jan 2018 12:25:31 +0200
Subject: [PATCH] MDEV-13262: innodb.deadlock_detect failed in buildbot

There is a race condition on a test. con1 is the older transaction
as it query started wait first. Test continues so that con1 gets
lock wait timeout first. There is possibility that default connection
gets lock timeout also or as con1 is rolled back it gets the locks
it waited and does the update. Fixed by removing query outputs as
they could vary and accepting success from default connection
query.
---
 mysql-test/suite/innodb/r/deadlock_detect.result |  6 ------
 mysql-test/suite/innodb/t/deadlock_detect.test   | 14 +++++++++++++-
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/mysql-test/suite/innodb/r/deadlock_detect.result b/mysql-test/suite/innodb/r/deadlock_detect.result
index c3e3794ed21..4e14eff34b2 100644
--- a/mysql-test/suite/innodb/r/deadlock_detect.result
+++ b/mysql-test/suite/innodb/r/deadlock_detect.result
@@ -8,21 +8,15 @@ PRIMARY KEY(id)
 INSERT INTO t1 VALUES(1), (2), (3);
 BEGIN;
 SELECT * FROM t1 WHERE id = 1 FOR UPDATE;
-id
-1
 connect  con1,localhost,root,,;
 BEGIN;
 SELECT * FROM t1 WHERE id = 2 FOR UPDATE;
-id
-2
 SELECT * FROM t1 WHERE id = 1 FOR UPDATE;
 connection default;
 SELECT * FROM t1 WHERE id = 2 FOR UPDATE;
 connection con1;
-ERROR HY000: Lock wait timeout exceeded; try restarting transaction
 ROLLBACK;
 connection default;
-ERROR HY000: Lock wait timeout exceeded; try restarting transaction
 ROLLBACK;
 DROP TABLE t1;
 disconnect con1;
diff --git a/mysql-test/suite/innodb/t/deadlock_detect.test b/mysql-test/suite/innodb/t/deadlock_detect.test
index 85d8c1f67f2..babdb54719f 100644
--- a/mysql-test/suite/innodb/t/deadlock_detect.test
+++ b/mysql-test/suite/innodb/t/deadlock_detect.test
@@ -18,6 +18,8 @@ CREATE TABLE t1(
 
 INSERT INTO t1 VALUES(1), (2), (3);
 
+# We are not interested query results, only errors
+--disable_result_log
 BEGIN;
 
 SELECT * FROM t1 WHERE id = 1 FOR UPDATE;
@@ -39,12 +41,22 @@ reap;
 
 ROLLBACK;
 
+#
+# Note here that con1 is the older transaction as it
+# query started wait first. Thus, con1 gets lock
+# wait timeout first. There is possibility that
+# default connection gets lock timeout also or
+# as con1 is rolled back it gets the locks it waited
+# and does the update.
+#
 connection default;
---error ER_LOCK_WAIT_TIMEOUT
+--error 0,ER_LOCK_WAIT_TIMEOUT
 reap;
 
 ROLLBACK;
 
+--enable_result_log
+
 DROP TABLE t1;
 
 disconnect con1;