database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Fix for the bugs:

Browse Source 
#2005 Long decimal comparion bug.                                               
#2055 mysqldump should replace "-inf" numeric field values with "NULL"
This commit is contained in:
ram@gw.mysql.r18.ru
2003-12-09 17:33:29 +04:00
parent 56e49fd735
commit ab1c17b943
2 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
client/mysqldump.c
View File

@ -1067,10 +1067,22 @@ static void dumpTable(uint numFields, char *table)
} }
else else
{ {
/* change any strings ("inf","nan",..) into NULL */ /* change any strings ("inf", "-inf", "nan") into NULL */
char *ptr = row[i]; char *ptr = row[i];
dynstr_append(&extended_row, if (isalpha(*ptr) || (*ptr == '-' && *(ptr+1) == 'i'))
(!isalpha(*ptr)) ? ptr : "NULL"); dynstr_append(&extended_row, "NULL");
else
{
if (field->type == FIELD_TYPE_DECIMAL)
{
/* add " signs around */
dynstr_append(&extended_row, "\"");
dynstr_append(&extended_row, ptr);
dynstr_append(&extended_row, "\"");
}
else
dynstr_append(&extended_row, ptr);
}
} }
} }
else else
@ -1098,13 +1110,25 @@ static void dumpTable(uint numFields, char *table)
} }
else else
{ {
/* change any strings ("inf","nan",..) into NULL */ /* change any strings ("inf", "-inf", "nan") into NULL */
char *ptr = row[i]; char *ptr = row[i];
if (opt_xml) if (opt_xml)
fprintf(md_result_file, "\t\t<field name=\"%s\">%s</field>\n", fprintf(md_result_file, "\t\t<field name=\"%s\">%s</field>\n",
field->name,!isalpha(*ptr) ?ptr: "NULL"); field->name,!isalpha(*ptr) ?ptr: "NULL");
else if (isalpha(*ptr) || (*ptr == '-' && *(ptr+1) == 'i'))
fputs("NULL", md_result_file);
else else
fputs((!isalpha(*ptr)) ? ptr : "NULL", md_result_file); {
if (field->type == FIELD_TYPE_DECIMAL)
{
/* add " signs around */
fputs("\"", md_result_file);
fputs(ptr, md_result_file);
fputs("\"", md_result_file);
}
else
fputs(ptr, md_result_file);
}
} }
} }
else else

19
mysql-test/t/mysqldump.test
View File

@ -8,3 +8,22 @@ CREATE TABLE t1(a int);
INSERT INTO t1 VALUES (1), (2); INSERT INTO t1 VALUES (1), (2);
--exec $MYSQL_DUMP -X test t1 --exec $MYSQL_DUMP -X test t1
DROP TABLE t1; DROP TABLE t1;
#
# Bug #2005
#
CREATE TABLE t1 (a decimal(240, 20));
INSERT INTO t1 VALUES ("1234567890123456789012345678901234567890"),
("0987654321098765432109876543210987654321");
--exec $MYSQL_DUMP test t1
DROP TABLE t1;
#
# Bug #2055
#
CREATE TABLE t1 (a double);
INSERT INTO t1 VALUES (-9e999999);
--exec $MYSQL_DUMP test t1
DROP TABLE t1;