mirror of
https://github.com/MariaDB/server.git
synced 2025-07-29 05:21:33 +03:00
Bug#13832772 ASSERTION `THD->IS_ERROR() || KILL_ERRNO'
We are trying to sort a lot of text/blob fields, so the buffer is indeed too small. Memory available = thd->variables.sortbuff_size = 262144 min_sort_memory = param.sort_length*MERGEBUFF2 = 292245 So the decision to abort the query is correct. filesort() calls my_error(), the error is reported. But, since we have DELETE IGNORE ... the error is converted to a warning by THD::raise_condition filesort currently expects an error to be recorded in the THD diagnostics area. If we lift this restriction (remove the assert) we end up in the familiar void Protocol::end_statement() default: DBUG_ASSERT(0); The solution seems to be to call my_error(ME_FATALERROR) in filesort, so that the error is propagated as an error rather than a warning. mysql-test/r/filesort_debug.result: New test case. mysql-test/t/filesort_debug.test: New test case.
This commit is contained in:
@ -57,3 +57,47 @@ disconnect con2;
|
||||
--source include/wait_until_count_sessions.inc
|
||||
SET DEBUG_SYNC= "RESET";
|
||||
DROP TABLE t1;
|
||||
|
||||
--echo #
|
||||
--echo # Bug#13832772 ASSERTION `THD->IS_ERROR() || KILL_ERRNO'
|
||||
--echo # FAILED IN FILESORT/MYSQL_DELETE
|
||||
--echo #
|
||||
|
||||
CREATE TABLE t1 (
|
||||
c1 BLOB,
|
||||
c2 TEXT,
|
||||
c3 TEXT,
|
||||
c4 TEXT,
|
||||
c5 TEXT,
|
||||
c6 TEXT,
|
||||
c7 TEXT,
|
||||
c8 BLOB,
|
||||
c9 TEXT,
|
||||
c19 TEXT,
|
||||
pk INT,
|
||||
c20 TEXT,
|
||||
c21 BLOB,
|
||||
c22 TEXT,
|
||||
c23 TEXT,
|
||||
c24 TEXT,
|
||||
c25 TEXT,
|
||||
c26 BLOB,
|
||||
c27 TEXT,
|
||||
c28 TEXT,
|
||||
primary key (pk)
|
||||
) ENGINE=InnoDB
|
||||
;
|
||||
|
||||
CALL mtr.add_suppression("Out of sort memory");
|
||||
|
||||
--error ER_OUT_OF_SORTMEMORY
|
||||
DELETE IGNORE FROM t1 ORDER BY c26,c7,c23,c4,c25,c5,c20,
|
||||
c19,c21,c8,c1,c27,c28,c3,c9,c22,c24,c6,c2,pk LIMIT 2;
|
||||
SHOW WARNINGS;
|
||||
|
||||
--error ER_OUT_OF_SORTMEMORY
|
||||
DELETE FROM t1 ORDER BY c26,c7,c23,c4,c25,c5,c20,
|
||||
c19,c21,c8,c1,c27,c28,c3,c9,c22,c24,c6,c2,pk LIMIT 2;
|
||||
SHOW WARNINGS;
|
||||
|
||||
DROP TABLE t1;
|
||||
|
Reference in New Issue
Block a user