database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

DS-MRR improvements:

Browse Source 
- address the review feedback (class/var renames)
- fix wrong test result (bug in buffer refill logic)
This commit is contained in:
Sergey Petrunya
2010-10-28 20:48:16 +04:00
parent d8efc3b155
commit a88bd5cf56
2 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sql/multi_range_read.h
View File

@ -130,18 +130,18 @@ public:
been reached and get_next() must not be called anymore.
*/
class Mrr_strategy
class Mrr_reader
{
public:
virtual int get_next(char **range_info) = 0;
virtual int refill_buffer()=0;
virtual ~Mrr_strategy() {};
virtual ~Mrr_reader() {}; /* just to remove compiler warning */
};
/* A common base for strategies that do index scans and produce index tuples */
class Mrr_index_reader : public Mrr_strategy
class Mrr_index_reader : public Mrr_reader
{
public:
handler *h;
@ -241,7 +241,7 @@ private:
/* MRR strategy that fetches rowids */
class Mrr_ordered_rndpos_reader : public Mrr_strategy
class Mrr_ordered_rndpos_reader : public Mrr_reader
{
public:
int init(handler *h, Mrr_index_reader *index_reader, uint mode,
@ -271,7 +271,7 @@ private:
uchar *rowids_range_id;
};
class Mrr_strategy_factory
class Mrr_reader_factory
{
public:
Mrr_ordered_rndpos_reader ordered_rndpos_reader;
@ -458,8 +458,8 @@ private:
/* TRUE <=> sort rowids and use rnd_pos() to get and return full records */
//bool do_rndpos_scan;
Mrr_strategy_factory strategy_factory;
Mrr_strategy *strategy;
Mrr_reader_factory strategy_factory;
Mrr_reader *strategy;
Mrr_index_reader *index_strategy;
/* The whole buffer space that we're using */