database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Cleanup: renaming methods make_field(Send_field*) to make_send_field(..)

Browse Source 
Renaming methods:
- Field::make_field(Send_field*) to make_send_field(..)
- Item::make_field(THD *,Send_field *) to make_send_field(..)
- Item::init_make_field(Send_field *, enum_field_type) to init_make_send_field(..)

These names looked similar to other functions that are used
for a very different purpose (creating Field instances):
- Public function "Field * make_field(..)"
- Method "Field *Column_defitinion::make_field(..)"

The rename makes it's easier to search the code using "grep".
This commit is contained in:
Alexander Barkov
2018-04-05 21:27:33 +04:00
parent d8da97b09a
commit a1a966fc0e
13 changed files with 60 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sql/sql_type.cc
View File

@ -293,7 +293,7 @@ bool Type_std_attributes::count_string_length(const char *func_name,
This method is used by:
- Item_user_var_as_out_param::field_type()
- Item_func_udf_str::field_type()
- Item_empty_string::make_field()
- Item_empty_string::make_send_field()
TODO: type_handler_adjusted_to_max_octet_length() and string_type_handler()
provide very similar functionality, to properly choose between