database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Cleanup: renaming methods make_field(Send_field*) to make_send_field(..)

Browse Source 
Renaming methods:
- Field::make_field(Send_field*) to make_send_field(..)
- Item::make_field(THD *,Send_field *) to make_send_field(..)
- Item::init_make_field(Send_field *, enum_field_type) to init_make_send_field(..)

These names looked similar to other functions that are used
for a very different purpose (creating Field instances):
- Public function "Field * make_field(..)"
- Method "Field *Column_defitinion::make_field(..)"

The rename makes it's easier to search the code using "grep".
This commit is contained in:
Alexander Barkov
2018-04-05 21:27:33 +04:00
parent d8da97b09a
commit a1a966fc0e
13 changed files with 60 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sql/field.h
View File

@ -1219,7 +1219,7 @@ public:
}
void make_sort_key(uchar *buff, uint length);
virtual void make_field(Send_field *);
virtual void make_send_field(Send_field *);
virtual void sort_string(uchar *buff,uint length)=0;
virtual bool optimize_range(uint idx, uint part) const;
virtual void free() {}
@ -1659,7 +1659,7 @@ public:
}
void add_zerofill_and_unsigned(String &res) const;
friend class Create_field;
void make_field(Send_field *);
void make_send_field(Send_field *);
uint decimals() const { return (uint) dec; }
uint size_of() const { return sizeof(*this); }
bool eq_def(const Field *field) const;
@ -2571,7 +2571,7 @@ public:
const uchar *unpack(uchar* to, const uchar *from, const uchar *from_end,
uint param_data)
{ return Field::unpack(to, from, from_end, param_data); }
void make_field(Send_field *field);
void make_send_field(Send_field *field);
void sort_string(uchar *to, uint length)
{
DBUG_ASSERT(length == pack_length());
@ -2855,7 +2855,7 @@ public:
enum ha_base_keytype key_type() const { return HA_KEYTYPE_BINARY; }
longlong val_int(void);
double val_real(void);
void make_field(Send_field *);
void make_send_field(Send_field *);
};
@ -3006,7 +3006,7 @@ public:
}
uint decimals() const { return dec; }
enum ha_base_keytype key_type() const { return HA_KEYTYPE_BINARY; }
void make_field(Send_field *field);
void make_send_field(Send_field *field);
bool send_binary(Protocol *protocol);
uchar *pack(uchar *to, const uchar *from, uint max_length)
{ return Field::pack(to, from, max_length); }