database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-01 03:47:19 +03:00
Code Activity

Added "const" to new data for handler::update_row()

Browse Source 
This was done to make it clear that a update_row() should not change the
row.
This was not done for handler::write_row() as this function still needs
to update auto_increment values in the row. This should at some point
be moved to handler::ha_write_row() after which write_row can also have
const arguments.
This commit is contained in:
Michael Widenius
2017-04-16 22:40:39 +03:00
committed by Monty
parent d82ac8eaaf
commit a05a610d60
73 changed files with 126 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sql/handler.cc
View File

@ -4042,7 +4042,7 @@ int handler::ha_repair(THD* thd, HA_CHECK_OPT* check_opt)
*/
int
handler::ha_bulk_update_row(const uchar *old_data, uchar *new_data,
handler::ha_bulk_update_row(const uchar *old_data, const uchar *new_data,
uint *dup_key_found)
{
DBUG_ASSERT(table_share->tmp_table != NO_TMP_TABLE ||
@ -5998,7 +5998,7 @@ int handler::ha_write_row(uchar *buf)
}
int handler::ha_update_row(const uchar *old_data, uchar *new_data)
int handler::ha_update_row(const uchar *old_data, const uchar *new_data)
{
int error;
Log_func *log_func= Update_rows_log_event::binlog_row_logging_function;