mirror of
https://github.com/MariaDB/server.git
synced 2025-07-30 16:24:05 +03:00
Merge bk-internal.mysql.com:/data0/bk/mysql-5.1
into bk-internal.mysql.com:/data0/bk/mysql-5.1-arch client/mysql.cc: Auto merged sql/field_conv.cc: Auto merged sql/handler.cc: Auto merged sql/item.cc: Auto merged sql/item_func.cc: Auto merged sql/item_timefunc.cc: Auto merged sql/sp.cc: Auto merged sql/sql_parse.cc: Auto merged sql/sql_table.cc: Auto merged sql/sql_yacc.yy: Auto merged
This commit is contained in:
226
sql/sql_table.cc
226
sql/sql_table.cc
@ -37,7 +37,9 @@ static char *make_unique_key_name(const char *field_name,KEY *start,KEY *end);
|
||||
static int copy_data_between_tables(TABLE *from,TABLE *to,
|
||||
List<create_field> &create, bool ignore,
|
||||
uint order_num, ORDER *order,
|
||||
ha_rows *copied,ha_rows *deleted);
|
||||
ha_rows *copied,ha_rows *deleted,
|
||||
enum enum_enable_or_disable keys_onoff);
|
||||
|
||||
static bool prepare_blob_field(THD *thd, create_field *sql_field);
|
||||
static bool check_engine(THD *thd, const char *table_name,
|
||||
HA_CREATE_INFO *create_info);
|
||||
@ -3652,10 +3654,12 @@ make_unique_key_name(const char *field_name,KEY *start,KEY *end)
|
||||
flags flags for build_table_filename().
|
||||
FN_FROM_IS_TMP old_name is temporary.
|
||||
FN_TO_IS_TMP new_name is temporary.
|
||||
NO_FRM_RENAME Don't rename the FRM file
|
||||
but only the table in the storage engine.
|
||||
|
||||
RETURN
|
||||
0 OK
|
||||
!= 0 Error
|
||||
FALSE OK
|
||||
TRUE Error
|
||||
*/
|
||||
|
||||
bool
|
||||
@ -3704,7 +3708,7 @@ mysql_rename_table(handlerton *base, const char *old_db,
|
||||
|
||||
if (!file || !(error=file->rename_table(from_base, to_base)))
|
||||
{
|
||||
if (rename_file_ext(from,to,reg_ext))
|
||||
if (!(flags & NO_FRM_RENAME) && rename_file_ext(from,to,reg_ext))
|
||||
{
|
||||
error=my_errno;
|
||||
/* Restore old file name */
|
||||
@ -5195,8 +5199,101 @@ static uint compare_tables(TABLE *table, List<create_field> *create_list,
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
Manages enabling/disabling of indexes for ALTER TABLE
|
||||
|
||||
SYNOPSIS
|
||||
alter_table_manage_keys()
|
||||
table Target table
|
||||
indexes_were_disabled Whether the indexes of the from table
|
||||
were disabled
|
||||
keys_onoff ENABLE | DISABLE | LEAVE_AS_IS
|
||||
|
||||
RETURN VALUES
|
||||
FALSE OK
|
||||
TRUE Error
|
||||
*/
|
||||
|
||||
static
|
||||
bool alter_table_manage_keys(TABLE *table, int indexes_were_disabled,
|
||||
enum enum_enable_or_disable keys_onoff)
|
||||
{
|
||||
int error= 0;
|
||||
DBUG_ENTER("alter_table_manage_keys");
|
||||
DBUG_PRINT("enter", ("table=%p were_disabled=%d on_off=%d",
|
||||
table, indexes_were_disabled, keys_onoff));
|
||||
|
||||
switch (keys_onoff) {
|
||||
case ENABLE:
|
||||
error= table->file->enable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
break;
|
||||
case LEAVE_AS_IS:
|
||||
if (!indexes_were_disabled)
|
||||
break;
|
||||
/* fall-through: disabled indexes */
|
||||
case DISABLE:
|
||||
error= table->file->disable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
}
|
||||
|
||||
if (error == HA_ERR_WRONG_COMMAND)
|
||||
{
|
||||
push_warning_printf(current_thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
||||
ER_ILLEGAL_HA, ER(ER_ILLEGAL_HA), table->s->table_name);
|
||||
error= 0;
|
||||
} else if (error)
|
||||
table->file->print_error(error, MYF(0));
|
||||
|
||||
DBUG_RETURN(error);
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
Alter table
|
||||
|
||||
SYNOPSIS
|
||||
mysql_alter_table()
|
||||
thd Thread handle
|
||||
new_db If there is a RENAME clause
|
||||
new_name If there is a RENAME clause
|
||||
lex_create_info Information from the parsing phase. Since some
|
||||
clauses are common to CREATE and ALTER TABLE, the
|
||||
data is stored in lex->create_info. The non-common
|
||||
is stored in lex->alter_info.
|
||||
table_list The table to change.
|
||||
fields lex->create_list - List of fields to be changed,
|
||||
added or dropped.
|
||||
keys lex->key_list - List of keys to be changed, added or
|
||||
dropped.
|
||||
order_num How many ORDER BY fields has been specified.
|
||||
order List of fields to ORDER BY.
|
||||
ignore Whether we have ALTER IGNORE TABLE
|
||||
alter_info Information from the parsing phase specific to ALTER
|
||||
TABLE and not shared with CREATE TABLE.
|
||||
do_send_ok Whether to call send_ok() on success.
|
||||
|
||||
DESCRIPTION
|
||||
This is a veery long function and is everything but the kitchen sink :)
|
||||
It is used to alter a table and not only by ALTER TABLE but also
|
||||
CREATE|DROP INDEX are mapped on this function.
|
||||
|
||||
When the ALTER TABLE statement just does a RENAME or ENABLE|DISABLE KEYS,
|
||||
or both, then this function short cuts its operation by renaming
|
||||
the table and/or enabling/disabling the keys. In this case, the FRM is
|
||||
not changed, directly by mysql_alter_table. However, if there is a
|
||||
RENAME + change of a field, or an index, the short cut is not used.
|
||||
See how `fields` is used to generate the new FRM regarding the structure
|
||||
of the fields. The same is done for the indices of the table.
|
||||
|
||||
Important is the fact, that this function tries to do as little work as
|
||||
possible, by finding out whether a intermediate table is needed to copy
|
||||
data into and when finishing the altering to use it as the original table.
|
||||
For this reason the function compare_tables() is called, which decides
|
||||
based on all kind of data how similar are the new and the original
|
||||
tables.
|
||||
|
||||
RETURN VALUES
|
||||
FALSE OK
|
||||
TRUE Error
|
||||
*/
|
||||
|
||||
bool mysql_alter_table(THD *thd,char *new_db, char *new_name,
|
||||
@ -5215,7 +5312,7 @@ bool mysql_alter_table(THD *thd,char *new_db, char *new_name,
|
||||
char reg_path[FN_REFLEN+1];
|
||||
ha_rows copied,deleted;
|
||||
uint db_create_options, used_fields;
|
||||
handlerton *old_db_type, *new_db_type;
|
||||
handlerton *old_db_type, *new_db_type, *save_old_db_type;
|
||||
legacy_db_type table_type;
|
||||
HA_CREATE_INFO *create_info;
|
||||
frm_type_enum frm_type;
|
||||
@ -5443,13 +5540,35 @@ view_err:
|
||||
if (!(alter_info->flags & ~(ALTER_RENAME | ALTER_KEYS_ONOFF)) &&
|
||||
!table->s->tmp_table) // no need to touch frm
|
||||
{
|
||||
error=0;
|
||||
VOID(pthread_mutex_lock(&LOCK_open));
|
||||
if (new_name != table_name || new_db != db)
|
||||
|
||||
switch (alter_info->keys_onoff) {
|
||||
case LEAVE_AS_IS:
|
||||
error= 0;
|
||||
break;
|
||||
case ENABLE:
|
||||
wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
|
||||
error= table->file->enable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
/* COND_refresh will be signaled in close_thread_tables() */
|
||||
break;
|
||||
case DISABLE:
|
||||
wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
|
||||
error=table->file->disable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
/* COND_refresh will be signaled in close_thread_tables() */
|
||||
break;
|
||||
}
|
||||
if (error == HA_ERR_WRONG_COMMAND)
|
||||
{
|
||||
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
||||
ER_ILLEGAL_HA, ER(ER_ILLEGAL_HA),
|
||||
table->alias);
|
||||
error= 0;
|
||||
}
|
||||
|
||||
if (!error && (new_name != table_name || new_db != db))
|
||||
{
|
||||
thd->proc_info="rename";
|
||||
/* Then do a 'simple' rename of the table */
|
||||
error=0;
|
||||
if (!access(new_name_buff,F_OK))
|
||||
{
|
||||
my_error(ER_TABLE_EXISTS_ERROR, MYF(0), new_name);
|
||||
@ -5472,31 +5591,14 @@ view_err:
|
||||
}
|
||||
}
|
||||
|
||||
if (!error)
|
||||
{
|
||||
switch (alter_info->keys_onoff) {
|
||||
case LEAVE_AS_IS:
|
||||
break;
|
||||
case ENABLE:
|
||||
wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
|
||||
error= table->file->enable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
/* COND_refresh will be signaled in close_thread_tables() */
|
||||
break;
|
||||
case DISABLE:
|
||||
wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
|
||||
error=table->file->disable_indexes(HA_KEY_SWITCH_NONUNIQ_SAVE);
|
||||
/* COND_refresh will be signaled in close_thread_tables() */
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (error == HA_ERR_WRONG_COMMAND)
|
||||
{
|
||||
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
||||
ER_ILLEGAL_HA, ER(ER_ILLEGAL_HA),
|
||||
table->alias);
|
||||
error=0;
|
||||
error= 0;
|
||||
}
|
||||
|
||||
if (!error)
|
||||
{
|
||||
write_bin_log(thd, TRUE, thd->query, thd->query_length);
|
||||
@ -5509,12 +5611,12 @@ view_err:
|
||||
error= -1;
|
||||
}
|
||||
VOID(pthread_mutex_unlock(&LOCK_open));
|
||||
table_list->table=0; // For query cache
|
||||
table_list->table= NULL; // For query cache
|
||||
query_cache_invalidate3(thd, table_list, 0);
|
||||
DBUG_RETURN(error);
|
||||
}
|
||||
|
||||
/* Full alter table */
|
||||
/* We have to do full alter table */
|
||||
|
||||
/* Let new create options override the old ones */
|
||||
if (!(used_fields & HA_CREATE_USED_MIN_ROWS))
|
||||
@ -6033,8 +6135,8 @@ view_err:
|
||||
old data and index files. Create also symlinks to point at
|
||||
the new tables.
|
||||
Copy data.
|
||||
At end, rename temporary tables and symlinks to temporary table
|
||||
to final table name.
|
||||
At end, rename intermediate tables, and symlinks to intermediate
|
||||
table, to final table name.
|
||||
Remove old table and old symlinks
|
||||
|
||||
If rename is made to another database:
|
||||
@ -6095,6 +6197,7 @@ view_err:
|
||||
/* table is a normal table: Create temporary table in same directory */
|
||||
build_table_filename(path, sizeof(path), new_db, tmp_name, "",
|
||||
FN_IS_TMP);
|
||||
/* Open our intermediate table */
|
||||
new_table=open_temporary_table(thd, path, new_db, tmp_name,0);
|
||||
}
|
||||
if (!new_table)
|
||||
@ -6112,7 +6215,18 @@ view_err:
|
||||
new_table->timestamp_field_type= TIMESTAMP_NO_AUTO_SET;
|
||||
new_table->next_number_field=new_table->found_next_number_field;
|
||||
error=copy_data_between_tables(table, new_table, create_list, ignore,
|
||||
order_num, order, &copied, &deleted);
|
||||
order_num, order, &copied, &deleted,
|
||||
alter_info->keys_onoff);
|
||||
}
|
||||
else
|
||||
{
|
||||
VOID(pthread_mutex_lock(&LOCK_open));
|
||||
wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
|
||||
table->file->ha_external_lock(thd, F_WRLCK);
|
||||
alter_table_manage_keys(table, table->file->indexes_are_disabled(),
|
||||
alter_info->keys_onoff);
|
||||
table->file->ha_external_lock(thd, F_UNLCK);
|
||||
VOID(pthread_mutex_unlock(&LOCK_open));
|
||||
}
|
||||
thd->count_cuted_fields= CHECK_FIELD_IGNORE;
|
||||
|
||||
@ -6300,7 +6414,7 @@ view_err:
|
||||
|
||||
if (new_table)
|
||||
{
|
||||
/* close temporary table that will be the new table */
|
||||
/* Close the intermediate table that will be the new table */
|
||||
intern_close_table(new_table);
|
||||
my_free((gptr) new_table,MYF(0));
|
||||
}
|
||||
@ -6314,7 +6428,7 @@ view_err:
|
||||
|
||||
/*
|
||||
Data is copied. Now we rename the old table to a temp name,
|
||||
rename the new one to the old name, remove all entries from the old table
|
||||
rename the new one to the old name, remove all entries about the old table
|
||||
from the cache, free all locks, close the old table and remove it.
|
||||
*/
|
||||
|
||||
@ -6341,7 +6455,7 @@ view_err:
|
||||
{
|
||||
/*
|
||||
Win32 and InnoDB can't drop a table that is in use, so we must
|
||||
close the original table at before doing the rename
|
||||
close the original table before doing the rename
|
||||
*/
|
||||
table->s->version= 0; // Force removal of table def
|
||||
close_cached_table(thd, table);
|
||||
@ -6355,6 +6469,21 @@ view_err:
|
||||
|
||||
|
||||
error=0;
|
||||
save_old_db_type= old_db_type;
|
||||
|
||||
/*
|
||||
This leads to the storage engine (SE) not being notified for renames in
|
||||
mysql_rename_table(), because we just juggle with the FRM and nothing
|
||||
more. If we have an intermediate table, then we notify the SE that
|
||||
it should become the actual table. Later, we will recycle the old table.
|
||||
However, in case of ALTER TABLE RENAME there might be no intermediate
|
||||
table. This is when the old and new tables are compatible, according to
|
||||
compare_table(). Then, we need one additional call to
|
||||
mysql_rename_table() with flag NO_FRM_RENAME, which does nothing else but
|
||||
actual rename in the SE and the FRM is not touched. Note that, if the
|
||||
table is renamed and the SE is also changed, then an intermediate table
|
||||
is created and the additional call will not take place.
|
||||
*/
|
||||
if (!need_copy_table)
|
||||
new_db_type=old_db_type= NULL; // this type cannot happen in regular ALTER
|
||||
if (mysql_rename_table(old_db_type, db, table_name, db, old_name,
|
||||
@ -6364,8 +6493,11 @@ view_err:
|
||||
VOID(quick_rm_table(new_db_type, new_db, tmp_name, FN_IS_TMP));
|
||||
}
|
||||
else if (mysql_rename_table(new_db_type,new_db,tmp_name,new_db,
|
||||
new_alias, FN_FROM_IS_TMP) ||
|
||||
new_alias, FN_FROM_IS_TMP) ||
|
||||
(new_name != table_name || new_db != db) && // we also do rename
|
||||
(need_copy_table ||
|
||||
mysql_rename_table(save_old_db_type, db, table_name, new_db,
|
||||
new_alias, NO_FRM_RENAME)) &&
|
||||
Table_triggers_list::change_table_name(thd, db, table_name,
|
||||
new_db, new_alias))
|
||||
{
|
||||
@ -6376,6 +6508,7 @@ view_err:
|
||||
VOID(mysql_rename_table(old_db_type, db, old_name, db, alias,
|
||||
FN_FROM_IS_TMP));
|
||||
}
|
||||
|
||||
if (error)
|
||||
{
|
||||
/*
|
||||
@ -6394,6 +6527,15 @@ view_err:
|
||||
{
|
||||
if (! table)
|
||||
{
|
||||
if (new_name != table_name || new_db != db)
|
||||
{
|
||||
table_list->alias= new_name;
|
||||
table_list->table_name= new_name;
|
||||
table_list->table_name_length= strlen(new_name);
|
||||
table_list->db= new_db;
|
||||
table_list->db_length= strlen(new_db);
|
||||
}
|
||||
|
||||
VOID(pthread_mutex_unlock(&LOCK_open));
|
||||
if (! (table= open_ltable(thd, table_list, TL_WRITE_ALLOW_READ)))
|
||||
goto err;
|
||||
@ -6407,6 +6549,7 @@ view_err:
|
||||
goto err;
|
||||
}
|
||||
}
|
||||
|
||||
if (thd->lock || new_name != table_name || no_table_reopen) // True if WIN32
|
||||
{
|
||||
/*
|
||||
@ -6473,10 +6616,7 @@ view_err:
|
||||
DBUG_ASSERT(!(mysql_bin_log.is_open() && thd->current_stmt_binlog_row_based &&
|
||||
(create_info->options & HA_LEX_CREATE_TMP_TABLE)));
|
||||
write_bin_log(thd, TRUE, thd->query, thd->query_length);
|
||||
/*
|
||||
TODO RONM: This problem needs to handled for Berkeley DB partitions
|
||||
as well
|
||||
*/
|
||||
|
||||
if (ha_check_storage_engine_flag(old_db_type,HTON_FLUSH_AFTER_RENAME))
|
||||
{
|
||||
/*
|
||||
@ -6529,7 +6669,8 @@ copy_data_between_tables(TABLE *from,TABLE *to,
|
||||
bool ignore,
|
||||
uint order_num, ORDER *order,
|
||||
ha_rows *copied,
|
||||
ha_rows *deleted)
|
||||
ha_rows *deleted,
|
||||
enum enum_enable_or_disable keys_onoff)
|
||||
{
|
||||
int error;
|
||||
Copy_field *copy,*copy_end;
|
||||
@ -6563,6 +6704,9 @@ copy_data_between_tables(TABLE *from,TABLE *to,
|
||||
if (to->file->ha_external_lock(thd, F_WRLCK))
|
||||
DBUG_RETURN(-1);
|
||||
|
||||
/* We need external lock before we can disable/enable keys */
|
||||
alter_table_manage_keys(to, from->file->indexes_are_disabled(), keys_onoff);
|
||||
|
||||
/* We can abort alter table for any table type */
|
||||
thd->no_trans_update= 0;
|
||||
thd->abort_on_warning= !ignore && test(thd->variables.sql_mode &
|
||||
|
Reference in New Issue
Block a user