database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-09 22:24:09 +03:00
Code Activity

MDEV-8199 - first_breadth_first_tab() takes 0.07% in OLTP RO

Browse Source 
This is an addition to original patch: cleanups for next_breadth_first_tab().

Overhead change:
next_breadth_first_tab()  0.04% -> out of radar
This commit is contained in:
Sergey Vojtovich
2015-05-21 13:08:46 +04:00
parent 45f41b52e8
commit 9b57b214c4
1 changed files with 12 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
sql/sql_select.cc
View File

@@ -276,9 +276,8 @@ Item_equal *find_item_equal(COND_EQUAL *cond_equal, Field *field,
JOIN_TAB *first_depth_first_tab(JOIN* join); JOIN_TAB *first_depth_first_tab(JOIN* join);
JOIN_TAB *next_depth_first_tab(JOIN* join, JOIN_TAB* tab); JOIN_TAB *next_depth_first_tab(JOIN* join, JOIN_TAB* tab);
enum enum_exec_or_opt {WALK_OPTIMIZATION_TABS , WALK_EXECUTION_TABS}; static JOIN_TAB *next_breadth_first_tab(JOIN_TAB *first_top_tab,
JOIN_TAB *next_breadth_first_tab(JOIN *join, enum enum_exec_or_opt tabs_kind, uint n_top_tabs_count, JOIN_TAB *tab);
JOIN_TAB *tab);
static double table_cond_selectivity(JOIN *join, uint idx, JOIN_TAB *s, static double table_cond_selectivity(JOIN *join, uint idx, JOIN_TAB *s,
table_map rem_tables); table_map rem_tables);
@@ -7206,7 +7205,8 @@ double JOIN::get_examined_rows()
examined_rows= tab->get_examined_rows(); examined_rows= tab->get_examined_rows();
while ((tab= next_breadth_first_tab(this, WALK_OPTIMIZATION_TABS, tab))) while ((tab= next_breadth_first_tab(first_breadth_first_optimization_tab(),
top_table_access_tabs_count, tab)))
{ {
prev_fanout *= prev_tab->records_read; prev_fanout *= prev_tab->records_read;
examined_rows+= tab->get_examined_rows() * prev_fanout; examined_rows+= tab->get_examined_rows() * prev_fanout;
@@ -8200,23 +8200,9 @@ prev_record_reads(POSITION *positions, uint idx, table_map found_ref)
Enumerate join tabs in breadth-first fashion, including const tables. Enumerate join tabs in breadth-first fashion, including const tables.
*/ */
JOIN_TAB *next_breadth_first_tab(JOIN *join, enum enum_exec_or_opt tabs_kind, static JOIN_TAB *next_breadth_first_tab(JOIN_TAB *first_top_tab,
JOIN_TAB *tab) uint n_top_tabs_count, JOIN_TAB *tab)
{ {
JOIN_TAB *first_top_tab;
uint n_top_tabs_count;
if (tabs_kind == WALK_EXECUTION_TABS)
{
first_top_tab= join->first_breadth_first_execution_tab();
n_top_tabs_count= join->top_join_tab_count;
}
else
{
first_top_tab= join->first_breadth_first_optimization_tab();
n_top_tabs_count= join->top_table_access_tabs_count;
}
if (!tab->bush_root_tab) if (!tab->bush_root_tab)
{ {
/* We're at top level. Get the next top-level tab */ /* We're at top level. Get the next top-level tab */
@@ -8308,7 +8294,8 @@ JOIN_TAB *first_top_level_tab(JOIN *join, enum enum_with_const_tables const_tbls
JOIN_TAB *next_top_level_tab(JOIN *join, JOIN_TAB *tab) JOIN_TAB *next_top_level_tab(JOIN *join, JOIN_TAB *tab)
{ {
tab= next_breadth_first_tab(join, WALK_EXECUTION_TABS, tab); tab= next_breadth_first_tab(join->first_breadth_first_execution_tab(),
join->top_join_tab_count, tab);
if (tab && tab->bush_root_tab) if (tab && tab->bush_root_tab)
tab= NULL; tab= NULL;
return tab; return tab;
@@ -11804,7 +11791,8 @@ void JOIN::cleanup(bool full)
if (table_count) if (table_count)
{ {
for (tab= first_breadth_first_optimization_tab(); tab; for (tab= first_breadth_first_optimization_tab(); tab;
tab= next_breadth_first_tab(this, WALK_OPTIMIZATION_TABS, tab)) tab= next_breadth_first_tab(first_breadth_first_optimization_tab(),
top_table_access_tabs_count, tab))
tab->cleanup(); tab->cleanup();
/* We've walked optimization tabs, do execution ones too. */ /* We've walked optimization tabs, do execution ones too. */
@@ -11812,7 +11800,8 @@ void JOIN::cleanup(bool full)
first_breadth_first_optimization_tab()) first_breadth_first_optimization_tab())
{ {
for (tab= first_breadth_first_execution_tab(); tab; for (tab= first_breadth_first_execution_tab(); tab;
tab= next_breadth_first_tab(this, WALK_EXECUTION_TABS, tab)) tab= next_breadth_first_tab(first_breadth_first_execution_tab(),
top_join_tab_count, tab))
tab->cleanup(); tab->cleanup();
} }
} }