database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-16888 Add virtual Type_handler::cond_notnull_field_isnull_to_field_eq_zero()

Browse Source
This commit is contained in:
Alexander Barkov
2018-08-03 07:55:50 +04:00
parent 8ecc75373f
commit 980aa3e71d
3 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sql/item_cmpfunc.h
View File

@ -2518,9 +2518,8 @@ public:
{ {
Field *field=((Item_field*) args[0]->real_item())->field; Field *field=((Item_field*) args[0]->real_item())->field;
if (((field->type() == MYSQL_TYPE_DATE) || if ((field->flags & NOT_NULL_FLAG) &&
(field->type() == MYSQL_TYPE_DATETIME)) && field->type_handler()->cond_notnull_field_isnull_to_field_eq_zero())
(field->flags & NOT_NULL_FLAG))
return true; return true;
} }
return false; return false;

5
sql/sql_select.cc
View File

@ -16360,9 +16360,8 @@ Item_func_isnull::remove_eq_conds(THD *thd, Item::cond_result *cond_value,
{ {
Field *field= ((Item_field*) real_item)->field; Field *field= ((Item_field*) real_item)->field;
if (((field->type() == MYSQL_TYPE_DATE) || if ((field->flags & NOT_NULL_FLAG) &&
(field->type() == MYSQL_TYPE_DATETIME)) && field->type_handler()->cond_notnull_field_isnull_to_field_eq_zero())
(field->flags & NOT_NULL_FLAG))
{ {
/* fix to replace 'NULL' dates with '0' (shreeve@uci.edu) */ /* fix to replace 'NULL' dates with '0' (shreeve@uci.edu) */
/* /*

19
sql/sql_type.h
View File

@ -1399,6 +1399,17 @@ public:
{ {
return false; return false;
} }
/*
Returns true if this data type supports a hack that
WHERE notnull_column IS NULL
finds zero values, e.g.:
WHERE date_notnull_column IS NULL ->
WHERE date_notnull_column = '0000-00-00'
*/
virtual bool cond_notnull_field_isnull_to_field_eq_zero() const
{
return false;
}
/** /**
Check whether a field type can be partially indexed by a key. Check whether a field type can be partially indexed by a key.
@param type field type @param type field type
@ -3344,6 +3355,10 @@ public:
{ {
return MYSQL_TIMESTAMP_DATE; return MYSQL_TIMESTAMP_DATE;
} }
bool cond_notnull_field_isnull_to_field_eq_zero() const
{
return true;
}
Item_literal *create_literal_item(THD *thd, const char *str, size_t length, Item_literal *create_literal_item(THD *thd, const char *str, size_t length,
CHARSET_INFO *cs, bool send_error) const; CHARSET_INFO *cs, bool send_error) const;
Item *create_typecast_item(THD *thd, Item *item, Item *create_typecast_item(THD *thd, Item *item,
@ -3425,6 +3440,10 @@ public:
{ {
return MYSQL_TIMESTAMP_DATETIME; return MYSQL_TIMESTAMP_DATETIME;
} }
bool cond_notnull_field_isnull_to_field_eq_zero() const
{
return true;
}
Item *create_typecast_item(THD *thd, Item *item, Item *create_typecast_item(THD *thd, Item *item,
const Type_cast_attributes &attr) const; const Type_cast_attributes &attr) const;
void Column_definition_implicit_upgrade(Column_definition *c) const; void Column_definition_implicit_upgrade(Column_definition *c) const;