database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

cleanup: freshen up CREATE SERVER code

Browse Source 
* pass LEX_STRING's from the parser, don't ignore the length only to strlen later
* init LEX::server_options only for SERVER commands, not for every statement
* don't put temporary values into a global persistent memroot

but really it's just scratching a surface
This commit is contained in:
Sergei Golubchik
2014-11-16 13:12:58 +01:00
parent a50ddebb5c
commit 97a913e31c
8 changed files with 113 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sql/sql_parse.cc
View File

@ -5481,8 +5481,8 @@ create_sp_error:
if ((error= create_server(thd, &lex->server_options)))
{
DBUG_PRINT("info", ("problem creating server <%s>",
lex->server_options.server_name));
my_error(error, MYF(0), lex->server_options.server_name);
lex->server_options.server_name.str));
my_error(error, MYF(0), lex->server_options.server_name.str);
break;
}
my_ok(thd, 1);
@ -5500,8 +5500,8 @@ create_sp_error:
if ((error= alter_server(thd, &lex->server_options)))
{
DBUG_PRINT("info", ("problem altering server <%s>",
lex->server_options.server_name));
my_error(error, MYF(0), lex->server_options.server_name);
lex->server_options.server_name.str));
my_error(error, MYF(0), lex->server_options.server_name.str);
break;
}
my_ok(thd, 1);
@ -5521,8 +5521,8 @@ create_sp_error:
if (! lex->check_exists && err_code == ER_FOREIGN_SERVER_DOESNT_EXIST)
{
DBUG_PRINT("info", ("problem dropping server %s",
lex->server_options.server_name));
my_error(err_code, MYF(0), lex->server_options.server_name);
lex->server_options.server_name.str));
my_error(err_code, MYF(0), lex->server_options.server_name.str);
}
else
{