database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-22203: WSREP_ON is unnecessarily expensive to evaluate

Browse Source 
Replaced WSREP_ON macro by single global variable WSREP_ON
that is then updated at server statup and on wsrep_on and
wsrep_provider update functions.
This commit is contained in:
Jan Lindström
2020-04-21 13:46:05 +03:00
parent 9398c3dfa5
commit 93475aff8d
19 changed files with 89 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sql/rpl_record.cc
View File

@ -329,22 +329,6 @@ unpack_row(rpl_group_info *rgi,
(int) (pack_ptr - old_pack_ptr)));
if (!pack_ptr)
{
#ifdef WITH_WSREP
if (WSREP_ON)
{
/*
Debug message to troubleshoot bug:
https://mariadb.atlassian.net/browse/MDEV-4404
Galera Node throws "Could not read field" error and drops out of cluster
*/
WSREP_WARN("ROW event unpack field: %s metadata: 0x%x;"
" conv_table %p conv_field %p table %s"
" row_end: %p",
f->field_name.str, metadata, conv_table, conv_field,
(table_found) ? "found" : "not found", row_end
);
}
#endif /* WITH_WSREP */
rgi->rli->report(ERROR_LEVEL, ER_SLAVE_CORRUPT_EVENT,
rgi->gtid_info(),
"Could not read field '%s' of table '%s.%s'",