database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Backport of:

Browse Source 
------------------------------------------------------------
revno: 3559
committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
branch nick: mysql-pe
timestamp: Fri 2009-08-28 15:23:16 -0300
message:
Break down a large and obnoxious "if" statement. Multiple "if" statements
makes it easy to understand and follow the code (specially in a debugger).

sql/sql_base.cc:
  Break down a large and obnoxious "if" statement. Multiple "if" statements
  makes it easy to understand and follow the code (specially in a debugger).
This commit is contained in:
Konstantin Osipov
2009-11-24 21:55:16 +03:00
parent 5d16e868c1
commit 932a2751a4
1 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
sql/sql_base.cc
View File

@ -1680,20 +1680,42 @@ TABLE_LIST* unique_table(THD *thd, TABLE_LIST *table, TABLE_LIST *table_list,
DBUG_PRINT("info", ("real table: %s.%s", d_name, t_name)); DBUG_PRINT("info", ("real table: %s.%s", d_name, t_name));
for (;;) for (;;)
{ {
if (((! (res= find_table_in_global_list(table_list, d_name, t_name))) && /*
(! (res= mysql_lock_have_duplicate(thd, table, table_list)))) || Table is unique if it is present only once in the global list
((!res->table || res->table != table->table) && of tables and once in the list of table locks.
(!check_alias || !(lower_case_table_names ? */
my_strcasecmp(files_charset_info, t_alias, res->alias) : if (! (res= find_table_in_global_list(table_list, d_name, t_name)) &&
strcmp(t_alias, res->alias))) && ! (res= mysql_lock_have_duplicate(thd, table, table_list)))
res->select_lex && !res->select_lex->exclude_from_table_unique_test &&
!res->prelocking_placeholder))
break; break;
/* Skip if same underlying table. */
if (res->table && (res->table == table->table))
goto next;
/* Skip if table alias does not match. */
if (check_alias)
{
if (lower_case_table_names ?
my_strcasecmp(files_charset_info, t_alias, res->alias) :
strcmp(t_alias, res->alias))
goto next;
}
/*
Skip if marked to be excluded (could be a derived table) or if
entry is a prelocking placeholder.
*/
if (res->select_lex &&
!res->select_lex->exclude_from_table_unique_test &&
!res->prelocking_placeholder)
break;
/* /*
If we found entry of this table or table of SELECT which already If we found entry of this table or table of SELECT which already
processed in derived table or top select of multi-update/multi-delete processed in derived table or top select of multi-update/multi-delete
(exclude_from_table_unique_test) or prelocking placeholder. (exclude_from_table_unique_test) or prelocking placeholder.
*/ */
next:
table_list= res->next_global; table_list= res->next_global;
DBUG_PRINT("info", DBUG_PRINT("info",
("found same copy of table or table which we should skip")); ("found same copy of table or table which we should skip"));