database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

BUG#19122: Need to close handlers before drop/rename phase

Browse Source 
Fixed comments
This commit is contained in:
mikael@c-0409e253.1238-1-64736c10.cust.bredbandsbolaget.se
2006-06-12 17:37:32 -04:00
parent 30817b8900
commit 92dec44ef9
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
sql/sql_partition.cc
View File

@ -5742,7 +5742,8 @@ uint fast_alter_partition_table(THD *thd, TABLE *table,
be no new threads accessing the table. They will be hanging on the be no new threads accessing the table. They will be hanging on the
name lock. name lock.
5) Close all tables that have already been opened but didn't stumble on 5) Close all tables that have already been opened but didn't stumble on
the abort locked previously. the abort locked previously. This is done as part of the
get_name_lock call.
6) We are now ready to release all locks we got in this thread. 6) We are now ready to release all locks we got in this thread.
7) Write the bin log 7) Write the bin log
Unfortunately the writing of the binlog is not synchronised with Unfortunately the writing of the binlog is not synchronised with
@ -5817,15 +5818,24 @@ uint fast_alter_partition_table(THD *thd, TABLE *table,
3) Lock all partitions in TL_WRITE_ONLY to ensure that no users 3) Lock all partitions in TL_WRITE_ONLY to ensure that no users
are still using the old partitioning scheme. Wait until all are still using the old partitioning scheme. Wait until all
ongoing users have completed before progressing. ongoing users have completed before progressing.
4) Write binlog 4) Get a name lock on the table. This ensures that we can release all
5) Now the change is completed except for the installation of the locks on the table and since no one can open the table, there can
be no new threads accessing the table. They will be hanging on the
name lock.
5) Close all tables that have already been opened but didn't stumble on
the abort locked previously. This is done as part of the
get_name_lock call.
6) Close all table handlers and unlock all handlers but retain name lock
7) Write binlog
8) Now the change is completed except for the installation of the
new frm file. We thus write an action in the log to change to new frm file. We thus write an action in the log to change to
the shadow frm file the shadow frm file
6) Install the new frm file of the table where the partitions are 9) Install the new frm file of the table where the partitions are
added to the table. added to the table.
7) Wait until all accesses using the old frm file has completed 10)Wait until all accesses using the old frm file has completed
8) Remove entries from ddl log 11)Remove entries from ddl log
9) Complete query 12)Release name lock
13)Complete query
*/ */
if (write_log_add_change_partition(lpt) || if (write_log_add_change_partition(lpt) ||
ERROR_INJECT_CRASH("crash_add_partition_1") || ERROR_INJECT_CRASH("crash_add_partition_1") ||
@ -5905,7 +5915,7 @@ uint fast_alter_partition_table(THD *thd, TABLE *table,
7) Close all tables opened but not yet locked, after this call we are 7) Close all tables opened but not yet locked, after this call we are
certain that no other thread is in the lock wait queue or has certain that no other thread is in the lock wait queue or has
opened the table. The name lock will ensure that they are blocked opened the table. The name lock will ensure that they are blocked
on the open call. on the open call. This is achieved also by get_name_lock call.
8) Close all partitions opened by this thread, but retain name lock. 8) Close all partitions opened by this thread, but retain name lock.
9) Write bin log 9) Write bin log
10) Prepare handlers for rename and delete of partitions 10) Prepare handlers for rename and delete of partitions