database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

cleanup: comments

Browse Source
This commit is contained in:
Sergei Golubchik
2020-04-12 22:11:22 +02:00
parent fcd84da5f1
commit 91e79dff54
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sql/sql_insert.cc
View File

@ -1996,8 +1996,6 @@ int write_record(THD *thd, TABLE *table, COPY_INFO *info, select_result *sink)
tables which have ON UPDATE but have no ON DELETE triggers, tables which have ON UPDATE but have no ON DELETE triggers,
we just should not expose this fact to users by invoking we just should not expose this fact to users by invoking
ON UPDATE triggers. ON UPDATE triggers.
For system versioning wa also use path through delete since we would
save nothing through this cheating.
*/ */
if (last_uniq_key(table,key_nr) && if (last_uniq_key(table,key_nr) &&
!table->file->referenced_by_foreign_key() && !table->file->referenced_by_foreign_key() &&

2
sql/sql_update.cc
View File

@ -2036,7 +2036,7 @@ int multi_update::prepare(List<Item> &not_used_values,
DBUG_RETURN(1); DBUG_RETURN(1);
/* /*
Save tables beeing updated in update_tables Save tables being updated in update_tables
update_table->shared is position for table update_table->shared is position for table
Don't use key read on tables that are updated Don't use key read on tables that are updated
*/ */

8
storage/myisam/myisamdef.h
View File

@ -234,11 +234,11 @@ typedef struct st_mi_isam_share
struct st_myisam_info struct st_myisam_info
{ {
MYISAM_SHARE *s; /* Shared between open:s */ MYISAM_SHARE *s; /* Shared between opens */
MI_STATUS_INFO *state, save_state; MI_STATUS_INFO *state, save_state;
MI_BLOB *blobs; /* Pointer to blobs */ MI_BLOB *blobs; /* Pointer to blobs */
MI_BIT_BUFF bit_buff; MI_BIT_BUFF bit_buff;
/* accumulate indexfile changes between write's */ /* accumulate indexfile changes between writes */
TREE *bulk_insert; TREE *bulk_insert;
DYNAMIC_ARRAY *ft1_to_ft2; /* used only in ft1->ft2 conversion */ DYNAMIC_ARRAY *ft1_to_ft2; /* used only in ft1->ft2 conversion */
MEM_ROOT ft_memroot; /* used by the parser */ MEM_ROOT ft_memroot; /* used by the parser */
@ -256,7 +256,7 @@ struct st_myisam_info
uint32 int_keytree_version; /* -""- */ uint32 int_keytree_version; /* -""- */
int (*read_record)(struct st_myisam_info*, my_off_t, uchar*); int (*read_record)(struct st_myisam_info*, my_off_t, uchar*);
invalidator_by_filename invalidator; /* query cache invalidator */ invalidator_by_filename invalidator; /* query cache invalidator */
ulong this_unique; /* uniq filenumber or thread */ ulong this_unique; /* unique filenumber or thread */
ulong last_unique; /* last unique number */ ulong last_unique; /* last unique number */
ulong this_loop; /* counter for this open */ ulong this_loop; /* counter for this open */
ulong last_loop; /* last used counter */ ulong last_loop; /* last used counter */
@ -269,7 +269,7 @@ struct st_myisam_info
my_off_t dupp_key_pos; my_off_t dupp_key_pos;
ha_checksum checksum; /* Temp storage for row checksum */ ha_checksum checksum; /* Temp storage for row checksum */
/* /*
QQ: the folloing two xxx_length fields should be removed, QQ: the following two xxx_length fields should be removed,
as they are not compatible with parallel repair as they are not compatible with parallel repair
*/ */
ulong packed_length, blob_length; /* Length of found, packed record */ ulong packed_length, blob_length; /* Length of found, packed record */