database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

cleanup: remove redundant check

Browse Source 
it's already checked before the update loop (see check_fields()),
and this condition cannot suddenly become false in the middle
of the statement
This commit is contained in:
Sergei Golubchik
2018-01-11 23:04:49 +01:00
parent 826f615fc9
commit 8ee071a22d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sql/sql_base.cc
View File

@ -8115,11 +8115,8 @@ fill_record(THD *thd, TABLE *table_arg, List<Item> &fields, List<Item> &values,
thus we safely can take table from the first field.
*/
fld= (Item_field*)f++;
if (!(field= fld->field_for_view_update()))
{
my_error(ER_NONUPDATEABLE_COLUMN, MYF(0), fld->name.str);
goto err;
}
field= fld->field_for_view_update();
DBUG_ASSERT(field);
DBUG_ASSERT(field->field->table == table_arg);
table_arg->auto_increment_field_not_null= FALSE;
f.rewind();