database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

post-review changes 1

Browse Source 
include/my_time.h:
  remove duplicate defines.
  cast to ulonglong to avoid overflow
sql/field.cc:
  perform sign extension when reading packed TIME values
sql/item_cmpfunc.cc:
  when converting a string to a date for the purpose of comparing it with another date,
  we should ignore strict sql mode.
sql/item_timefunc.cc:
  better error message
sql/item_timefunc.h:
  limit decimals appropriately
sql/share/errmsg.txt:
  don't refer to an object as a "column" in error messages that are used not only for columns.
This commit is contained in:
Sergei Golubchik
2011-05-19 19:01:46 +02:00
parent 5346cb8d27
commit 8ddcd0cda8
32 changed files with 378 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sql/field.h
View File

@ -1234,7 +1234,7 @@ public:
dec(dec_arg)
{
DBUG_ASSERT(dec);
DBUG_ASSERT(dec <= MAX_SEC_PART_DIGITS);
DBUG_ASSERT(dec <= TIME_SECOND_PART_DIGITS);
}
void sql_type(String &str) const;
long get_timestamp(ulong *sec_part) const;
@ -1407,7 +1407,7 @@ public:
dec(dec_arg)
{
DBUG_ASSERT(dec);
DBUG_ASSERT(dec <= MAX_SEC_PART_DIGITS);
DBUG_ASSERT(dec <= TIME_SECOND_PART_DIGITS);
}
enum ha_base_keytype key_type() const { return HA_KEYTYPE_BINARY; }
uint decimals() const { return dec; }
@ -1476,7 +1476,7 @@ public:
field_name_arg, cs), dec(dec_arg)
{
DBUG_ASSERT(dec);
DBUG_ASSERT(dec <= MAX_SEC_PART_DIGITS);
DBUG_ASSERT(dec <= TIME_SECOND_PART_DIGITS);
}
enum ha_base_keytype key_type() const { return HA_KEYTYPE_BINARY; }
int store_decimal(const my_decimal *d);