database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.1

Browse Source 
into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.1-lex-string
This commit is contained in:
jani@ua141d10.elisa.omakaista.fi
2006-10-17 19:54:44 +03:00
parent e6be42e1c9 02f29377fd
commit 8dd0b2d0ae
24 changed files with 575 additions and 213 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD/SETUP.sh
View File

@@ -183,7 +183,7 @@ fi
# (http://samba.org/ccache) is installed, use it. # (http://samba.org/ccache) is installed, use it.
# We use 'grep' and hope 'grep' will work as expected # We use 'grep' and hope 'grep' will work as expected
# (returns 0 if finds lines) # (returns 0 if finds lines)
if ccache -V > /dev/null 2>&1 if ccache -V > /dev/null 2>&1 && test "$CCACHE_GCOV_VERSION_ENABLED" == "1"
then then
echo "$CC" | grep "ccache" > /dev/null || CC="ccache $CC" echo "$CC" | grep "ccache" > /dev/null || CC="ccache $CC"
echo "$CXX" | grep "ccache" > /dev/null || CXX="ccache $CXX" echo "$CXX" | grep "ccache" > /dev/null || CXX="ccache $CXX"

19
BUILD/compile-pentium-gcov
View File

@@ -1,12 +1,21 @@
#! /bin/sh #! /bin/sh
# Need to disable ccache, or we loose the gcov-needed compiler output files.
CCACHE_GCOV_VERSION_ENABLED=0
if ccache -V > /dev/null 2>&1
then
CCACHE_VER=`ccache -V | head -1 | sed s/"ccache version "//`
if test "$CCACHE_VER" == "2.4-gcov"
then
CCACHE_GCOV_VERSION_ENABLED=1
fi
fi
export CCACHE_GCOV_VERSION_ENABLED
path=`dirname $0` path=`dirname $0`
. "$path/SETUP.sh" . "$path/SETUP.sh"
# Need to disable ccache, or we loose the gcov-needed compiler output files.
CCACHE_DISABLE=1
export CCACHE_DISABLE
# GCC4 needs -fprofile-arcs -ftest-coverage on the linker command line (as well # GCC4 needs -fprofile-arcs -ftest-coverage on the linker command line (as well
# as on the compiler command line), and this requires setting LDFLAGS for BDB. # as on the compiler command line), and this requires setting LDFLAGS for BDB.
export LDFLAGS="-fprofile-arcs -ftest-coverage" export LDFLAGS="-fprofile-arcs -ftest-coverage"
@@ -14,7 +23,7 @@ export LDFLAGS="-fprofile-arcs -ftest-coverage"
# The -fprofile-arcs and -ftest-coverage options cause GCC to instrument the # The -fprofile-arcs and -ftest-coverage options cause GCC to instrument the
# code with profiling information used by gcov. # code with profiling information used by gcov.
# the -DDISABLE_TAO_ASM is needed to avoid build failures in Yassl. # the -DDISABLE_TAO_ASM is needed to avoid build failures in Yassl.
extra_flags="$pentium_cflags -fprofile-arcs -ftest-coverage -DDISABLE_TAO_ASM -DHAVE_MUTEX_THREAD_ONLY" extra_flags="$pentium_cflags -fprofile-arcs -ftest-coverage -DDISABLE_TAO_ASM -DHAVE_MUTEX_THREAD_ONLY $debug_extra_flags"
extra_configs="$pentium_configs $debug_configs --disable-shared $static_link" extra_configs="$pentium_configs $debug_configs --disable-shared $static_link"
extra_configs="$extra_configs $max_configs" extra_configs="$extra_configs $max_configs"

16
mysql-test/r/create.result
View File

@@ -820,3 +820,19 @@ SELECT * from t2;
a b a b
1 1 1 1
drop table t1,t2; drop table t1,t2;
CREATE DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
DROP DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
RENAME DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa TO a;
ERROR 42000: Unknown database 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
RENAME DATABASE mysqltest TO aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
create database mysqltest;
RENAME DATABASE mysqltest TO aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
drop database mysqltest;
USE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
SHOW CREATE DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'

4
mysql-test/r/ctype_create.result
View File

@@ -72,3 +72,7 @@ mysqltest2 CREATE DATABASE `mysqltest2` /*!40100 DEFAULT CHARACTER SET latin2 */
drop database mysqltest2; drop database mysqltest2;
ALTER DATABASE DEFAULT CHARACTER SET latin2; ALTER DATABASE DEFAULT CHARACTER SET latin2;
ERROR 3D000: No database selected ERROR 3D000: No database selected
ALTER DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa DEFAULT CHARACTER SET latin2;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
ALTER DATABASE `` DEFAULT CHARACTER SET latin2;
ERROR 42000: Incorrect database name ''

6
mysql-test/r/events.result
View File

@@ -394,4 +394,10 @@ create trigger t1_ai after insert on t1 for each row show create event e1;
ERROR 0A000: Not allowed to return a result set from a trigger ERROR 0A000: Not allowed to return a result set from a trigger
drop table t1; drop table t1;
drop event e1; drop event e1;
SHOW EVENTS FROM aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
ERROR 42000: Incorrect database name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
SHOW EVENTS FROM ``;
ERROR 42000: Incorrect database name ''
SHOW EVENTS FROM `events\\test`;
Db Name Definer Type Execute at Interval value Interval field Starts Ends Status
drop database events_test; drop database events_test;

1
mysql-test/t/alter_table.test
View File

@@ -535,4 +535,3 @@ INSERT INTO `@0023sql1` VALUES (2);
SHOW CREATE TABLE `#sql2`; SHOW CREATE TABLE `#sql2`;
SHOW CREATE TABLE `@0023sql1`; SHOW CREATE TABLE `@0023sql1`;
DROP TABLE `#sql2`, `@0023sql1`; DROP TABLE `#sql2`, `@0023sql1`;

21
mysql-test/t/create.test
View File

@@ -711,3 +711,24 @@ TRUNCATE table t2;
INSERT INTO t2 select * from t1; INSERT INTO t2 select * from t1;
SELECT * from t2; SELECT * from t2;
drop table t1,t2; drop table t1,t2;
#
# Test incorrect database names
#
--error 1102
CREATE DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
--error 1102
DROP DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
--error 1049
RENAME DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa TO a;
--error 1102
RENAME DATABASE mysqltest TO aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
create database mysqltest;
--error 1102
RENAME DATABASE mysqltest TO aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
drop database mysqltest;
--error 1102
USE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
--error 1102
SHOW CREATE DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;

5
mysql-test/t/ctype_create.test
View File

@@ -100,3 +100,8 @@ drop database mysqltest2;
ALTER DATABASE DEFAULT CHARACTER SET latin2; ALTER DATABASE DEFAULT CHARACTER SET latin2;
# End of 4.1 tests # End of 4.1 tests
--error 1102
ALTER DATABASE aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa DEFAULT CHARACTER SET latin2;
--error 1102
ALTER DATABASE `` DEFAULT CHARACTER SET latin2;

11
mysql-test/t/events.test
View File

@@ -395,4 +395,15 @@ drop event e1;
##show processlist; ##show processlist;
##select count(*) from mysql.event; ##select count(*) from mysql.event;
#
# Test wrong syntax
#
--error 1102
SHOW EVENTS FROM aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
--error 1102
SHOW EVENTS FROM ``;
SHOW EVENTS FROM `events\\test`;
drop database events_test; drop database events_test;

5
sql/item_timefunc.cc
View File

@@ -1249,6 +1249,9 @@ bool get_interval_value(Item *args,interval_type int_type,
interval->second= array[0]; interval->second= array[0];
interval->second_part= array[1]; interval->second_part= array[1];
break; break;
case INTERVAL_LAST: /* purecov: begin deadcode */
DBUG_ASSERT(0);
break; /* purecov: end */
} }
return 0; return 0;
} }
@@ -2088,6 +2091,7 @@ void Item_extract::fix_length_and_dec()
case INTERVAL_HOUR_MICROSECOND: max_length=13; date_value=0; break; case INTERVAL_HOUR_MICROSECOND: max_length=13; date_value=0; break;
case INTERVAL_MINUTE_MICROSECOND: max_length=11; date_value=0; break; case INTERVAL_MINUTE_MICROSECOND: max_length=11; date_value=0; break;
case INTERVAL_SECOND_MICROSECOND: max_length=9; date_value=0; break; case INTERVAL_SECOND_MICROSECOND: max_length=9; date_value=0; break;
case INTERVAL_LAST: DBUG_ASSERT(0); break; /* purecov: deadcode */
} }
} }
@@ -2157,6 +2161,7 @@ longlong Item_extract::val_int()
ltime.second_part)*neg; ltime.second_part)*neg;
case INTERVAL_SECOND_MICROSECOND: return ((longlong)ltime.second*1000000L+ case INTERVAL_SECOND_MICROSECOND: return ((longlong)ltime.second*1000000L+
ltime.second_part)*neg; ltime.second_part)*neg;
case INTERVAL_LAST: DBUG_ASSERT(0); break; /* purecov: deadcode */
} }
return 0; // Impossible return 0; // Impossible
} }

2
sql/mysql_priv.h
View File

@@ -1814,7 +1814,7 @@ int create_frm(THD *thd, const char *name, const char *db, const char *table,
HA_CREATE_INFO *create_info, uint keys); HA_CREATE_INFO *create_info, uint keys);
void update_create_info_from_table(HA_CREATE_INFO *info, TABLE *form); void update_create_info_from_table(HA_CREATE_INFO *info, TABLE *form);
int rename_file_ext(const char * from,const char * to,const char * ext); int rename_file_ext(const char * from,const char * to,const char * ext);
bool check_db_name(char *db); bool check_db_name(LEX_STRING *db);
bool check_column_name(const char *name); bool check_column_name(const char *name);
bool check_table_name(const char *name, uint length); bool check_table_name(const char *name, uint length);
char *get_field(MEM_ROOT *mem, Field *field); char *get_field(MEM_ROOT *mem, Field *field);

3
sql/mysqld.cc
View File

@@ -5316,7 +5316,8 @@ master-ssl",
(gptr*) &locked_in_memory, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0}, (gptr*) &locked_in_memory, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
{"merge", OPT_MERGE, "Enable Merge storage engine. Disable with \ {"merge", OPT_MERGE, "Enable Merge storage engine. Disable with \
--skip-merge.", --skip-merge.",
(gptr*) &opt_merge, (gptr*) &opt_merge, 0, GET_BOOL, NO_ARG, 1, 0, 0, 0, 0}, (gptr*) &opt_merge, (gptr*) &opt_merge, 0, GET_BOOL, NO_ARG, 1, 0, 0, 0, 0,
0},
{"myisam-recover", OPT_MYISAM_RECOVER, {"myisam-recover", OPT_MYISAM_RECOVER,
"Syntax: myisam-recover[=option[,option...]], where option can be DEFAULT, BACKUP, FORCE or QUICK.", "Syntax: myisam-recover[=option[,option...]], where option can be DEFAULT, BACKUP, FORCE or QUICK.",
(gptr*) &myisam_recover_options_str, (gptr*) &myisam_recover_options_str, 0, (gptr*) &myisam_recover_options_str, (gptr*) &myisam_recover_options_str, 0,

7
sql/sql_class.h
View File

@@ -420,6 +420,12 @@ public:
{ return strdup_root(mem_root,str); } { return strdup_root(mem_root,str); }
inline char *strmake(const char *str, uint size) inline char *strmake(const char *str, uint size)
{ return strmake_root(mem_root,str,size); } { return strmake_root(mem_root,str,size); }
inline bool LEX_STRING_make(LEX_STRING *lex_str, const char *str, uint size)
{
return ((lex_str->str=
strmake_root(mem_root, str, (lex_str->length= size)))) == 0;
}
inline char *memdup(const char *str, uint size) inline char *memdup(const char *str, uint size)
{ return memdup_root(mem_root,str,size); } { return memdup_root(mem_root,str,size); }
inline char *memdup_w_gap(const char *str, uint size, uint gap) inline char *memdup_w_gap(const char *str, uint size, uint gap)
@@ -1618,7 +1624,6 @@ public:
return TRUE; return TRUE;
} }
*p_db= strmake(db, db_length); *p_db= strmake(db, db_length);
if (p_db_length)
*p_db_length= db_length; *p_db_length= db_length;
return FALSE; return FALSE;
} }

46
sql/sql_db.cc
View File

@@ -1297,8 +1297,8 @@ err:
bool mysql_change_db(THD *thd, const char *name, bool no_access_check) bool mysql_change_db(THD *thd, const char *name, bool no_access_check)
{ {
int path_length, db_length; int path_length;
char *db_name; LEX_STRING db_name;
bool system_db= 0; bool system_db= 0;
#ifndef NO_EMBEDDED_ACCESS_CHECKS #ifndef NO_EMBEDDED_ACCESS_CHECKS
ulong db_access; ulong db_access;
@@ -1318,25 +1318,26 @@ bool mysql_change_db(THD *thd, const char *name, bool no_access_check)
/* Called from SP to restore the original database, which was NULL */ /* Called from SP to restore the original database, which was NULL */
DBUG_ASSERT(no_access_check); DBUG_ASSERT(no_access_check);
system_db= 1; system_db= 1;
db_name= NULL; db_name.str= NULL;
db_length= 0; db_name.length= 0;
goto end; goto end;
} }
/* /*
Now we need to make a copy because check_db_name requires a Now we need to make a copy because check_db_name requires a
non-constant argument. TODO: fix check_db_name. non-constant argument. TODO: fix check_db_name.
*/ */
if ((db_name= my_strdup(name, MYF(MY_WME))) == NULL) if ((db_name.str= my_strdup(name, MYF(MY_WME))) == NULL)
DBUG_RETURN(1); /* the error is set */ DBUG_RETURN(1); /* the error is set */
db_length= strlen(db_name); db_name.length= strlen(db_name.str);
if (check_db_name(db_name)) if (check_db_name(&db_name))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), db_name); my_error(ER_WRONG_DB_NAME, MYF(0), db_name.str);
my_free(db_name, MYF(0)); my_free(db_name.str, MYF(0));
DBUG_RETURN(1); DBUG_RETURN(1);
} }
DBUG_PRINT("info",("Use database: %s", db_name)); DBUG_PRINT("info",("Use database: %s", db_name.str));
if (!my_strcasecmp(system_charset_info, db_name, information_schema_name.str)) if (!my_strcasecmp(system_charset_info, db_name.str,
information_schema_name.str))
{ {
system_db= 1; system_db= 1;
#ifndef NO_EMBEDDED_ACCESS_CHECKS #ifndef NO_EMBEDDED_ACCESS_CHECKS
@@ -1351,34 +1352,35 @@ bool mysql_change_db(THD *thd, const char *name, bool no_access_check)
if (test_all_bits(sctx->master_access, DB_ACLS)) if (test_all_bits(sctx->master_access, DB_ACLS))
db_access=DB_ACLS; db_access=DB_ACLS;
else else
db_access= (acl_get(sctx->host, sctx->ip, sctx->priv_user, db_name, 0) | db_access= (acl_get(sctx->host, sctx->ip, sctx->priv_user,
db_name.str, 0) |
sctx->master_access); sctx->master_access);
if (!(db_access & DB_ACLS) && (!grant_option || if (!(db_access & DB_ACLS) && (!grant_option ||
check_grant_db(thd,db_name))) check_grant_db(thd, db_name.str)))
{ {
my_error(ER_DBACCESS_DENIED_ERROR, MYF(0), my_error(ER_DBACCESS_DENIED_ERROR, MYF(0),
sctx->priv_user, sctx->priv_user,
sctx->priv_host, sctx->priv_host,
db_name); db_name.str);
general_log_print(thd, COM_INIT_DB, ER(ER_DBACCESS_DENIED_ERROR), general_log_print(thd, COM_INIT_DB, ER(ER_DBACCESS_DENIED_ERROR),
sctx->priv_user, sctx->priv_host, db_name); sctx->priv_user, sctx->priv_host, db_name.str);
my_free(db_name,MYF(0)); my_free(db_name.str, MYF(0));
DBUG_RETURN(1); DBUG_RETURN(1);
} }
} }
#endif #endif
if (check_db_dir_existence(db_name)) if (check_db_dir_existence(db_name.str))
{ {
my_error(ER_BAD_DB_ERROR, MYF(0), db_name); my_error(ER_BAD_DB_ERROR, MYF(0), db_name.str);
my_free(db_name, MYF(0)); my_free(db_name.str, MYF(0));
DBUG_RETURN(1); DBUG_RETURN(1);
} }
end: end:
x_free(thd->db); x_free(thd->db);
DBUG_ASSERT(db_name == NULL || db_name[0] != '\0'); DBUG_ASSERT(db_name.str == NULL || db_name.str[0] != '\0');
thd->reset_db(db_name, db_length); // THD::~THD will free this thd->reset_db(db_name.str, db_name.length); // THD::~THD will free this
#ifndef NO_EMBEDDED_ACCESS_CHECKS #ifndef NO_EMBEDDED_ACCESS_CHECKS
if (!no_access_check) if (!no_access_check)
sctx->db_access= db_access; sctx->db_access= db_access;
@@ -1392,7 +1394,7 @@ end:
{ {
HA_CREATE_INFO create; HA_CREATE_INFO create;
load_db_opt_by_name(thd, db_name, &create); load_db_opt_by_name(thd, db_name.str, &create);
thd->db_charset= create.default_table_charset ? thd->db_charset= create.default_table_charset ?
create.default_table_charset : create.default_table_charset :

3
sql/sql_lex.cc
View File

@@ -177,7 +177,8 @@ void lex_start(THD *thd, const uchar *buf, uint length)
lex->reset_query_tables_list(FALSE); lex->reset_query_tables_list(FALSE);
lex->expr_allows_subselect= TRUE; lex->expr_allows_subselect= TRUE;
lex->name= 0; lex->name.str= 0;
lex->name.length= 0;
lex->event_parse_data= NULL; lex->event_parse_data= NULL;
lex->nest_level=0 ; lex->nest_level=0 ;

3
sql/sql_lex.h
View File

@@ -884,7 +884,8 @@ typedef struct st_lex : public Query_tables_list
/* The values of tok_start/tok_end as they were one call of MYSQLlex before */ /* The values of tok_start/tok_end as they were one call of MYSQLlex before */
const uchar *tok_start_prev, *tok_end_prev; const uchar *tok_start_prev, *tok_end_prev;
char *length,*dec,*change,*name; char *length,*dec,*change;
LEX_STRING name;
Table_ident *like_name; Table_ident *like_name;
char *help_arg; char *help_arg;
char *backup_dir; /* For RESTORE/BACKUP */ char *backup_dir; /* For RESTORE/BACKUP */

259
sql/sql_parse.cc
View File

@@ -1055,11 +1055,14 @@ static int check_connection(THD *thd)
Old clients send null-terminated string as password; new clients send Old clients send null-terminated string as password; new clients send
the size (1 byte) + string (not null-terminated). Hence in case of empty the size (1 byte) + string (not null-terminated). Hence in case of empty
password both send '\0'. password both send '\0'.
This strlen() can't be easily deleted without changing protocol.
*/ */
uint passwd_len= thd->client_capabilities & CLIENT_SECURE_CONNECTION ? uint passwd_len= thd->client_capabilities & CLIENT_SECURE_CONNECTION ?
*passwd++ : strlen(passwd); *passwd++ : strlen(passwd);
db= thd->client_capabilities & CLIENT_CONNECT_WITH_DB ? db= thd->client_capabilities & CLIENT_CONNECT_WITH_DB ?
db + passwd_len + 1 : 0; db + passwd_len + 1 : 0;
/* strlen() can't be easily deleted without changing protocol */
uint db_len= db ? strlen(db) : 0; uint db_len= db ? strlen(db) : 0;
if (passwd + passwd_len + db_len > (char *)net->read_pos + pkt_len) if (passwd + passwd_len + db_len > (char *)net->read_pos + pkt_len)
@@ -1314,6 +1317,7 @@ pthread_handler_t handle_bootstrap(void *arg)
thd->init_for_queries(); thd->init_for_queries();
while (fgets(buff, thd->net.max_packet, file)) while (fgets(buff, thd->net.max_packet, file))
{ {
/* strlen() can't be deleted because fgets() doesn't return length */
ulong length= (ulong) strlen(buff); ulong length= (ulong) strlen(buff);
while (buff[length-1] != '\n' && !feof(file)) while (buff[length-1] != '\n' && !feof(file))
{ {
@@ -1321,6 +1325,7 @@ pthread_handler_t handle_bootstrap(void *arg)
We got only a part of the current string. Will try to increase We got only a part of the current string. Will try to increase
net buffer then read the rest of the current string. net buffer then read the rest of the current string.
*/ */
/* purecov: begin tested */
if (net_realloc(&(thd->net), 2 * thd->net.max_packet)) if (net_realloc(&(thd->net), 2 * thd->net.max_packet))
{ {
net_send_error(thd, ER_NET_PACKET_TOO_LARGE, NullS); net_send_error(thd, ER_NET_PACKET_TOO_LARGE, NullS);
@@ -1330,9 +1335,10 @@ pthread_handler_t handle_bootstrap(void *arg)
buff= (char*) thd->net.buff; buff= (char*) thd->net.buff;
fgets(buff + length, thd->net.max_packet - length, file); fgets(buff + length, thd->net.max_packet - length, file);
length+= (ulong) strlen(buff + length); length+= (ulong) strlen(buff + length);
/* purecov: end */
} }
if (thd->is_fatal_error) if (thd->is_fatal_error)
break; break; /* purecov: inspected */
while (length && (my_isspace(thd->charset(), buff[length-1]) || while (length && (my_isspace(thd->charset(), buff[length-1]) ||
buff[length-1] == ';')) buff[length-1] == ';'))
@@ -1420,24 +1426,30 @@ void cleanup_items(Item *item)
*/ */
static static
int mysql_table_dump(THD* thd, char* db, char* tbl_name) int mysql_table_dump(THD *thd, LEX_STRING *db, char *tbl_name)
{ {
TABLE* table; TABLE* table;
TABLE_LIST* table_list; TABLE_LIST* table_list;
int error = 0; int error = 0;
DBUG_ENTER("mysql_table_dump"); DBUG_ENTER("mysql_table_dump");
db = (db && db[0]) ? db : thd->db; if (db->length == 0)
{
db->str= thd->db; /* purecov: inspected */
db->length= thd->db_length; /* purecov: inspected */
}
if (!(table_list = (TABLE_LIST*) thd->calloc(sizeof(TABLE_LIST)))) if (!(table_list = (TABLE_LIST*) thd->calloc(sizeof(TABLE_LIST))))
DBUG_RETURN(1); // out of memory DBUG_RETURN(1); // out of memory
table_list->db= db; table_list->db= db->str;
table_list->table_name= table_list->alias= tbl_name; table_list->table_name= table_list->alias= tbl_name;
table_list->lock_type= TL_READ_NO_INSERT; table_list->lock_type= TL_READ_NO_INSERT;
table_list->prev_global= &table_list; // can be removed after merge with 4.1 table_list->prev_global= &table_list; // can be removed after merge with 4.1
if (!db || check_db_name(db)) if (check_db_name(db))
{ {
my_error(ER_WRONG_DB_NAME ,MYF(0), db ? db : "NULL"); /* purecov: begin inspected */
my_error(ER_WRONG_DB_NAME ,MYF(0), db->str ? db->str : "NULL");
goto err; goto err;
/* purecov: end */
} }
if (lower_case_table_names) if (lower_case_table_names)
my_casedn_str(files_charset_info, tbl_name); my_casedn_str(files_charset_info, tbl_name);
@@ -1666,7 +1678,7 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
statistic_increment(thd->status_var.com_stat[SQLCOM_CHANGE_DB], statistic_increment(thd->status_var.com_stat[SQLCOM_CHANGE_DB],
&LOCK_status); &LOCK_status);
thd->convert_string(&tmp, system_charset_info, thd->convert_string(&tmp, system_charset_info,
packet, strlen(packet), thd->charset()); packet, packet_length-1, thd->charset());
if (!mysql_change_db(thd, tmp.str, FALSE)) if (!mysql_change_db(thd, tmp.str, FALSE))
{ {
general_log_print(thd, command, "%s",thd->db); general_log_print(thd, command, "%s",thd->db);
@@ -1684,7 +1696,8 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
#endif #endif
case COM_TABLE_DUMP: case COM_TABLE_DUMP:
{ {
char *db, *tbl_name; char *tbl_name;
LEX_STRING db;
uint db_len= *(uchar*) packet; uint db_len= *(uchar*) packet;
if (db_len >= packet_length || db_len > NAME_LEN) if (db_len >= packet_length || db_len > NAME_LEN)
{ {
@@ -1700,25 +1713,27 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
statistic_increment(thd->status_var.com_other, &LOCK_status); statistic_increment(thd->status_var.com_other, &LOCK_status);
thd->enable_slow_log= opt_log_slow_admin_statements; thd->enable_slow_log= opt_log_slow_admin_statements;
db= thd->alloc(db_len + tbl_len + 2); db.str= thd->alloc(db_len + tbl_len + 2);
if (!db) db.length= db_len;
if (!db.str)
{ {
my_message(ER_OUT_OF_RESOURCES, ER(ER_OUT_OF_RESOURCES), MYF(0)); my_message(ER_OUT_OF_RESOURCES, ER(ER_OUT_OF_RESOURCES), MYF(0));
break; break;
} }
tbl_name= strmake(db, packet + 1, db_len)+1; tbl_name= strmake(db.str, packet + 1, db_len)+1;
strmake(tbl_name, packet + db_len + 2, tbl_len); strmake(tbl_name, packet + db_len + 2, tbl_len);
mysql_table_dump(thd, db, tbl_name); mysql_table_dump(thd, &db, tbl_name);
break; break;
} }
case COM_CHANGE_USER: case COM_CHANGE_USER:
{ {
statistic_increment(thd->status_var.com_other, &LOCK_status);
char *user= (char*) packet, *packet_end= packet+ packet_length;
char *passwd= strend(user)+1;
thd->change_user(); thd->change_user();
thd->clear_error(); // if errors from rollback thd->clear_error(); // if errors from rollback
statistic_increment(thd->status_var.com_other, &LOCK_status);
char *user= (char*) packet;
char *passwd= strend(user)+1;
/* /*
Old clients send null-terminated string ('\0' for empty string) for Old clients send null-terminated string ('\0' for empty string) for
password. New clients send the size (1 byte) + string (not null password. New clients send the size (1 byte) + string (not null
@@ -1726,8 +1741,13 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
*/ */
char db_buff[NAME_LEN+1]; // buffer to store db in utf8 char db_buff[NAME_LEN+1]; // buffer to store db in utf8
char *db= passwd; char *db= passwd;
uint passwd_len= thd->client_capabilities & CLIENT_SECURE_CONNECTION ? char *save_db;
*passwd++ : strlen(passwd); uint passwd_len= (thd->client_capabilities & CLIENT_SECURE_CONNECTION ?
*passwd++ : strlen(passwd));
uint dummy_errors, save_db_length, db_length, res;
Security_context save_security_ctx= *thd->security_ctx;
USER_CONN *save_user_connect;
db+= passwd_len + 1; db+= passwd_len + 1;
#ifndef EMBEDDED_LIBRARY #ifndef EMBEDDED_LIBRARY
/* Small check for incoming packet */ /* Small check for incoming packet */
@@ -1738,17 +1758,22 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
} }
#endif #endif
/* Convert database name to utf8 */ /* Convert database name to utf8 */
uint dummy_errors; /*
Handle problem with old bug in client protocol where db had an extra
\0
*/
db_length= (packet_end - db);
if (db_length > 0 && db[db_length-1] == 0)
db_length--;
db_buff[copy_and_convert(db_buff, sizeof(db_buff)-1, db_buff[copy_and_convert(db_buff, sizeof(db_buff)-1,
system_charset_info, db, strlen(db), system_charset_info, db, db_length,
thd->charset(), &dummy_errors)]= 0; thd->charset(), &dummy_errors)]= 0;
db= db_buff; db= db_buff;
/* Save user and privileges */ /* Save user and privileges */
uint save_db_length= thd->db_length; save_db_length= thd->db_length;
char *save_db= thd->db; save_db= thd->db;
Security_context save_security_ctx= *thd->security_ctx; save_user_connect= thd->user_connect;
USER_CONN *save_user_connect= thd->user_connect;
if (!(thd->security_ctx->user= my_strdup(user, MYF(0)))) if (!(thd->security_ctx->user= my_strdup(user, MYF(0))))
{ {
@@ -1759,7 +1784,7 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
/* Clear variables that are allocated */ /* Clear variables that are allocated */
thd->user_connect= 0; thd->user_connect= 0;
int res= check_user(thd, COM_CHANGE_USER, passwd, passwd_len, db, FALSE); res= check_user(thd, COM_CHANGE_USER, passwd, passwd_len, db, FALSE);
if (res) if (res)
{ {
@@ -1869,29 +1894,31 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
break; break;
#else #else
{ {
char *fields, *pend; char *fields, *packet_end= packet + packet_length - 1, *arg_end;
/* Locked closure of all tables */ /* Locked closure of all tables */
TABLE_LIST *locked_tables= NULL; TABLE_LIST *locked_tables= NULL;
TABLE_LIST table_list; TABLE_LIST table_list;
LEX_STRING conv_name; LEX_STRING conv_name;
/* Saved variable value */ /* Saved variable value */
my_bool old_innodb_table_locks= thd->variables.innodb_table_locks; my_bool old_innodb_table_locks= thd->variables.innodb_table_locks;
uint dummy;
/* used as fields initializator */ /* used as fields initializator */
lex_start(thd, 0, 0); lex_start(thd, 0, 0);
statistic_increment(thd->status_var.com_stat[SQLCOM_SHOW_FIELDS], statistic_increment(thd->status_var.com_stat[SQLCOM_SHOW_FIELDS],
&LOCK_status); &LOCK_status);
bzero((char*) &table_list,sizeof(table_list)); bzero((char*) &table_list,sizeof(table_list));
if (thd->copy_db_to(&table_list.db, 0)) if (thd->copy_db_to(&table_list.db, &dummy))
break; break;
pend= strend(packet); /*
We have name + wildcard in packet, separated by endzero
*/
arg_end= strend(packet);
thd->convert_string(&conv_name, system_charset_info, thd->convert_string(&conv_name, system_charset_info,
packet, (uint) (pend-packet), thd->charset()); packet, (uint) (arg_end - packet), thd->charset());
table_list.alias= table_list.table_name= conv_name.str; table_list.alias= table_list.table_name= conv_name.str;
packet= pend+1; packet= arg_end + 1;
if (!my_strcasecmp(system_charset_info, table_list.db, if (!my_strcasecmp(system_charset_info, table_list.db,
information_schema_name.str)) information_schema_name.str))
@@ -1901,7 +1928,7 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
table_list.schema_table= schema_table; table_list.schema_table= schema_table;
} }
thd->query_length= strlen(packet); // for simplicity: don't optimize thd->query_length= (uint) (packet_end - packet); // Don't count end \0
if (!(thd->query=fields=thd->memdup(packet,thd->query_length+1))) if (!(thd->query=fields=thd->memdup(packet,thd->query_length+1)))
break; break;
general_log_print(thd, command, "%s %s", table_list.table_name, fields); general_log_print(thd, command, "%s %s", table_list.table_name, fields);
@@ -1937,24 +1964,27 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
error=TRUE; // End server error=TRUE; // End server
break; break;
#ifdef REMOVED
case COM_CREATE_DB: // QQ: To be removed case COM_CREATE_DB: // QQ: To be removed
{ {
char *db=thd->strdup(packet), *alias; LEX_STRING db, alias;
HA_CREATE_INFO create_info; HA_CREATE_INFO create_info;
statistic_increment(thd->status_var.com_stat[SQLCOM_CREATE_DB], statistic_increment(thd->status_var.com_stat[SQLCOM_CREATE_DB],
&LOCK_status); &LOCK_status);
// null test to handle EOM if (thd->LEX_STRING_make(&db, packet, packet_length -1) ||
if (!db || !(alias= thd->strdup(db)) || check_db_name(db)) thd->LEX_STRING_make(&alias, db.str, db.length) ||
check_db_name(&db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), db ? db : "NULL"); my_error(ER_WRONG_DB_NAME, MYF(0), db.str ? db.str : "NULL");
break; break;
} }
if (check_access(thd,CREATE_ACL,db,0,1,0,is_schema_db(db))) if (check_access(thd, CREATE_ACL, db.str , 0, 1, 0,
is_schema_db(db.str)))
break; break;
general_log_print(thd, command, packet); general_log_print(thd, command, packet);
bzero(&create_info, sizeof(create_info)); bzero(&create_info, sizeof(create_info));
mysql_create_db(thd, (lower_case_table_names == 2 ? alias : db), mysql_create_db(thd, (lower_case_table_names == 2 ? alias.str : db.str),
&create_info, 0); &create_info, 0);
break; break;
} }
@@ -1962,14 +1992,15 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
{ {
statistic_increment(thd->status_var.com_stat[SQLCOM_DROP_DB], statistic_increment(thd->status_var.com_stat[SQLCOM_DROP_DB],
&LOCK_status); &LOCK_status);
char *db=thd->strdup(packet); LEX_STRING db;
/* null test to handle EOM */
if (!db || check_db_name(db)) if (thd->LEX_STRING_make(&db, packet, packet_length - 1) ||
check_db_name(&db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), db ? db : "NULL"); my_error(ER_WRONG_DB_NAME, MYF(0), db.str ? db.str : "NULL");
break; break;
} }
if (check_access(thd,DROP_ACL,db,0,1,0,is_schema_db(db))) if (check_access(thd, DROP_ACL, db.str, 0, 1, 0, is_schema_db(db.str)))
break; break;
if (thd->locked_tables || thd->active_transaction()) if (thd->locked_tables || thd->active_transaction())
{ {
@@ -1977,10 +2008,11 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0)); ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0));
break; break;
} }
general_log_print(thd, command, db); general_log_print(thd, command, db.str);
mysql_rm_db(thd, db, 0, 0); mysql_rm_db(thd, db.str, 0, 0);
break; break;
} }
#endif
#ifndef EMBEDDED_LIBRARY #ifndef EMBEDDED_LIBRARY
case COM_BINLOG_DUMP: case COM_BINLOG_DUMP:
{ {
@@ -2062,36 +2094,46 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
#endif #endif
case COM_STATISTICS: case COM_STATISTICS:
{ {
STATUS_VAR current_global_status_var;
ulong uptime;
uint length;
#ifndef EMBEDDED_LIBRARY
char buff[250];
uint buff_len= sizeof(buff);
#else
char *buff= thd->net.last_error;
uint buff_len= sizeof(thd->net.last_error);
#endif
general_log_print(thd, command, NullS); general_log_print(thd, command, NullS);
statistic_increment(thd->status_var.com_stat[SQLCOM_SHOW_STATUS], statistic_increment(thd->status_var.com_stat[SQLCOM_SHOW_STATUS],
&LOCK_status); &LOCK_status);
#ifndef EMBEDDED_LIBRARY
char buff[200];
#else
char *buff= thd->net.last_error;
#endif
STATUS_VAR current_global_status_var;
calc_sum_of_all_status(&current_global_status_var); calc_sum_of_all_status(&current_global_status_var);
uptime= (ulong) (thd->start_time - start_time);
ulong uptime = (ulong) (thd->start_time - start_time); length= my_snprintf((char*) buff, buff_len - 1,
sprintf((char*) buff, "Uptime: %lu Threads: %d Questions: %lu "
"Uptime: %lu Threads: %d Questions: %lu Slow queries: %lu Opens: %lu Flush tables: %lu Open tables: %u Queries per second avg: %.3f", "Slow queries: %lu Opens: %lu Flush tables: %lu "
"Open tables: %u Queries per second avg: %.3f",
uptime, uptime,
(int) thread_count, (ulong) thd->query_id, (int) thread_count, (ulong) thd->query_id,
current_global_status_var.long_query_count, current_global_status_var.long_query_count,
current_global_status_var.opened_tables, refresh_version, current_global_status_var.opened_tables,
refresh_version,
cached_open_tables(), cached_open_tables(),
(uptime ? (ulonglong2double(thd->query_id) / (double) uptime) : (uptime ? (ulonglong2double(thd->query_id) /
(double) 0)); (double) uptime) : (double) 0));
#ifdef SAFEMALLOC #ifdef SAFEMALLOC
if (sf_malloc_cur_memory) // Using SAFEMALLOC if (sf_malloc_cur_memory) // Using SAFEMALLOC
sprintf(strend(buff), " Memory in use: %ldK Max memory used: %ldK", {
char *end= buff + length;
length+= my_snprintf(end, buff_len - length - 1,
end," Memory in use: %ldK Max memory used: %ldK",
(sf_malloc_cur_memory+1023L)/1024L, (sf_malloc_cur_memory+1023L)/1024L,
(sf_malloc_max_memory+1023L)/1024L); (sf_malloc_max_memory+1023L)/1024L);
}
#endif #endif
#ifndef EMBEDDED_LIBRARY #ifndef EMBEDDED_LIBRARY
VOID(my_net_write(net, buff,(uint) strlen(buff))); VOID(my_net_write(net, buff, length));
VOID(net_flush(net)); VOID(net_flush(net));
#endif #endif
break; break;
@@ -2289,26 +2331,28 @@ int prepare_schema_table(THD *thd, LEX *lex, Table_ident *table_ident,
DBUG_RETURN(1); DBUG_RETURN(1);
#else #else
{ {
char *db; LEX_STRING db;
uint dummy;
if (lex->select_lex.db == NULL && if (lex->select_lex.db == NULL &&
thd->copy_db_to(&lex->select_lex.db, 0)) thd->copy_db_to(&lex->select_lex.db, &dummy))
{ {
DBUG_RETURN(1); DBUG_RETURN(1);
} }
db= lex->select_lex.db; db.str= lex->select_lex.db;
if (check_db_name(db)) db.length= strlen(db.str);
if (check_db_name(&db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), db); my_error(ER_WRONG_DB_NAME, MYF(0), db.str);
DBUG_RETURN(1); DBUG_RETURN(1);
} }
if (check_access(thd, SELECT_ACL, db, &thd->col_access, 0, 0, if (check_access(thd, SELECT_ACL, db.str, &thd->col_access, 0, 0,
is_schema_db(db))) is_schema_db(db.str)))
DBUG_RETURN(1); /* purecov: inspected */ DBUG_RETURN(1); /* purecov: inspected */
if (!thd->col_access && check_grant_db(thd,db)) if (!thd->col_access && check_grant_db(thd, db.str))
{ {
my_error(ER_DBACCESS_DENIED_ERROR, MYF(0), my_error(ER_DBACCESS_DENIED_ERROR, MYF(0),
thd->security_ctx->priv_user, thd->security_ctx->priv_host, thd->security_ctx->priv_user, thd->security_ctx->priv_host,
db); db.str);
DBUG_RETURN(1); DBUG_RETURN(1);
} }
break; break;
@@ -2848,11 +2892,6 @@ mysql_execute_command(THD *thd)
if (check_grant(thd, CREATE_ACL, all_tables, 0, 1, 0)) if (check_grant(thd, CREATE_ACL, all_tables, 0, 1, 0))
goto error; goto error;
} }
if (strlen(first_table->table_name) > NAME_LEN)
{
my_error(ER_WRONG_TABLE_NAME, MYF(0), first_table->table_name);
break;
}
pthread_mutex_lock(&LOCK_active_mi); pthread_mutex_lock(&LOCK_active_mi);
/* /*
fetch_master_table will send the error to the client on failure. fetch_master_table will send the error to the client on failure.
@@ -3087,11 +3126,6 @@ end_with_restore_list:
if (lex->alter_info.flags & ALTER_DROP_PARTITION) if (lex->alter_info.flags & ALTER_DROP_PARTITION)
priv_needed|= DROP_ACL; priv_needed|= DROP_ACL;
if (lex->name && (!lex->name[0] || strlen(lex->name) > NAME_LEN))
{
my_error(ER_WRONG_TABLE_NAME, MYF(0), lex->name);
goto error;
}
/* Must be set in the parser */ /* Must be set in the parser */
DBUG_ASSERT(select_lex->db); DBUG_ASSERT(select_lex->db);
if (check_access(thd, priv_needed, first_table->db, if (check_access(thd, priv_needed, first_table->db,
@@ -3107,11 +3141,11 @@ end_with_restore_list:
{ {
if (check_grant(thd, priv_needed, all_tables, 0, UINT_MAX, 0)) if (check_grant(thd, priv_needed, all_tables, 0, UINT_MAX, 0))
goto error; goto error;
if (lex->name && !test_all_bits(priv,INSERT_ACL | CREATE_ACL)) if (lex->name.str && !test_all_bits(priv,INSERT_ACL | CREATE_ACL))
{ // Rename of table { // Rename of table
TABLE_LIST tmp_table; TABLE_LIST tmp_table;
bzero((char*) &tmp_table,sizeof(tmp_table)); bzero((char*) &tmp_table,sizeof(tmp_table));
tmp_table.table_name=lex->name; tmp_table.table_name= lex->name.str;
tmp_table.db=select_lex->db; tmp_table.db=select_lex->db;
tmp_table.grant.privilege=priv; tmp_table.grant.privilege=priv;
if (check_grant(thd, INSERT_ACL | CREATE_ACL, &tmp_table, 0, if (check_grant(thd, INSERT_ACL | CREATE_ACL, &tmp_table, 0,
@@ -3139,7 +3173,7 @@ end_with_restore_list:
} }
thd->enable_slow_log= opt_log_slow_admin_statements; thd->enable_slow_log= opt_log_slow_admin_statements;
res= mysql_alter_table(thd, select_lex->db, lex->name, res= mysql_alter_table(thd, select_lex->db, lex->name.str,
&lex->create_info, &lex->create_info,
first_table, lex->create_list, first_table, lex->create_list,
lex->key_list, lex->key_list,
@@ -3732,9 +3766,10 @@ end_with_restore_list:
break; break;
} }
char *alias; char *alias;
if (!(alias=thd->strdup(lex->name)) || check_db_name(lex->name)) if (!(alias=thd->strmake(lex->name.str, lex->name.length)) ||
check_db_name(&lex->name))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), lex->name); my_error(ER_WRONG_DB_NAME, MYF(0), lex->name.str);
break; break;
} }
/* /*
@@ -3746,17 +3781,18 @@ end_with_restore_list:
*/ */
#ifdef HAVE_REPLICATION #ifdef HAVE_REPLICATION
if (thd->slave_thread && if (thd->slave_thread &&
(!rpl_filter->db_ok(lex->name) || (!rpl_filter->db_ok(lex->name.str) ||
!rpl_filter->db_ok_with_wild_table(lex->name))) !rpl_filter->db_ok_with_wild_table(lex->name.str)))
{ {
my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0)); my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0));
break; break;
} }
#endif #endif
if (check_access(thd,CREATE_ACL,lex->name,0,1,0,is_schema_db(lex->name))) if (check_access(thd,CREATE_ACL,lex->name.str, 0, 1, 0,
is_schema_db(lex->name.str)))
break; break;
res= mysql_create_db(thd,(lower_case_table_names == 2 ? alias : lex->name), res= mysql_create_db(thd,(lower_case_table_names == 2 ? alias :
&lex->create_info, 0); lex->name.str), &lex->create_info, 0);
break; break;
} }
case SQLCOM_DROP_DB: case SQLCOM_DROP_DB:
@@ -3766,9 +3802,9 @@ end_with_restore_list:
res= -1; res= -1;
break; break;
} }
if (check_db_name(lex->name)) if (check_db_name(&lex->name))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), lex->name); my_error(ER_WRONG_DB_NAME, MYF(0), lex->name.str);
break; break;
} }
/* /*
@@ -3780,14 +3816,15 @@ end_with_restore_list:
*/ */
#ifdef HAVE_REPLICATION #ifdef HAVE_REPLICATION
if (thd->slave_thread && if (thd->slave_thread &&
(!rpl_filter->db_ok(lex->name) || (!rpl_filter->db_ok(lex->name.str) ||
!rpl_filter->db_ok_with_wild_table(lex->name))) !rpl_filter->db_ok_with_wild_table(lex->name.str)))
{ {
my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0)); my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0));
break; break;
} }
#endif #endif
if (check_access(thd,DROP_ACL,lex->name,0,1,0,is_schema_db(lex->name))) if (check_access(thd,DROP_ACL,lex->name.str,0,1,0,
is_schema_db(lex->name.str)))
break; break;
if (thd->locked_tables || thd->active_transaction()) if (thd->locked_tables || thd->active_transaction())
{ {
@@ -3795,7 +3832,7 @@ end_with_restore_list:
ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0)); ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0));
goto error; goto error;
} }
res= mysql_rm_db(thd, lex->name, lex->drop_if_exists, 0); res= mysql_rm_db(thd, lex->name.str, lex->drop_if_exists, 0);
break; break;
} }
case SQLCOM_RENAME_DB: case SQLCOM_RENAME_DB:
@@ -3821,6 +3858,11 @@ end_with_restore_list:
break; break;
} }
#endif #endif
if (check_db_name(newdb))
{
my_error(ER_WRONG_DB_NAME, MYF(0), newdb->str);
break;
}
if (check_access(thd,ALTER_ACL,olddb->str,0,1,0,is_schema_db(olddb->str)) || if (check_access(thd,ALTER_ACL,olddb->str,0,1,0,is_schema_db(olddb->str)) ||
check_access(thd,DROP_ACL,olddb->str,0,1,0,is_schema_db(olddb->str)) || check_access(thd,DROP_ACL,olddb->str,0,1,0,is_schema_db(olddb->str)) ||
check_access(thd,CREATE_ACL,newdb->str,0,1,0,is_schema_db(newdb->str))) check_access(thd,CREATE_ACL,newdb->str,0,1,0,is_schema_db(newdb->str)))
@@ -3842,11 +3884,10 @@ end_with_restore_list:
} }
case SQLCOM_ALTER_DB: case SQLCOM_ALTER_DB:
{ {
char *db= lex->name; LEX_STRING *db= &lex->name;
DBUG_ASSERT(db); /* Must be set in the parser */ if (check_db_name(db))
if (!strip_sp(db) || check_db_name(db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), db); my_error(ER_WRONG_DB_NAME, MYF(0), db->str);
break; break;
} }
/* /*
@@ -3858,14 +3899,14 @@ end_with_restore_list:
*/ */
#ifdef HAVE_REPLICATION #ifdef HAVE_REPLICATION
if (thd->slave_thread && if (thd->slave_thread &&
(!rpl_filter->db_ok(db) || (!rpl_filter->db_ok(db->str) ||
!rpl_filter->db_ok_with_wild_table(db))) !rpl_filter->db_ok_with_wild_table(db->str)))
{ {
my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0)); my_message(ER_SLAVE_IGNORED_TABLE, ER(ER_SLAVE_IGNORED_TABLE), MYF(0));
break; break;
} }
#endif #endif
if (check_access(thd, ALTER_ACL, db, 0, 1, 0, is_schema_db(db))) if (check_access(thd, ALTER_ACL, db->str, 0, 1, 0, is_schema_db(db->str)))
break; break;
if (thd->locked_tables || thd->active_transaction()) if (thd->locked_tables || thd->active_transaction())
{ {
@@ -3873,17 +3914,17 @@ end_with_restore_list:
ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0)); ER(ER_LOCK_OR_ACTIVE_TRANSACTION), MYF(0));
goto error; goto error;
} }
res= mysql_alter_db(thd, db, &lex->create_info); res= mysql_alter_db(thd, db->str, &lex->create_info);
break; break;
} }
case SQLCOM_SHOW_CREATE_DB: case SQLCOM_SHOW_CREATE_DB:
{ {
if (!strip_sp(lex->name) || check_db_name(lex->name)) if (check_db_name(&lex->name))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), lex->name); my_error(ER_WRONG_DB_NAME, MYF(0), lex->name.str);
break; break;
} }
res=mysqld_show_create_db(thd,lex->name,&lex->create_info); res= mysqld_show_create_db(thd, lex->name.str, &lex->create_info);
break; break;
} }
case SQLCOM_CREATE_EVENT: case SQLCOM_CREATE_EVENT:
@@ -6329,7 +6370,7 @@ TABLE_LIST *st_select_lex::add_table_to_list(THD *thd,
} }
if (table->is_derived_table() == FALSE && table->db.str && if (table->is_derived_table() == FALSE && table->db.str &&
check_db_name(table->db.str)) check_db_name(&table->db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), table->db.str); my_error(ER_WRONG_DB_NAME, MYF(0), table->db.str);
DBUG_RETURN(0); DBUG_RETURN(0);
@@ -7613,7 +7654,7 @@ bool create_table_precheck(THD *thd, TABLE_LIST *tables,
#ifdef NOT_NECESSARY_TO_CHECK_CREATE_TABLE_EXIST_WHEN_PREPARING_STATEMENT #ifdef NOT_NECESSARY_TO_CHECK_CREATE_TABLE_EXIST_WHEN_PREPARING_STATEMENT
/* This code throws an ill error for CREATE TABLE t1 SELECT * FROM t1 */ /* This code throws an ill error for CREATE TABLE t1 SELECT * FROM t1 */
/* /*
Only do the check for PS, becasue we on execute we have to check that Only do the check for PS, because we on execute we have to check that
against the opened tables to ensure we don't use a table that is part against the opened tables to ensure we don't use a table that is part
of the view (which can only be done after the table has been opened). of the view (which can only be done after the table has been opened).
*/ */

166
sql/sql_parse.cc.rej Normal file
View File

@@ -0,0 +1,166 @@
***************
*** 67,109 ****
static void decrease_user_connections(USER_CONN *uc);
#endif /* NO_EMBEDDED_ACCESS_CHECKS */
static bool check_multi_update_lock(THD *thd);
- static void remove_escape(char *name);
static bool execute_sqlcom_select(THD *thd, TABLE_LIST *all_tables);
const char *any_db="*any*"; // Special symbol for check_access
! LEX_STRING command_name[]={
! (char *)STRING_WITH_LEN("Sleep"),
! (char *)STRING_WITH_LEN("Quit"),
! (char *)STRING_WITH_LEN("Init DB"),
! (char *)STRING_WITH_LEN("Query"),
! (char *)STRING_WITH_LEN("Field List"),
! (char *)STRING_WITH_LEN("Create DB"),
! (char *)STRING_WITH_LEN("Drop DB"),
! (char *)STRING_WITH_LEN("Refresh"),
! (char *)STRING_WITH_LEN("Shutdown"),
! (char *)STRING_WITH_LEN("Statistics"),
! (char *)STRING_WITH_LEN("Processlist"),
! (char *)STRING_WITH_LEN("Connect"),
! (char *)STRING_WITH_LEN("Kill"),
! (char *)STRING_WITH_LEN("Debug"),
! (char *)STRING_WITH_LEN("Ping"),
! (char *)STRING_WITH_LEN("Time"),
! (char *)STRING_WITH_LEN("Delayed insert"),
! (char *)STRING_WITH_LEN("Change user"),
! (char *)STRING_WITH_LEN("Binlog Dump"),
! (char *)STRING_WITH_LEN("Table Dump"),
! (char *)STRING_WITH_LEN("Connect Out"),
! (char *)STRING_WITH_LEN("Register Slave"),
! (char *)STRING_WITH_LEN("Prepare"),
! (char *)STRING_WITH_LEN("Execute"),
! (char *)STRING_WITH_LEN("Long Data"),
! (char *)STRING_WITH_LEN("Close stmt"),
! (char *)STRING_WITH_LEN("Reset stmt"),
! (char *)STRING_WITH_LEN("Set option"),
! (char *)STRING_WITH_LEN("Fetch"),
! (char *)STRING_WITH_LEN("Daemon"),
! (char *)STRING_WITH_LEN("Error") // Last command number
};
const char *xa_state_names[]={
--- 67,108 ----
static void decrease_user_connections(USER_CONN *uc);
#endif /* NO_EMBEDDED_ACCESS_CHECKS */
static bool check_multi_update_lock(THD *thd);
static bool execute_sqlcom_select(THD *thd, TABLE_LIST *all_tables);
const char *any_db="*any*"; // Special symbol for check_access
! const LEX_STRING command_name[]={
! C_STRING_WITH_LEN("Sleep"),
! C_STRING_WITH_LEN("Quit"),
! C_STRING_WITH_LEN("Init DB"),
! C_STRING_WITH_LEN("Query"),
! C_STRING_WITH_LEN("Field List"),
! C_STRING_WITH_LEN("Create DB"),
! C_STRING_WITH_LEN("Drop DB"),
! C_STRING_WITH_LEN("Refresh"),
! C_STRING_WITH_LEN("Shutdown"),
! C_STRING_WITH_LEN("Statistics"),
! C_STRING_WITH_LEN("Processlist"),
! C_STRING_WITH_LEN("Connect"),
! C_STRING_WITH_LEN("Kill"),
! C_STRING_WITH_LEN("Debug"),
! C_STRING_WITH_LEN("Ping"),
! C_STRING_WITH_LEN("Time"),
! C_STRING_WITH_LEN("Delayed insert"),
! C_STRING_WITH_LEN("Change user"),
! C_STRING_WITH_LEN("Binlog Dump"),
! C_STRING_WITH_LEN("Table Dump"),
! C_STRING_WITH_LEN("Connect Out"),
! C_STRING_WITH_LEN("Register Slave"),
! C_STRING_WITH_LEN("Prepare"),
! C_STRING_WITH_LEN("Execute"),
! C_STRING_WITH_LEN("Long Data"),
! C_STRING_WITH_LEN("Close stmt"),
! C_STRING_WITH_LEN("Reset stmt"),
! C_STRING_WITH_LEN("Set option"),
! C_STRING_WITH_LEN("Fetch"),
! C_STRING_WITH_LEN("Daemon"),
! C_STRING_WITH_LEN("Error") // Last command number
};
const char *xa_state_names[]={
***************
*** 1738,1744 ****
password. New clients send the size (1 byte) + string (not null
terminated, so also '\0' for empty string).
*/
! char db_buff[NAME_LEN+1]; // buffer to store db in utf8
char *db= passwd;
uint passwd_len= thd->client_capabilities & CLIENT_SECURE_CONNECTION ?
*passwd++ : strlen(passwd);
--- 1736,1742 ----
password. New clients send the size (1 byte) + string (not null
terminated, so also '\0' for empty string).
*/
! char db_buff[NAME_LEN+1]; // buffer to store db in utf8
char *db= passwd;
uint passwd_len= thd->client_capabilities & CLIENT_SECURE_CONNECTION ?
*passwd++ : strlen(passwd);
***************
*** 2315,2321 ****
DBUG_RETURN(1);
}
db= lex->select_lex.db;
- remove_escape(db); // Fix escaped '_'
if (check_db_name(db))
{
my_error(ER_WRONG_DB_NAME, MYF(0), db);
--- 2312,2317 ----
DBUG_RETURN(1);
}
db= lex->select_lex.db;
if (check_db_name(db))
{
my_error(ER_WRONG_DB_NAME, MYF(0), db);
***************
*** 6310,6345 ****
}
- /* Fix escaping of _, % and \ in database and table names (for ODBC) */
-
- static void remove_escape(char *name)
- {
- if (!*name) // For empty DB names
- return;
- char *to;
- #ifdef USE_MB
- char *strend=name+(uint) strlen(name);
- #endif
- for (to=name; *name ; name++)
- {
- #ifdef USE_MB
- int l;
- if (use_mb(system_charset_info) &&
- (l = my_ismbchar(system_charset_info, name, strend)))
- {
- while (l--)
- *to++ = *name++;
- name--;
- continue;
- }
- #endif
- if (*name == '\\' && name[1])
- name++; // Skip '\\'
- *to++= *name;
- }
- *to=0;
- }
-
/****************************************************************************
** save order by and tables in own lists
****************************************************************************/
--- 6296,6301 ----
}
/****************************************************************************
** save order by and tables in own lists
****************************************************************************/

2
sql/sql_table.cc
View File

@@ -4585,7 +4585,7 @@ bool mysql_create_like_table(THD* thd, TABLE_LIST* table,
my_error(ER_WRONG_TABLE_NAME, MYF(0), src_table); my_error(ER_WRONG_TABLE_NAME, MYF(0), src_table);
DBUG_RETURN(TRUE); DBUG_RETURN(TRUE);
} }
if (!src_db || check_db_name(src_db)) if (!src_db || check_db_name(&table_ident->db))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), src_db ? src_db : "NULL"); my_error(ER_WRONG_DB_NAME, MYF(0), src_db ? src_db : "NULL");
DBUG_RETURN(-1); DBUG_RETURN(-1);

38
sql/sql_yacc.yy
View File

@@ -751,7 +751,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, ulong *yystacksize);
LEX_HOSTNAME ULONGLONG_NUM field_ident select_alias ident ident_or_text LEX_HOSTNAME ULONGLONG_NUM field_ident select_alias ident ident_or_text
UNDERSCORE_CHARSET IDENT_sys TEXT_STRING_sys TEXT_STRING_literal UNDERSCORE_CHARSET IDENT_sys TEXT_STRING_sys TEXT_STRING_literal
NCHAR_STRING opt_component key_cache_name NCHAR_STRING opt_component key_cache_name
sp_opt_label BIN_NUM label_ident TEXT_STRING_filesystem sp_opt_label BIN_NUM label_ident TEXT_STRING_filesystem ident_or_empty
%type <lex_str_ptr> %type <lex_str_ptr>
opt_table_alias opt_table_alias
@@ -761,7 +761,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, ulong *yystacksize);
%type <simple_string> %type <simple_string>
remember_name remember_end opt_ident opt_db text_or_password remember_name remember_end opt_ident opt_db text_or_password
opt_constraint constraint ident_or_empty opt_constraint constraint
%type <string> %type <string>
text_string opt_gconcat_separator text_string opt_gconcat_separator
@@ -1240,7 +1240,8 @@ create:
lex->create_info.options=$2 | $4; lex->create_info.options=$2 | $4;
lex->create_info.db_type= lex->thd->variables.table_type; lex->create_info.db_type= lex->thd->variables.table_type;
lex->create_info.default_table_charset= NULL; lex->create_info.default_table_charset= NULL;
lex->name= 0; lex->name.str= 0;
lex->name.length= 0;
lex->like_name= 0; lex->like_name= 0;
} }
create2 create2
@@ -1280,7 +1281,7 @@ create:
{ {
LEX *lex=Lex; LEX *lex=Lex;
lex->sql_command=SQLCOM_CREATE_DB; lex->sql_command=SQLCOM_CREATE_DB;
lex->name=$4.str; lex->name= $4;
lex->create_info.options=$3; lex->create_info.options=$3;
} }
| CREATE | CREATE
@@ -1516,7 +1517,7 @@ clear_privileges:
sp_name: sp_name:
ident '.' ident ident '.' ident
{ {
if (!$1.str || check_db_name($1.str)) if (!$1.str || check_db_name(&$1))
{ {
my_error(ER_WRONG_DB_NAME, MYF(0), $1.str); my_error(ER_WRONG_DB_NAME, MYF(0), $1.str);
YYABORT; YYABORT;
@@ -3101,7 +3102,7 @@ size_number:
uint text_shift_number= 0; uint text_shift_number= 0;
longlong prefix_number; longlong prefix_number;
char *start_ptr= $1.str; char *start_ptr= $1.str;
uint str_len= strlen(start_ptr); uint str_len= $1.length;
char *end_ptr= start_ptr + str_len; char *end_ptr= start_ptr + str_len;
int error; int error;
prefix_number= my_strtoll10(start_ptr, &end_ptr, &error); prefix_number= my_strtoll10(start_ptr, &end_ptr, &error);
@@ -4612,7 +4613,8 @@ alter:
{ {
THD *thd= YYTHD; THD *thd= YYTHD;
LEX *lex= thd->lex; LEX *lex= thd->lex;
lex->name= 0; lex->name.str= 0;
lex->name.length= 0;
lex->sql_command= SQLCOM_ALTER_TABLE; lex->sql_command= SQLCOM_ALTER_TABLE;
lex->duplicates= DUP_ERROR; lex->duplicates= DUP_ERROR;
if (!lex->select_lex.add_table_to_list(thd, $4, NULL, if (!lex->select_lex.add_table_to_list(thd, $4, NULL,
@@ -4622,7 +4624,6 @@ alter:
lex->key_list.empty(); lex->key_list.empty();
lex->col_list.empty(); lex->col_list.empty();
lex->select_lex.init_order(); lex->select_lex.init_order();
lex->name= 0;
lex->like_name= 0; lex->like_name= 0;
lex->select_lex.db= lex->select_lex.db=
((TABLE_LIST*) lex->select_lex.table_list.first)->db; ((TABLE_LIST*) lex->select_lex.table_list.first)->db;
@@ -4647,7 +4648,8 @@ alter:
THD *thd= Lex->thd; THD *thd= Lex->thd;
lex->sql_command=SQLCOM_ALTER_DB; lex->sql_command=SQLCOM_ALTER_DB;
lex->name= $3; lex->name= $3;
if (lex->name == NULL && thd->copy_db_to(&lex->name, NULL)) if (lex->name.str == NULL &&
thd->copy_db_to(&lex->name.str, &lex->name.length))
YYABORT; YYABORT;
} }
| ALTER PROCEDURE sp_name | ALTER PROCEDURE sp_name
@@ -4800,8 +4802,8 @@ opt_ev_sql_stmt: /* empty*/ { $$= 0;}
ident_or_empty: ident_or_empty:
/* empty */ { $$= 0; } /* empty */ { $$.str= 0; $$.length= 0; }
| ident { $$= $1.str; }; | ident { $$= $1; };
alter_commands: alter_commands:
| DISCARD TABLESPACE { Lex->alter_info.tablespace_op= DISCARD_TABLESPACE; } | DISCARD TABLESPACE { Lex->alter_info.tablespace_op= DISCARD_TABLESPACE; }
@@ -5079,19 +5081,20 @@ alter_list_item:
{ {
LEX *lex=Lex; LEX *lex=Lex;
THD *thd= lex->thd; THD *thd= lex->thd;
uint dummy;
lex->select_lex.db=$3->db.str; lex->select_lex.db=$3->db.str;
if (lex->select_lex.db == NULL && if (lex->select_lex.db == NULL &&
thd->copy_db_to(&lex->select_lex.db, NULL)) thd->copy_db_to(&lex->select_lex.db, &dummy))
{ {
YYABORT; YYABORT;
} }
if (check_table_name($3->table.str,$3->table.length) || if (check_table_name($3->table.str,$3->table.length) ||
$3->db.str && check_db_name($3->db.str)) $3->db.str && check_db_name(&$3->db))
{ {
my_error(ER_WRONG_TABLE_NAME, MYF(0), $3->table.str); my_error(ER_WRONG_TABLE_NAME, MYF(0), $3->table.str);
YYABORT; YYABORT;
} }
lex->name= $3->table.str; lex->name= $3->table;
lex->alter_info.flags|= ALTER_RENAME; lex->alter_info.flags|= ALTER_RENAME;
} }
| CONVERT_SYM TO_SYM charset charset_name_or_default opt_collate | CONVERT_SYM TO_SYM charset charset_name_or_default opt_collate
@@ -7678,7 +7681,7 @@ drop:
LEX *lex=Lex; LEX *lex=Lex;
lex->sql_command= SQLCOM_DROP_DB; lex->sql_command= SQLCOM_DROP_DB;
lex->drop_if_exists=$3; lex->drop_if_exists=$3;
lex->name=$4.str; lex->name= $4;
} }
| DROP FUNCTION_SYM if_exists sp_name | DROP FUNCTION_SYM if_exists sp_name
{ {
@@ -8325,7 +8328,7 @@ show_param:
{ {
Lex->sql_command=SQLCOM_SHOW_CREATE_DB; Lex->sql_command=SQLCOM_SHOW_CREATE_DB;
Lex->create_info.options=$3; Lex->create_info.options=$3;
Lex->name=$4.str; Lex->name= $4;
} }
| CREATE TABLE_SYM table_ident | CREATE TABLE_SYM table_ident
{ {
@@ -10325,7 +10328,8 @@ grant_ident:
{ {
LEX *lex= Lex; LEX *lex= Lex;
THD *thd= lex->thd; THD *thd= lex->thd;
if (thd->copy_db_to(&lex->current_select->db, NULL)) uint dummy;
if (thd->copy_db_to(&lex->current_select->db, &dummy))
YYABORT; YYABORT;
if (lex->grant == GLOBAL_ACLS) if (lex->grant == GLOBAL_ACLS)
lex->grant = DB_ACLS & ~GRANT_ACL; lex->grant = DB_ACLS & ~GRANT_ACL;

36
sql/table.cc
View File

@@ -2245,7 +2245,7 @@ char *get_field(MEM_ROOT *mem, Field *field)
SYNPOSIS SYNPOSIS
check_db_name() check_db_name()
name Name of database org_name Name of database and length
NOTES NOTES
If lower_case_table_names is set then database is converted to lower case If lower_case_table_names is set then database is converted to lower case
@@ -2255,35 +2255,35 @@ char *get_field(MEM_ROOT *mem, Field *field)
1 error 1 error
*/ */
bool check_db_name(char *name) bool check_db_name(LEX_STRING *org_name)
{ {
char *start= name; char *name= org_name->str;
/* Used to catch empty names and names with end space */
bool last_char_is_space= TRUE; if (!org_name->length || org_name->length > NAME_LEN)
return 1;
if (lower_case_table_names && name != any_db) if (lower_case_table_names && name != any_db)
my_casedn_str(files_charset_info, name); my_casedn_str(files_charset_info, name);
while (*name)
{
#if defined(USE_MB) && defined(USE_MB_IDENT) #if defined(USE_MB) && defined(USE_MB_IDENT)
last_char_is_space= my_isspace(system_charset_info, *name);
if (use_mb(system_charset_info)) if (use_mb(system_charset_info))
{ {
int len=my_ismbchar(system_charset_info, name, bool last_char_is_space= TRUE;
name+system_charset_info->mbmaxlen); char *end= name + org_name->length;
if (len) while (name < end)
{ {
name += len; int len;
continue; last_char_is_space= my_isspace(system_charset_info, *name);
len= my_ismbchar(system_charset_info, name, end);
if (!len)
len= 1;
name+= len;
} }
return last_char_is_space;
} }
#else else
last_char_is_space= *name==' ';
#endif #endif
name++; return org_name->str[org_name->length - 1] != ' '; /* purecov: inspected */
}
return last_char_is_space || (uint) (name - start) > NAME_LEN;
} }

17
sql/table.cc.rej Normal file
View File

@@ -0,0 +1,17 @@
***************
*** 2246,2252 ****
bool check_db_name(char *name)
{
! char *start=name;
/* Used to catch empty names and names with end space */
bool last_char_is_space= TRUE;
--- 2257,2263 ----
bool check_db_name(char *name)
{
! char *start= name;
/* Used to catch empty names and names with end space */
bool last_char_is_space= TRUE;

34
tests/mysql_client_test.c
View File

@@ -33,6 +33,7 @@
#include <errmsg.h> #include <errmsg.h>
#include <my_getopt.h> #include <my_getopt.h>
#include <m_string.h> #include <m_string.h>
#include <mysqld_error.h>
#define VER "2.1" #define VER "2.1"
#define MAX_TEST_QUERY_LENGTH 300 /* MAX QUERY BUFFER LENGTH */ #define MAX_TEST_QUERY_LENGTH 300 /* MAX QUERY BUFFER LENGTH */
@@ -11991,13 +11992,21 @@ static void test_bug6081()
rc= simple_command(mysql, COM_DROP_DB, current_db, rc= simple_command(mysql, COM_DROP_DB, current_db,
(ulong)strlen(current_db), 0); (ulong)strlen(current_db), 0);
myquery(rc); if (rc == 0 && mysql_errno(mysql) != ER_UNKNOWN_COM_ERROR)
{
myerror(NULL); /* purecov: inspected */
die(__FILE__, __LINE__, "COM_DROP_DB failed"); /* purecov: inspected */
}
rc= simple_command(mysql, COM_DROP_DB, current_db, rc= simple_command(mysql, COM_DROP_DB, current_db,
(ulong)strlen(current_db), 0); (ulong)strlen(current_db), 0);
myquery_r(rc); myquery_r(rc);
rc= simple_command(mysql, COM_CREATE_DB, current_db, rc= simple_command(mysql, COM_CREATE_DB, current_db,
(ulong)strlen(current_db), 0); (ulong)strlen(current_db), 0);
myquery(rc); if (rc == 0 && mysql_errno(mysql) != ER_UNKNOWN_COM_ERROR)
{
myerror(NULL); /* purecov: inspected */
die(__FILE__, __LINE__, "COM_CREATE_DB failed"); /* purecov: inspected */
}
rc= simple_command(mysql, COM_CREATE_DB, current_db, rc= simple_command(mysql, COM_CREATE_DB, current_db,
(ulong)strlen(current_db), 0); (ulong)strlen(current_db), 0);
myquery_r(rc); myquery_r(rc);
@@ -15343,7 +15352,7 @@ static void test_bug15752()
MYSQL mysql_local; MYSQL mysql_local;
int rc, i; int rc, i;
const int ITERATION_COUNT= 100; const int ITERATION_COUNT= 100;
char *query= "CALL p1()"; const char *query= "CALL p1()";
myheader("test_bug15752"); myheader("test_bug15752");
@@ -15438,6 +15447,24 @@ static void test_bug21206()
DBUG_VOID_RETURN; DBUG_VOID_RETURN;
} }
/*
Ensure we execute the status code while testing
*/
static void test_status()
{
const char *status;
DBUG_ENTER("test_status");
myheader("test_status");
if (!(status= mysql_stat(mysql)))
{
myerror("mysql_stat failed"); /* purecov: inspected */
die(__FILE__, __LINE__, "mysql_stat failed"); /* purecov: inspected */
}
DBUG_VOID_RETURN;
}
/* /*
Bug#21726: Incorrect result with multiple invocations of Bug#21726: Incorrect result with multiple invocations of
LAST_INSERT_ID LAST_INSERT_ID
@@ -15753,6 +15780,7 @@ static struct my_tests_st my_tests[]= {
{ "test_bug19671", test_bug19671 }, { "test_bug19671", test_bug19671 },
{ "test_bug21206", test_bug21206 }, { "test_bug21206", test_bug21206 },
{ "test_bug21726", test_bug21726 }, { "test_bug21726", test_bug21726 },
{ "test_status", test_status},
{ 0, 0 } { 0, 0 }
}; };

20
tests/mysql_client_test.c.rej Normal file
View File

@@ -0,0 +1,20 @@
***************
*** 15693,15700 ****
{ "test_bug17667", test_bug17667 },
{ "test_bug15752", test_bug15752 },
{ "test_mysql_insert_id", test_mysql_insert_id },
! { "test_bug19671", test_bug19671},
! { "test_bug21206", test_bug21206},
{ 0, 0 }
};
--- 15776,15784 ----
{ "test_bug17667", test_bug17667 },
{ "test_bug15752", test_bug15752 },
{ "test_mysql_insert_id", test_mysql_insert_id },
! { "test_bug19671", test_bug19671 },
! { "test_bug21206", test_bug21206 },
! { "test_bug21726", test_bug21726 },
{ 0, 0 }
};