database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-20 10:24:14 +03:00
Code Activity

MDEV-22949 perfschema.memory_aggregate_no_a_no_u fails sporadically in buildbot with wrong result

Browse Source 
perfschema aggregation, like SHOW STATUS, is only statistically correct.
It doesn't use atomics for performance reasons and might miss individual
increments, particularly when two connections are disconnecting at the
same time.

To have stable results tests should avoid doing it.
This commit is contained in:
Sergei Golubchik
2024-03-26 20:59:42 +01:00
parent 89fd381be8
commit 8bb8820df2
9 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/suite/perfschema/include/memory_aggregate_load.inc
View File

@ -274,7 +274,6 @@ execute dump_users;
execute dump_hosts;
--disconnect con1
--disconnect con5
--connection default
@ -283,6 +282,8 @@ let $wait_condition=
select count(*) = 0 from performance_schema.threads
where `TYPE`='FOREGROUND' and PROCESSLIST_USER= 'user1';
--source include/wait_condition.inc
--disconnect con5
let $wait_condition=
select count(*) = 1 from performance_schema.threads
where `TYPE`='FOREGROUND' and PROCESSLIST_USER= 'user4';

2
mysql-test/suite/perfschema/r/memory_aggregate.result
View File

@ -2507,8 +2507,8 @@ execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
localhost 6 6
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_a.result
View File

@ -1903,8 +1903,8 @@ execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
localhost 6 6
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_a_no_h.result
View File

@ -1653,8 +1653,8 @@ user4 2 2
execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_a_no_u.result
View File

@ -1343,8 +1343,8 @@ execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
localhost 6 6
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_a_no_u_no_h.result
View File

@ -1093,8 +1093,8 @@ USER CURRENT_CONNECTIONS TOTAL_CONNECTIONS
execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_h.result
View File

@ -2257,8 +2257,8 @@ user4 2 2
execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_u.result
View File

@ -1947,8 +1947,8 @@ execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
localhost 6 6
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();

2
mysql-test/suite/perfschema/r/memory_aggregate_no_u_no_h.result
View File

@ -1697,8 +1697,8 @@ USER CURRENT_CONNECTIONS TOTAL_CONNECTIONS
execute dump_hosts;
HOST CURRENT_CONNECTIONS TOTAL_CONNECTIONS
disconnect con1;
disconnect con5;
connection default;
disconnect con5;
"================== con1/con5 disconnected =================="
"================== Step 10 =================="
call dump_thread();