mirror of
https://github.com/MariaDB/server.git
synced 2026-01-06 05:22:24 +03:00
MDEV-19595 fixed
The test cases for the MDEV found several independent bugs in MariaDB server and Aria: - If a temporary table was marked as crashed, it could never be deleted. - Opening of a crashed temporary table gave an error message but the error was never forwarded to the caller which caused an assert() in my_ok() - init_read_record() did mmap of all temporary tables, which is probably not a good idea as this area can potentially be very big. Changed code to only mmap internal temporary tables. - mmap-ed tables where not unmapped in case of repair/optimize which caused bad data in table and crashes if the original table files where replaced with new ones (as the old mmap was still in place). Fixed by removing the mmap in case of repair. - Cleaned up usage of code that disabled mmap in Aria
This commit is contained in:
@@ -779,7 +779,6 @@ void init_update_queries(void)
|
||||
Note that SQLCOM_RENAME_TABLE should not be in this list!
|
||||
*/
|
||||
sql_command_flags[SQLCOM_CREATE_TABLE]|= CF_PREOPEN_TMP_TABLES;
|
||||
sql_command_flags[SQLCOM_DROP_TABLE]|= CF_PREOPEN_TMP_TABLES;
|
||||
sql_command_flags[SQLCOM_CREATE_INDEX]|= CF_PREOPEN_TMP_TABLES;
|
||||
sql_command_flags[SQLCOM_ALTER_TABLE]|= CF_PREOPEN_TMP_TABLES;
|
||||
sql_command_flags[SQLCOM_TRUNCATE]|= CF_PREOPEN_TMP_TABLES;
|
||||
@@ -4459,7 +4458,14 @@ mysql_execute_command(THD *thd)
|
||||
}
|
||||
case SQLCOM_DROP_TABLE:
|
||||
{
|
||||
int result;
|
||||
DBUG_ASSERT(first_table == all_tables && first_table != 0);
|
||||
|
||||
thd->open_options|= HA_OPEN_FOR_REPAIR;
|
||||
result= thd->open_temporary_tables(all_tables);
|
||||
thd->open_options&= ~HA_OPEN_FOR_REPAIR;
|
||||
if (result)
|
||||
goto error;
|
||||
if (!lex->tmp_table())
|
||||
{
|
||||
if (check_table_access(thd, DROP_ACL, all_tables, FALSE, UINT_MAX, FALSE))
|
||||
|
||||
Reference in New Issue
Block a user