database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-28965 Assertion failure when preparing UPDATE with derived table in WHERE

Browse Source 
This patch fixes not only the assertion failure in the function
Field_iterator_table_ref::set_field_iterator() but also:
 - fixes the problem of forced materialization of derived tables used
   in subqueries contained in WHERE clauses of single-table and multi-table
   UPDATE and DELETE statements
 - fixes the problem of MDEV-17954 that prevented execution of multi-table
   DELETE statements if they use in their WHERE clauses references to
   the tables that are updated.

The patch must be considered a complement to the patch for MDEV-28883.

Approved by Oleksandr Byelkin <sanja@mariadb.com>
This commit is contained in:
Igor Babaev
2022-07-11 16:57:37 -07:00
parent 3a9358a410
commit 88ca62dc68
27 changed files with 1106 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

208
mysql-test/main/derived.test
View File

@@ -1246,3 +1246,211 @@ drop table t1;
--echo #
--echo # End of 11.0 tests
--echo #
--echo #
--echo # MDEV-28883: single/multi-table UPDATE/DELETE whose WHERE condition
--echo # contains subquery from mergeable derived table
--echo # that uses the updated/deleted table
--echo #
create table t1 (pk int, a int);
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
let $q1=
update t1 set a = 10
where a = ( select * from (select a from t1) dt where dt.a > 7);
eval explain $q1;
eval $q1;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q1";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
let $q2=
update t1 set a = 10
where a <> ( select * from (select a from t1) dt where dt.a > 7)
order by a limit 2;
eval explain $q2;
eval $q2;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
eval prepare stmt from "$q2";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
let $q3=
delete from t1
where a = ( select * from (select a from t1) dt where dt.a > 7);
eval explain $q3;
eval $q3;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q3";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
let $q4=
delete from t1
where a = ( select * from (select a from t1) dt where dt.a > 5)
returning pk, a;
eval explain $q4;
eval $q4;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
eval prepare stmt from "$q4";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
let $q5=
delete from t1
where a <> ( select * from (select a from t1) dt where dt.a > 7)
order by a limit 2;
eval explain $q5;
eval $q5;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q5";
execute stmt;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
execute stmt;
select * from t1;
deallocate prepare stmt;
create table t2 (pk int, a int);
insert into t2 values (1,3), (2, 7), (3,1), (4,9);
create table t3 (a int);
insert into t3 VALUES (0),(1);
let $q6=
update t1,t3 set t1.a = 1
where t1.a=t3.a and
t1.a = ( select * from (select a from t1) dt where dt.a > 7);
eval explain $q6;
eval $q6;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q6";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
let $q7=
update t1,t3 set t1.a = 1
where t1.a=t3.a and
t1.a = ( select * from (select a from t2) dt where dt.a > 7);
eval explain $q7;
eval $q7;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q7";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
insert into t3 values (9), (10), (7);
let $q8=
delete from t1 using t1,t3
where t1.a=t3.a and
t1.a = ( select * from (select a from t1) dt where dt.a > 7);
eval explain $q8;
eval $q8;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q8";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
let $q9=
delete from t1 using t1,t3
where t1.a=t3.a and
t1.a = ( select * from (select a from t2) dt where dt.a > 7);
eval explain $q9;
eval $q9;
select * from t1;
delete from t1;
insert into t1 values (1,3), (2, 7), (3,1), (4,9);
eval prepare stmt from "$q9";
execute stmt;
select * from t1;
delete from t1;
insert into t1 value (4,9), (3,1), (1,3);
execute stmt;
select * from t1;
deallocate prepare stmt;
drop table t1,t2,t3;
--echo # End of MariaDB 11.1 tests