1
0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00

MDEV-34705: Binlog-in-engine: Protect against concurrent RESET MASTER and dump threads

This is actually an existing problem in the old binlog implementation, and
this patch is applicable to old binlog also. The problem is that RESET
MASTER can run concurrently with binlog dump threads / connected slaves.
This will remove the binlog from under the feet of the reader, which can
cause all sorts of strange behaviour.

This patch fixes the problem by disallowing to run RESET MASTER when dump
threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is
thrown in this case, user must stop slaves and/or kill dump threads to make
the RESET MASTER go through. A slave that connects in the middle of RESET
MASTER will wait for it to complete.

Fix a lot of test cases to kill any lingering dump threads before doing
RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc.

Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
This commit is contained in:
Kristian Nielsen
2025-06-10 00:52:03 +02:00
parent d26851a575
commit 84da20e658
192 changed files with 789 additions and 53 deletions

View File

@@ -1,6 +1,7 @@
connect (master,$IPv6,root,,test,$MASTER_MYPORT);
connect (slave,127.0.0.1,root,,test,$SLAVE_MYPORT);
connection master;
--source include/kill_binlog_dump_threads.inc
reset master;
source include/show_master_status.inc;
save_master_pos;