database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

Bug#38338: REPLACE causes last_insert_id() to return an incorrect value

Browse Source 
Fix the write_record function to record auto increment
values in a consistent way.
This commit is contained in:
Narayanan V
2008-09-16 18:37:59 +05:30
parent a7bc87b39c
commit 83ef8f3427
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mysql-test/r/auto_increment.result
View File

@@ -454,3 +454,11 @@ select last_insert_id();
last_insert_id() last_insert_id()
3 3
drop table t1; drop table t1;
create table t1 (a int primary key auto_increment, b int, c int, e int, d timestamp default current_timestamp, unique(b),unique(c),unique(e));
insert into t1 values(null,1,1,1,now());
insert into t1 values(null,0,0,0,null);
replace into t1 values(null,1,0,2,null);
select last_insert_id();
last_insert_id()
3
drop table t1;

12
mysql-test/t/auto_increment.test
View File

@@ -314,5 +314,15 @@ insert into t1 values(null,0,0,null);
# this will delete two rows # this will delete two rows
replace into t1 values(null,1,0,null); replace into t1 values(null,1,0,null);
select last_insert_id(); select last_insert_id();
drop table t1;
# Test of REPLACE when it does a INSERT+DELETE for all the conflicting rows
# (i.e.) when there are three rows conflicting in unique key columns with
# a row that is being inserted, all the three rows will be deleted and then
# the new rows will be inserted.
create table t1 (a int primary key auto_increment, b int, c int, e int, d timestamp default current_timestamp, unique(b),unique(c),unique(e));
insert into t1 values(null,1,1,1,now());
insert into t1 values(null,0,0,0,null);
replace into t1 values(null,1,0,2,null);
select last_insert_id();
drop table t1; drop table t1;

11
sql/sql_insert.cc
View File

@@ -1545,6 +1545,17 @@ int write_record(THD *thd, TABLE *table,COPY_INFO *info)
} }
} }
} }
/*
If more than one iteration of the above while loop is done, from the second
one the row being inserted will have an explicit value in the autoinc field,
which was set at the first call of handler::update_auto_increment(). This
value is saved to avoid thd->insert_id_for_cur_row becoming 0. Use this saved
autoinc value.
*/
if (table->file->insert_id_for_cur_row == 0)
table->file->insert_id_for_cur_row= insert_id_for_cur_row;
thd->record_first_successful_insert_id_in_cur_stmt(table->file->insert_id_for_cur_row); thd->record_first_successful_insert_id_in_cur_stmt(table->file->insert_id_for_cur_row);
/* /*
Restore column maps if they where replaced during an duplicate key Restore column maps if they where replaced during an duplicate key