MDEV-4645: Incorrect reads of frozen binlog events; FDE corrupted in relay log

Browse Source

Currently several places use description_event->common_header_len instead of
  LOG_EVENT_MINIMAL_HEADER_LEN when parsing events with "frozen" headers (such
  as Start_event_v3 and its subclasses such as Format_description_log_event, as
  well as Rotate_event). This causes events with extra headers (which would otherwise
  be valid and those headers ignored) to be corrupted due to over-reading or skipping
  into the data portion of the log events.
  
  It is rewritten in some details patch of Jeremy Cole (See MDEV):
  - The virtual function returns length to avoid IFs (and only one call of the virtual function made)
  - Printing function avoids printing strings

...

This commit is contained in:

unknown

2013-09-12 21:36:58 +03:00

parent ada15c7a0f

commit 7a80c534ad

8 changed files with 538 additions and 91 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

mysql-test/std_data/mdev-4645-binlog_checksum.binlog Normal file

Binary file not shown.

BIN

mysql-test/std_data/mdev-4645-binlog_group_id.binlog Normal file

Binary file not shown.

BIN

mysql-test/std_data/mdev-4645-binlog_group_id_checksum.binlog Normal file

Binary file not shown.

BIN

mysql-test/std_data/mdev-4645-binlog_none.binlog Normal file

Binary file not shown.